* [PATCH 1/2] media: mx2-emmaprp: Add devicetree support @ 2014-05-27 7:47 Alexander Shiyan 2014-05-28 9:46 ` Sylwester Nawrocki 0 siblings, 1 reply; 4+ messages in thread From: Alexander Shiyan @ 2014-05-27 7:47 UTC (permalink / raw) To: linux-media Cc: Mauro Carvalho Chehab, Shawn Guo, Sascha Hauer, Alexander Shiyan This patch adds devicetree support for the Freescale enhanced Multimedia Accelerator (eMMA) video Pre-processor (PrP). Signed-off-by: Alexander Shiyan <shc_work@mail.ru> --- drivers/media/platform/mx2_emmaprp.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/media/platform/mx2_emmaprp.c b/drivers/media/platform/mx2_emmaprp.c index fa8f7ca..0646bda 100644 --- a/drivers/media/platform/mx2_emmaprp.c +++ b/drivers/media/platform/mx2_emmaprp.c @@ -18,6 +18,7 @@ */ #include <linux/module.h> #include <linux/clk.h> +#include <linux/of.h> #include <linux/slab.h> #include <linux/interrupt.h> #include <linux/io.h> @@ -1005,12 +1006,19 @@ static int emmaprp_remove(struct platform_device *pdev) return 0; } +static const struct of_device_id __maybe_unused emmaprp_dt_ids[] = { + { .compatible = "fsl,imx21-emmaprp", }, + { } +}; +MODULE_DEVICE_TABLE(of, emmaprp_dt_ids); + static struct platform_driver emmaprp_pdrv = { .probe = emmaprp_probe, .remove = emmaprp_remove, .driver = { .name = MEM2MEM_NAME, .owner = THIS_MODULE, + .of_match_table = of_match_ptr(emmaprp_dt_ids), }, }; module_platform_driver(emmaprp_pdrv); -- 1.8.5.5 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] media: mx2-emmaprp: Add devicetree support 2014-05-27 7:47 [PATCH 1/2] media: mx2-emmaprp: Add devicetree support Alexander Shiyan @ 2014-05-28 9:46 ` Sylwester Nawrocki 2014-05-28 10:02 ` Alexander Shiyan 0 siblings, 1 reply; 4+ messages in thread From: Sylwester Nawrocki @ 2014-05-28 9:46 UTC (permalink / raw) To: Alexander Shiyan Cc: linux-media, Mauro Carvalho Chehab, Shawn Guo, Sascha Hauer On 27/05/14 09:47, Alexander Shiyan wrote: > This patch adds devicetree support for the Freescale enhanced Multimedia > Accelerator (eMMA) video Pre-processor (PrP). > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru> > --- > drivers/media/platform/mx2_emmaprp.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/media/platform/mx2_emmaprp.c b/drivers/media/platform/mx2_emmaprp.c > index fa8f7ca..0646bda 100644 > --- a/drivers/media/platform/mx2_emmaprp.c > +++ b/drivers/media/platform/mx2_emmaprp.c > @@ -18,6 +18,7 @@ > */ > #include <linux/module.h> > #include <linux/clk.h> > +#include <linux/of.h> > #include <linux/slab.h> > #include <linux/interrupt.h> > #include <linux/io.h> > @@ -1005,12 +1006,19 @@ static int emmaprp_remove(struct platform_device *pdev) > return 0; > } > > +static const struct of_device_id __maybe_unused emmaprp_dt_ids[] = { > + { .compatible = "fsl,imx21-emmaprp", }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, emmaprp_dt_ids); > + > static struct platform_driver emmaprp_pdrv = { > .probe = emmaprp_probe, > .remove = emmaprp_remove, > .driver = { > .name = MEM2MEM_NAME, > .owner = THIS_MODULE, > + .of_match_table = of_match_ptr(emmaprp_dt_ids), > }, > }; > module_platform_driver(emmaprp_pdrv); The patch looks good, but the DT binding documentation patch should normally precede the related driver patch in the series. That way we could avoid checkpatch warnings like: WARNING: DT compatible string "fsl,imx21-emmaprp" appears un-documented -- check ./Documentation/devicetree/bindings/ #76: FILE: drivers/media/platform/mx2_emmaprp.c:1010: + { .compatible = "fsl,imx21-emmaprp", }, Wouldn't it make sense to also ad second entry with "fsl,imx27-emmaprp" compatible ? Could you also fix the remaining checkpatch warnings: WARNING: Use a single space after To: #35: To: linux-media@vger.kernel.org WARNING: Use a single space after Cc: #36: Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>, ERROR: DOS line endings #67: FILE: drivers/media/platform/mx2_emmaprp.c:21: +#include <linux/of.h>^M$ ERROR: DOS line endings #75: FILE: drivers/media/platform/mx2_emmaprp.c:1009: +static const struct of_device_id __maybe_unused emmaprp_dt_ids[] = {^M$ ERROR: DOS line endings #76: FILE: drivers/media/platform/mx2_emmaprp.c:1010: +^I{ .compatible = "fsl,imx21-emmaprp", },^M$ WARNING: DT compatible string "fsl,imx21-emmaprp" appears un-documented -- check ./Documentation/devicetree/bindings/ #76: FILE: drivers/media/platform/mx2_emmaprp.c:1010: + { .compatible = "fsl,imx21-emmaprp", }, ERROR: DOS line endings #77: FILE: drivers/media/platform/mx2_emmaprp.c:1011: +^I{ }^M$ ERROR: DOS line endings #78: FILE: drivers/media/platform/mx2_emmaprp.c:1012: +};^M$ ERROR: DOS line endings #79: FILE: drivers/media/platform/mx2_emmaprp.c:1013: +MODULE_DEVICE_TABLE(of, emmaprp_dt_ids);^M$ ERROR: DOS line endings #80: FILE: drivers/media/platform/mx2_emmaprp.c:1014: +^M$ ERROR: DOS line endings #87: FILE: drivers/media/platform/mx2_emmaprp.c:1021: +^I^I.of_match_table = of_match_ptr(emmaprp_dt_ids),^M$ total: 8 errors, 3 warnings, 26 lines checked [PATCH 1_2] media: mx2-emmaprp: Add devicetree support.eml has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. With these fixed feel free to add: Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com> -- Thanks, Sylwester ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] media: mx2-emmaprp: Add devicetree support 2014-05-28 9:46 ` Sylwester Nawrocki @ 2014-05-28 10:02 ` Alexander Shiyan 2014-05-28 10:20 ` Sylwester Nawrocki 0 siblings, 1 reply; 4+ messages in thread From: Alexander Shiyan @ 2014-05-28 10:02 UTC (permalink / raw) To: Sylwester Nawrocki Cc: linux-media, Mauro Carvalho Chehab, Shawn Guo, Sascha Hauer Wed, 28 May 2014 11:46:38 +0200 от Sylwester Nawrocki <s.nawrocki@samsung.com>: > On 27/05/14 09:47, Alexander Shiyan wrote: > > This patch adds devicetree support for the Freescale enhanced Multimedia > > Accelerator (eMMA) video Pre-processor (PrP). > > > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru> > > --- ... > Could you also fix the remaining checkpatch warnings: > > > WARNING: Use a single space after To: > #35: > To: linux-media@vger.kernel.org > > WARNING: Use a single space after Cc: > #36: > Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>, > > ERROR: DOS line endings > #67: FILE: drivers/media/platform/mx2_emmaprp.c:21: > +#include <linux/of.h>^M$ ... > [PATCH 1_2] media: mx2-emmaprp: Add devicetree support.eml has style problems, please review. ...support.eml ? All of these warnings is a result of email export. --- ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] media: mx2-emmaprp: Add devicetree support 2014-05-28 10:02 ` Alexander Shiyan @ 2014-05-28 10:20 ` Sylwester Nawrocki 0 siblings, 0 replies; 4+ messages in thread From: Sylwester Nawrocki @ 2014-05-28 10:20 UTC (permalink / raw) To: Alexander Shiyan Cc: linux-media, Mauro Carvalho Chehab, Shawn Guo, Sascha Hauer On 28/05/14 12:02, Alexander Shiyan wrote: > Wed, 28 May 2014 11:46:38 +0200 от Sylwester Nawrocki <s.nawrocki@samsung.com>: >> On 27/05/14 09:47, Alexander Shiyan wrote: >>> This patch adds devicetree support for the Freescale enhanced Multimedia >>> Accelerator (eMMA) video Pre-processor (PrP). >>> >>> Signed-off-by: Alexander Shiyan <shc_work@mail.ru> > ... > >> Could you also fix the remaining checkpatch warnings: >> >> >> WARNING: Use a single space after To: >> #35: >> To: linux-media@vger.kernel.org >> >> WARNING: Use a single space after Cc: >> #36: >> Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>, >> >> ERROR: DOS line endings >> #67: FILE: drivers/media/platform/mx2_emmaprp.c:21: >> +#include <linux/of.h>^M$ > ... >> [PATCH 1_2] media: mx2-emmaprp: Add devicetree support.eml has style problems, please review. > > ...support.eml ? > > All of these warnings is a result of email export. Indeed, sorry about that, should have used my usual script to check it. This patch is fine then. -- Thanks, Sylwester ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-05-28 10:21 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-05-27 7:47 [PATCH 1/2] media: mx2-emmaprp: Add devicetree support Alexander Shiyan 2014-05-28 9:46 ` Sylwester Nawrocki 2014-05-28 10:02 ` Alexander Shiyan 2014-05-28 10:20 ` Sylwester Nawrocki
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.