From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Peter De Schrijver
<pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v5 0/5] efuse driver for Tegra
Date: Thu, 29 May 2014 13:01:27 -0600 [thread overview]
Message-ID: <53878407.3050409@wwwdotorg.org> (raw)
In-Reply-To: <1401281677-32110-1-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On 05/28/2014 06:54 AM, Peter De Schrijver wrote:
> This driver allows userspace to read the raw efuse data. Its userspace
> interface is modelled after the sunxi_sid driver which provides similar
> functionality for some Allwinner SoCs. It has been tested on
> Tegra20 (ventana), Tegra30 (beaverboard), Tegra114 (dalmore) and
> Tegra124 (jetson TK1).
> Changes since v4:
>
> * Provide fallback to hardcoded 0x70000800 in case the apbmisc DT node is
> missing. This is exactly what the current code does and prevents a system
> crash in that case due to an invalid memory access by tegra_read_chipid()
Wouldn't it be better to simply return an error?
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 0/5] efuse driver for Tegra
Date: Thu, 29 May 2014 13:01:27 -0600 [thread overview]
Message-ID: <53878407.3050409@wwwdotorg.org> (raw)
In-Reply-To: <1401281677-32110-1-git-send-email-pdeschrijver@nvidia.com>
On 05/28/2014 06:54 AM, Peter De Schrijver wrote:
> This driver allows userspace to read the raw efuse data. Its userspace
> interface is modelled after the sunxi_sid driver which provides similar
> functionality for some Allwinner SoCs. It has been tested on
> Tegra20 (ventana), Tegra30 (beaverboard), Tegra114 (dalmore) and
> Tegra124 (jetson TK1).
> Changes since v4:
>
> * Provide fallback to hardcoded 0x70000800 in case the apbmisc DT node is
> missing. This is exactly what the current code does and prevents a system
> crash in that case due to an invalid memory access by tegra_read_chipid()
Wouldn't it be better to simply return an error?
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: Russell King <linux@arm.linux.org.uk>,
Thierry Reding <thierry.reding@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Walleij <linus.walleij@linaro.org>,
Wolfram Sang <wsa@the-dreams.de>,
linux-arm-kernel@lists.infradead.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/5] efuse driver for Tegra
Date: Thu, 29 May 2014 13:01:27 -0600 [thread overview]
Message-ID: <53878407.3050409@wwwdotorg.org> (raw)
In-Reply-To: <1401281677-32110-1-git-send-email-pdeschrijver@nvidia.com>
On 05/28/2014 06:54 AM, Peter De Schrijver wrote:
> This driver allows userspace to read the raw efuse data. Its userspace
> interface is modelled after the sunxi_sid driver which provides similar
> functionality for some Allwinner SoCs. It has been tested on
> Tegra20 (ventana), Tegra30 (beaverboard), Tegra114 (dalmore) and
> Tegra124 (jetson TK1).
> Changes since v4:
>
> * Provide fallback to hardcoded 0x70000800 in case the apbmisc DT node is
> missing. This is exactly what the current code does and prevents a system
> crash in that case due to an invalid memory access by tegra_read_chipid()
Wouldn't it be better to simply return an error?
next prev parent reply other threads:[~2014-05-29 19:01 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 12:54 [PATCH v5 0/5] efuse driver for Tegra Peter De Schrijver
2014-05-28 12:54 ` Peter De Schrijver
2014-05-28 12:54 ` Peter De Schrijver
2014-05-28 12:54 ` [PATCH v5 1/5] ARM: tegra: export apb dma readl/writel Peter De Schrijver
2014-05-28 12:54 ` Peter De Schrijver
2014-05-28 12:54 ` Peter De Schrijver
2014-05-28 12:54 ` [PATCH v5 2/5] ARM: tegra: move fuse exports to tegra-soc.h Peter De Schrijver
2014-05-28 12:54 ` Peter De Schrijver
2014-05-28 12:54 ` Peter De Schrijver
[not found] ` <1401281677-32110-3-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-05-29 19:01 ` Stephen Warren
2014-05-29 19:01 ` Stephen Warren
2014-05-29 19:01 ` Stephen Warren
2014-05-28 12:54 ` [PATCH v5 3/5] misc: fuse: Add efuse driver for Tegra Peter De Schrijver
2014-05-28 12:54 ` Peter De Schrijver
2014-05-28 12:54 ` Peter De Schrijver
2014-05-29 19:04 ` Stephen Warren
2014-05-29 19:04 ` Stephen Warren
2014-05-30 11:36 ` Peter De Schrijver
2014-05-30 11:36 ` Peter De Schrijver
2014-05-30 16:12 ` Stephen Warren
2014-05-30 16:12 ` Stephen Warren
2014-05-28 12:54 ` [PATCH v5 4/5] ARM: tegra: Add efuse and apbmisc bindings Peter De Schrijver
2014-05-28 12:54 ` Peter De Schrijver
2014-05-28 12:54 ` Peter De Schrijver
[not found] ` <1401281677-32110-5-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-05-29 19:13 ` Stephen Warren
2014-05-29 19:13 ` Stephen Warren
2014-05-29 19:13 ` Stephen Warren
2014-05-28 12:54 ` [PATCH v5 5/5] ARM: tegra: build new fuse driver in drivers/misc Peter De Schrijver
2014-05-28 12:54 ` Peter De Schrijver
2014-05-28 12:54 ` Peter De Schrijver
[not found] ` <1401281677-32110-6-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-05-29 19:14 ` Stephen Warren
2014-05-29 19:14 ` Stephen Warren
2014-05-29 19:14 ` Stephen Warren
[not found] ` <1401281677-32110-1-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-05-28 13:16 ` [PATCH v5 0/5] efuse driver for Tegra Andrew Morton
2014-05-28 13:16 ` Andrew Morton
2014-05-28 13:16 ` Andrew Morton
[not found] ` <20140528061645.252c2fbc.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2014-05-29 19:22 ` Stephen Warren
2014-05-29 19:22 ` Stephen Warren
2014-05-29 19:22 ` Stephen Warren
2014-05-29 19:01 ` Stephen Warren [this message]
2014-05-29 19:01 ` Stephen Warren
2014-05-29 19:01 ` Stephen Warren
[not found] ` <53878407.3050409-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-05-30 8:23 ` Peter De Schrijver
2014-05-30 8:23 ` Peter De Schrijver
2014-05-30 8:23 ` Peter De Schrijver
[not found] ` <20140530082356.GP5961-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2014-05-30 16:17 ` Stephen Warren
2014-05-30 16:17 ` Stephen Warren
2014-05-30 16:17 ` Stephen Warren
2014-06-02 8:27 ` Peter De Schrijver
2014-06-02 8:27 ` Peter De Schrijver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53878407.3050409@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.