From: Ben Dooks <ben.dooks@codethink.co.uk>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 7/7] ARM: shmobile: r8a7791 dtsi: Enable DMA for QSPI
Date: Mon, 02 Jun 2014 13:53:01 +0000 [thread overview]
Message-ID: <538C81BD.5090502@codethink.co.uk> (raw)
In-Reply-To: <1401716531-29794-8-git-send-email-geert+renesas@glider.be>
On 02/06/14 14:42, Geert Uytterhoeven wrote:
> Add a DMA property to the QSPI node
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:
> - QSPI needs to use 8-bit accesses for DMA, not 32-bit,
> - Reorder: TX first, RX second.
>
> arch/arm/boot/dts/r8a7791.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi
> index 37685ef32ea0..6c285ffc46cb 100644
> --- a/arch/arm/boot/dts/r8a7791.dtsi
> +++ b/arch/arm/boot/dts/r8a7791.dtsi
> @@ -917,6 +917,9 @@
> reg = <0 0xe6b10000 0 0x2c>;
> interrupts = <0 184 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&mstp9_clks R8A7791_CLK_QSPI_MOD>;
> + dmas = <&dma0 R8A7791_DMA_QSPI_TX CHCR_TX_8BIT>,
> + <&dma0 R8A7791_DMA_QSPI_RX CHCR_RX_8BIT>;
> + dma-names = "tx", "rx";
I am hopeful that we can remove the CHCR settings, each driver
should configure the width when configuring the slave. V2 of
the patches will reflect this.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
WARNING: multiple messages have this Message-ID (diff)
From: ben.dooks@codethink.co.uk (Ben Dooks)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 7/7] ARM: shmobile: r8a7791 dtsi: Enable DMA for QSPI
Date: Mon, 02 Jun 2014 14:53:01 +0100 [thread overview]
Message-ID: <538C81BD.5090502@codethink.co.uk> (raw)
In-Reply-To: <1401716531-29794-8-git-send-email-geert+renesas@glider.be>
On 02/06/14 14:42, Geert Uytterhoeven wrote:
> Add a DMA property to the QSPI node
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:
> - QSPI needs to use 8-bit accesses for DMA, not 32-bit,
> - Reorder: TX first, RX second.
>
> arch/arm/boot/dts/r8a7791.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi
> index 37685ef32ea0..6c285ffc46cb 100644
> --- a/arch/arm/boot/dts/r8a7791.dtsi
> +++ b/arch/arm/boot/dts/r8a7791.dtsi
> @@ -917,6 +917,9 @@
> reg = <0 0xe6b10000 0 0x2c>;
> interrupts = <0 184 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&mstp9_clks R8A7791_CLK_QSPI_MOD>;
> + dmas = <&dma0 R8A7791_DMA_QSPI_TX CHCR_TX_8BIT>,
> + <&dma0 R8A7791_DMA_QSPI_RX CHCR_RX_8BIT>;
> + dma-names = "tx", "rx";
I am hopeful that we can remove the CHCR settings, each driver
should configure the width when configuring the slave. V2 of
the patches will reflect this.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
WARNING: multiple messages have this Message-ID (diff)
From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-sh@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, dmaengine@vger.kernel.org
Subject: Re: [PATCH v2 7/7] ARM: shmobile: r8a7791 dtsi: Enable DMA for QSPI
Date: Mon, 02 Jun 2014 14:53:01 +0100 [thread overview]
Message-ID: <538C81BD.5090502@codethink.co.uk> (raw)
In-Reply-To: <1401716531-29794-8-git-send-email-geert+renesas@glider.be>
On 02/06/14 14:42, Geert Uytterhoeven wrote:
> Add a DMA property to the QSPI node
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:
> - QSPI needs to use 8-bit accesses for DMA, not 32-bit,
> - Reorder: TX first, RX second.
>
> arch/arm/boot/dts/r8a7791.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi
> index 37685ef32ea0..6c285ffc46cb 100644
> --- a/arch/arm/boot/dts/r8a7791.dtsi
> +++ b/arch/arm/boot/dts/r8a7791.dtsi
> @@ -917,6 +917,9 @@
> reg = <0 0xe6b10000 0 0x2c>;
> interrupts = <0 184 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&mstp9_clks R8A7791_CLK_QSPI_MOD>;
> + dmas = <&dma0 R8A7791_DMA_QSPI_TX CHCR_TX_8BIT>,
> + <&dma0 R8A7791_DMA_QSPI_RX CHCR_RX_8BIT>;
> + dma-names = "tx", "rx";
I am hopeful that we can remove the CHCR settings, each driver
should configure the width when configuring the slave. V2 of
the patches will reflect this.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
next prev parent reply other threads:[~2014-06-02 13:53 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 13:42 [PATCH v2 0/7] ARM: shmobile: koelsch reference: Enable DMA for QSPI Geert Uytterhoeven
2014-06-02 13:42 ` Geert Uytterhoeven
2014-06-02 13:42 ` Geert Uytterhoeven
2014-06-02 13:42 ` [PATCH v2 1/7] DMA: shdma: Add r8a7791 support Geert Uytterhoeven
2014-06-02 13:42 ` Geert Uytterhoeven
2014-06-02 13:42 ` Geert Uytterhoeven
2014-06-04 11:29 ` Laurent Pinchart
2014-06-04 11:29 ` Laurent Pinchart
2014-06-04 11:29 ` Laurent Pinchart
2014-06-04 11:39 ` Geert Uytterhoeven
2014-06-04 11:39 ` Geert Uytterhoeven
2014-06-04 11:39 ` Geert Uytterhoeven
2014-06-02 13:42 ` [PATCH v2 2/7] DMA: shdma: Spelling s/controll/control/ Geert Uytterhoeven
2014-06-02 13:42 ` Geert Uytterhoeven
2014-06-02 13:42 ` Geert Uytterhoeven
2014-06-02 13:50 ` Ben Dooks
2014-06-02 13:50 ` Ben Dooks
2014-06-02 13:50 ` Ben Dooks
2014-06-04 11:25 ` Laurent Pinchart
2014-06-04 11:25 ` Laurent Pinchart
2014-06-04 11:25 ` Laurent Pinchart
2014-06-02 13:42 ` [PATCH v2 3/7] ARM: shmobile: r8a7791 dtsi: add SYS-DMAC clocks Geert Uytterhoeven
2014-06-02 13:42 ` Geert Uytterhoeven
2014-06-02 13:42 ` Geert Uytterhoeven
2014-06-04 11:24 ` Laurent Pinchart
2014-06-04 11:24 ` Laurent Pinchart
2014-06-04 11:24 ` Laurent Pinchart
2014-06-04 23:29 ` Simon Horman
2014-06-04 23:29 ` Simon Horman
2014-06-04 23:29 ` Simon Horman
2014-06-02 13:42 ` [PATCH v2 4/7] ARM: shmobile: r8a7791: Add SYS-DMAC channel definitions for bindings Geert Uytterhoeven
2014-06-02 13:42 ` Geert Uytterhoeven
2014-06-02 13:42 ` Geert Uytterhoeven
2014-06-02 13:52 ` Ben Dooks
2014-06-02 13:52 ` Ben Dooks
2014-06-02 13:52 ` Ben Dooks
2014-06-03 7:53 ` Geert Uytterhoeven
2014-06-03 7:53 ` Geert Uytterhoeven
2014-06-03 7:53 ` Geert Uytterhoeven
2014-06-04 11:30 ` Laurent Pinchart
2014-06-04 11:30 ` Laurent Pinchart
2014-06-04 11:30 ` Laurent Pinchart
2014-06-04 11:45 ` Ben Dooks
2014-06-04 11:45 ` Ben Dooks
2014-06-04 11:45 ` Ben Dooks
2014-06-04 11:53 ` Laurent Pinchart
2014-06-04 11:53 ` Laurent Pinchart
2014-06-04 11:53 ` Laurent Pinchart
2014-06-11 11:05 ` [PATCH v2 4/7] ARM: shmobile: r8a7791: Add PCIEC clock device tree node Phil Edworthy
2014-06-12 15:34 ` Laurent Pinchart
2014-06-02 13:42 ` [PATCH v2 5/7] ARM: shmobile: r8a7791 dtsi: Add SYS-DMAC0 and SYS-DMAC1 nodes Geert Uytterhoeven
2014-06-02 13:42 ` Geert Uytterhoeven
2014-06-02 13:42 ` Geert Uytterhoeven
2014-06-04 12:25 ` Laurent Pinchart
2014-06-04 12:25 ` Laurent Pinchart
2014-06-04 12:25 ` Laurent Pinchart
2014-06-05 0:17 ` Kuninori Morimoto
2014-06-05 0:17 ` Kuninori Morimoto
2014-06-05 0:17 ` Kuninori Morimoto
2014-06-05 12:37 ` Laurent Pinchart
2014-06-05 12:37 ` Laurent Pinchart
2014-06-05 12:37 ` Laurent Pinchart
2014-06-06 11:22 ` Ben Dooks
2014-06-06 11:22 ` Ben Dooks
2014-06-06 11:22 ` Ben Dooks
2014-06-02 13:42 ` [PATCH v2 6/7] ARM: shmobile: koelsch dts: Enable sysdma0 and sysdma1 Geert Uytterhoeven
2014-06-02 13:42 ` Geert Uytterhoeven
2014-06-02 13:42 ` Geert Uytterhoeven
2014-06-02 13:42 ` [PATCH v2 7/7] ARM: shmobile: r8a7791 dtsi: Enable DMA for QSPI Geert Uytterhoeven
2014-06-02 13:42 ` Geert Uytterhoeven
2014-06-02 13:42 ` Geert Uytterhoeven
2014-06-02 13:53 ` Ben Dooks [this message]
2014-06-02 13:53 ` Ben Dooks
2014-06-02 13:53 ` Ben Dooks
2014-06-02 13:58 ` [PATCH v2 0/7] ARM: shmobile: koelsch reference: " Ben Dooks
2014-06-02 13:58 ` Ben Dooks
2014-06-02 13:58 ` Ben Dooks
2014-06-03 4:36 ` Khiem Nguyen
2014-06-03 4:36 ` Khiem Nguyen
2014-06-03 4:36 ` Khiem Nguyen
2014-06-03 7:05 ` Geert Uytterhoeven
2014-06-03 7:05 ` Geert Uytterhoeven
2014-06-03 7:05 ` Geert Uytterhoeven
2014-06-03 23:29 ` Simon Horman
2014-06-03 23:29 ` Simon Horman
2014-06-03 23:29 ` Simon Horman
2014-06-04 0:18 ` Khiem Nguyen
2014-06-04 0:18 ` Khiem Nguyen
2014-06-04 0:18 ` Khiem Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538C81BD.5090502@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.