From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Paul Durrant <paul.durrant@citrix.com>,
Keir Fraser <keir@xen.org>, Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] x86/hvm: Correct hvm_ioreq_server_alloc_rangesets() failure path
Date: Wed, 4 Jun 2014 13:25:17 +0100 [thread overview]
Message-ID: <538F102D.2080304@citrix.com> (raw)
In-Reply-To: <538F2BA20200007800017BF3@mail.emea.novell.com>
On 04/06/14 13:22, Jan Beulich wrote:
>
>> @@ -861,24 +873,11 @@ static int hvm_ioreq_server_alloc_rangesets(struct hvm_ioreq_server *s,
>> return 0;
>>
>> fail:
>> - while ( --i >= 0 )
> ... the one line equivalent fix would have been to use while ( i-- ).
>
> Jan
I was considering the possible case where alloc/free_rangesets() gain
further moving parts, although I guess is probably unlikely.
~Andrew
prev parent reply other threads:[~2014-06-04 12:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 11:00 [PATCH] x86/hvm: Correct hvm_ioreq_server_alloc_rangesets() failure path Andrew Cooper
2014-06-04 11:30 ` Paul Durrant
2014-06-04 12:22 ` Jan Beulich
2014-06-04 12:25 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538F102D.2080304@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=paul.durrant@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.