From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: "Alexander Graf" <agraf@suse.de>,
qemu-devel@nongnu.org, "Borislav Petkov" <bp@alien8.de>,
"Gabriel L. Somlo" <gsomlo@gmail.com>,
kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Michael Mueller" <mimu@linux.vnet.ibm.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Jason J. Herne" <jjherne@linux.vnet.ibm.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [RFC 0/2] GET_EMULATED_CPUID support with "allow-emulation" option
Date: Thu, 05 Jun 2014 19:39:42 +0200 [thread overview]
Message-ID: <5390AB5E.5070702@redhat.com> (raw)
In-Reply-To: <20140605171908.GO17594@otherpad.lan.raisama.net>
Il 05/06/2014 19:19, Eduardo Habkost ha scritto:
> On Thu, Jun 05, 2014 at 06:57:57PM +0200, Paolo Bonzini wrote:
>> Il 05/06/2014 18:54, Alexander Graf ha scritto:
>>>>
>>>> What about:
>>>>
>>>> - letting "-cpu foo,+emulatedfeature" just work
>>>>
>>>> - adding emulated=yes that blindly enables all emulated features
>>>>
>>>> - making "-cpu ...,check" prints a warning for emulated features
>>>> unless emulated=yes
>>>
>>> How about we remove the emulated=yes from this list? Then I'm happy :).
>>
>> So:
>>
>> - "-cpu foo" doesn't enable any emulated feature
>
> What if "foo" already has movbe in the CPU model definition?
It will be disabled.
>>
>> - "-cpu foo,+movbe" does
>
> What if I want movbe enabled if and only if it is _not_ emulated?
Pick a CPU model that has it.
> The whole point here is to never ever ever enable an emulated feature
> unless it was explicitly what the user wanted.
"+foo" could be enough.
> "nice and descriptive message" needs to be better specified. Messages on
> stderr are useless for management software.
I'm not sure this feature is for management software users.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: "Michael Mueller" <mimu@linux.vnet.ibm.com>,
kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
"Alexander Graf" <agraf@suse.de>,
qemu-devel@nongnu.org,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Gabriel L. Somlo" <gsomlo@gmail.com>,
"Borislav Petkov" <bp@alien8.de>,
"Jason J. Herne" <jjherne@linux.vnet.ibm.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [RFC 0/2] GET_EMULATED_CPUID support with "allow-emulation" option
Date: Thu, 05 Jun 2014 19:39:42 +0200 [thread overview]
Message-ID: <5390AB5E.5070702@redhat.com> (raw)
In-Reply-To: <20140605171908.GO17594@otherpad.lan.raisama.net>
Il 05/06/2014 19:19, Eduardo Habkost ha scritto:
> On Thu, Jun 05, 2014 at 06:57:57PM +0200, Paolo Bonzini wrote:
>> Il 05/06/2014 18:54, Alexander Graf ha scritto:
>>>>
>>>> What about:
>>>>
>>>> - letting "-cpu foo,+emulatedfeature" just work
>>>>
>>>> - adding emulated=yes that blindly enables all emulated features
>>>>
>>>> - making "-cpu ...,check" prints a warning for emulated features
>>>> unless emulated=yes
>>>
>>> How about we remove the emulated=yes from this list? Then I'm happy :).
>>
>> So:
>>
>> - "-cpu foo" doesn't enable any emulated feature
>
> What if "foo" already has movbe in the CPU model definition?
It will be disabled.
>>
>> - "-cpu foo,+movbe" does
>
> What if I want movbe enabled if and only if it is _not_ emulated?
Pick a CPU model that has it.
> The whole point here is to never ever ever enable an emulated feature
> unless it was explicitly what the user wanted.
"+foo" could be enough.
> "nice and descriptive message" needs to be better specified. Messages on
> stderr are useless for management software.
I'm not sure this feature is for management software users.
Paolo
next prev parent reply other threads:[~2014-06-05 17:39 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 16:12 [RFC 0/2] GET_EMULATED_CPUID support with "allow-emulation" option Eduardo Habkost
2014-06-05 16:12 ` [Qemu-devel] " Eduardo Habkost
2014-06-05 16:12 ` [Qemu-devel] [RFC 1/2] kvm: Implement kvm_arch_get_emulated_cpuid() Eduardo Habkost
2014-06-05 16:12 ` [Qemu-devel] [RFC 2/2] target-i386: Add "allow-emulation" X86CPU property Eduardo Habkost
2014-06-05 19:57 ` [RFC 2/2 v2] target-i386: Add "x-allow-emulation" " Eduardo Habkost
2014-06-05 19:57 ` [Qemu-devel] " Eduardo Habkost
2014-06-05 22:27 ` Alexander Graf
2014-06-05 22:27 ` [Qemu-devel] " Alexander Graf
2014-06-05 16:24 ` [RFC 0/2] GET_EMULATED_CPUID support with "allow-emulation" option Alexander Graf
2014-06-05 16:24 ` [Qemu-devel] " Alexander Graf
2014-06-05 16:26 ` Paolo Bonzini
2014-06-05 16:26 ` [Qemu-devel] " Paolo Bonzini
2014-06-05 16:40 ` Alexander Graf
2014-06-05 16:40 ` [Qemu-devel] " Alexander Graf
2014-06-05 16:44 ` Paolo Bonzini
2014-06-05 16:44 ` [Qemu-devel] " Paolo Bonzini
2014-06-05 16:45 ` Alexander Graf
2014-06-05 16:45 ` [Qemu-devel] " Alexander Graf
2014-06-05 16:52 ` Paolo Bonzini
2014-06-05 16:52 ` [Qemu-devel] " Paolo Bonzini
2014-06-05 16:54 ` Alexander Graf
2014-06-05 16:54 ` [Qemu-devel] " Alexander Graf
2014-06-05 16:57 ` Paolo Bonzini
2014-06-05 16:57 ` [Qemu-devel] " Paolo Bonzini
2014-06-05 17:19 ` Eduardo Habkost
2014-06-05 17:19 ` [Qemu-devel] " Eduardo Habkost
2014-06-05 17:39 ` Paolo Bonzini [this message]
2014-06-05 17:39 ` Paolo Bonzini
2014-06-05 18:02 ` Eduardo Habkost
2014-06-05 18:02 ` [Qemu-devel] " Eduardo Habkost
2014-06-05 19:12 ` Eduardo Habkost
2014-06-05 19:12 ` [Qemu-devel] " Eduardo Habkost
2014-06-05 19:24 ` Borislav Petkov
2014-06-05 19:24 ` Borislav Petkov
2014-06-05 19:45 ` Eric Blake
2014-06-05 19:45 ` Eric Blake
2014-06-05 19:52 ` Eduardo Habkost
2014-06-05 19:52 ` Eduardo Habkost
2014-06-05 16:58 ` Alexander Graf
2014-06-05 16:58 ` [Qemu-devel] " Alexander Graf
2014-06-05 17:48 ` Eduardo Habkost
2014-06-05 17:48 ` [Qemu-devel] " Eduardo Habkost
2014-06-05 22:24 ` Alexander Graf
2014-06-05 22:24 ` [Qemu-devel] " Alexander Graf
2014-06-06 1:21 ` Borislav Petkov
2014-06-06 1:21 ` [Qemu-devel] " Borislav Petkov
2014-06-06 2:37 ` Eduardo Habkost
2014-06-06 2:37 ` [Qemu-devel] " Eduardo Habkost
2014-06-06 11:16 ` Alexander Graf
2014-06-06 11:16 ` [Qemu-devel] " Alexander Graf
2014-06-06 18:38 ` Eduardo Habkost
2014-06-06 18:38 ` [Qemu-devel] " Eduardo Habkost
2014-06-05 17:17 ` Eduardo Habkost
2014-06-05 17:17 ` [Qemu-devel] " Eduardo Habkost
2014-06-05 17:38 ` Paolo Bonzini
2014-06-05 17:38 ` [Qemu-devel] " Paolo Bonzini
2014-06-05 17:52 ` Eduardo Habkost
2014-06-05 17:52 ` [Qemu-devel] " Eduardo Habkost
2014-06-05 17:34 ` Eduardo Habkost
2014-06-05 17:34 ` [Qemu-devel] " Eduardo Habkost
2014-06-06 13:29 ` gleb
2014-06-06 13:29 ` [Qemu-devel] " gleb
2014-06-05 18:11 ` Eduardo Habkost
2014-06-05 18:11 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5390AB5E.5070702@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=bp@alien8.de \
--cc=ehabkost@redhat.com \
--cc=gsomlo@gmail.com \
--cc=jjherne@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=mimu@linux.vnet.ibm.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.