All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Peter De Schrijver
	<pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	Thierry Reding
	<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Andrew Morton
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	Linus Walleij
	<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v7 1/5] ARM: tegra: export apb dma readl/writel
Date: Thu, 05 Jun 2014 11:57:28 -0600	[thread overview]
Message-ID: <5390AF88.9050007@wwwdotorg.org> (raw)
In-Reply-To: <1401973754-19701-2-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

On 06/05/2014 07:09 AM, Peter De Schrijver wrote:
> Export APB DMA readl and writel. These are needed because we can't access
> the fuses directly on Tegra20 without potentially causing a system hang.
> Also have the APB DMA readl and writel return an error in case of a read
> failure instead of just returning zero or ignore write failures.

> diff --git a/include/linux/tegra-soc.h b/include/linux/tegra-soc.h

> +int tegra_apb_readl_using_dma(unsigned long offset, u32 *value);
> +int tegra_apb_writel_using_dma(u32 value, unsigned long offset);

Hmm. I wonder why we're exporting those low-level internal functions
rather than the higher-level tegra_apb_readl()/writel() wrappers that
"clients" are supposed to be using.

WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 1/5] ARM: tegra: export apb dma readl/writel
Date: Thu, 05 Jun 2014 11:57:28 -0600	[thread overview]
Message-ID: <5390AF88.9050007@wwwdotorg.org> (raw)
In-Reply-To: <1401973754-19701-2-git-send-email-pdeschrijver@nvidia.com>

On 06/05/2014 07:09 AM, Peter De Schrijver wrote:
> Export APB DMA readl and writel. These are needed because we can't access
> the fuses directly on Tegra20 without potentially causing a system hang.
> Also have the APB DMA readl and writel return an error in case of a read
> failure instead of just returning zero or ignore write failures.

> diff --git a/include/linux/tegra-soc.h b/include/linux/tegra-soc.h

> +int tegra_apb_readl_using_dma(unsigned long offset, u32 *value);
> +int tegra_apb_writel_using_dma(u32 value, unsigned long offset);

Hmm. I wonder why we're exporting those low-level internal functions
rather than the higher-level tegra_apb_readl()/writel() wrappers that
"clients" are supposed to be using.

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: Russell King <linux@arm.linux.org.uk>,
	Thierry Reding <thierry.reding@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Wolfram Sang <wsa@the-dreams.de>,
	linux-arm-kernel@lists.infradead.org,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 1/5] ARM: tegra: export apb dma readl/writel
Date: Thu, 05 Jun 2014 11:57:28 -0600	[thread overview]
Message-ID: <5390AF88.9050007@wwwdotorg.org> (raw)
In-Reply-To: <1401973754-19701-2-git-send-email-pdeschrijver@nvidia.com>

On 06/05/2014 07:09 AM, Peter De Schrijver wrote:
> Export APB DMA readl and writel. These are needed because we can't access
> the fuses directly on Tegra20 without potentially causing a system hang.
> Also have the APB DMA readl and writel return an error in case of a read
> failure instead of just returning zero or ignore write failures.

> diff --git a/include/linux/tegra-soc.h b/include/linux/tegra-soc.h

> +int tegra_apb_readl_using_dma(unsigned long offset, u32 *value);
> +int tegra_apb_writel_using_dma(u32 value, unsigned long offset);

Hmm. I wonder why we're exporting those low-level internal functions
rather than the higher-level tegra_apb_readl()/writel() wrappers that
"clients" are supposed to be using.

  parent reply	other threads:[~2014-06-05 17:57 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-05 13:09 [PATCH v7 0/5] efuse driver for Tegra Peter De Schrijver
2014-06-05 13:09 ` Peter De Schrijver
2014-06-05 13:09 ` Peter De Schrijver
2014-06-05 13:09 ` [PATCH v7 1/5] ARM: tegra: export apb dma readl/writel Peter De Schrijver
2014-06-05 13:09   ` Peter De Schrijver
2014-06-05 13:09   ` Peter De Schrijver
     [not found]   ` <1401973754-19701-2-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-06-05 17:57     ` Stephen Warren [this message]
2014-06-05 17:57       ` Stephen Warren
2014-06-05 17:57       ` Stephen Warren
     [not found]       ` <5390AF88.9050007-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-06-05 18:06         ` Stephen Warren
2014-06-05 18:06           ` Stephen Warren
2014-06-05 18:06           ` Stephen Warren
2014-06-05 13:09 ` [PATCH v7 2/5] ARM: tegra: move fuse exports to tegra-soc.h Peter De Schrijver
2014-06-05 13:09   ` Peter De Schrijver
2014-06-05 13:09   ` Peter De Schrijver
     [not found] ` <1401973754-19701-1-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-06-05 13:09   ` [PATCH v7 3/5] misc: fuse: Add efuse driver for Tegra Peter De Schrijver
2014-06-05 13:09     ` Peter De Schrijver
2014-06-05 13:09     ` Peter De Schrijver
     [not found]     ` <1401973754-19701-4-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-06-05 17:01       ` Tuomas Tynkkynen
2014-06-05 17:01         ` Tuomas Tynkkynen
2014-06-05 17:01         ` Tuomas Tynkkynen
2014-06-05 18:09       ` Stephen Warren
2014-06-05 18:09         ` Stephen Warren
2014-06-05 18:09         ` Stephen Warren
2014-06-05 18:37       ` Stephen Warren
2014-06-05 18:37         ` Stephen Warren
2014-06-05 18:37         ` Stephen Warren
     [not found]         ` <5390B8E6.1050600-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-06-05 22:09           ` Peter De Schrijver
2014-06-05 22:09             ` Peter De Schrijver
2014-06-05 22:09             ` Peter De Schrijver
     [not found]             ` <20140605220946.GP5961-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2014-06-05 22:54               ` Stephen Warren
2014-06-05 22:54                 ` Stephen Warren
2014-06-05 22:54                 ` Stephen Warren
     [not found]                 ` <5390F508.8080104-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-06-06  7:35                   ` Peter De Schrijver
2014-06-06  7:35                     ` Peter De Schrijver
2014-06-06  7:35                     ` Peter De Schrijver
     [not found]                     ` <20140606073507.GS5961-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2014-06-09 18:29                       ` Stephen Warren
2014-06-09 18:29                         ` Stephen Warren
2014-06-09 18:29                         ` Stephen Warren
2014-06-11 12:47     ` Mikko Perttunen
2014-06-11 12:47       ` Mikko Perttunen
     [not found]       ` <53984FE3.6010509-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-06-11 15:25         ` Peter De Schrijver
2014-06-11 15:25           ` Peter De Schrijver
2014-06-11 15:25           ` Peter De Schrijver
2014-06-11 15:58           ` Stephen Warren
2014-06-11 15:58             ` Stephen Warren
2014-06-11 16:19             ` Peter De Schrijver
2014-06-11 16:19               ` Peter De Schrijver
     [not found]               ` <20140611161901.GI5961-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2014-06-11 16:29                 ` Stephen Warren
2014-06-11 16:29                   ` Stephen Warren
2014-06-11 16:29                   ` Stephen Warren
2014-06-05 13:09 ` [PATCH v7 4/5] ARM: tegra: Add efuse and apbmisc bindings Peter De Schrijver
2014-06-05 13:09   ` Peter De Schrijver
2014-06-05 13:09   ` Peter De Schrijver
2014-06-05 18:41   ` Stephen Warren
2014-06-05 18:41     ` Stephen Warren
     [not found]     ` <5390B9F3.8030108-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-06-05 22:13       ` Peter De Schrijver
2014-06-05 22:13         ` Peter De Schrijver
2014-06-05 22:13         ` Peter De Schrijver
     [not found]         ` <20140605221301.GQ5961-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2014-06-05 22:55           ` Stephen Warren
2014-06-05 22:55             ` Stephen Warren
2014-06-05 22:55             ` Stephen Warren
     [not found]             ` <5390F55A.8090207-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-06-06  7:35               ` Peter De Schrijver
2014-06-06  7:35                 ` Peter De Schrijver
2014-06-06  7:35                 ` Peter De Schrijver
2014-06-05 13:09 ` [PATCH v7 5/5] ARM: tegra: build new fuse driver in drivers/misc Peter De Schrijver
2014-06-05 13:09   ` Peter De Schrijver
2014-06-05 13:09   ` Peter De Schrijver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5390AF88.9050007@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.