All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mikko Perttunen <mperttunen@nvidia.com>
To: Peter De Schrijver <pdeschrijver@nvidia.com>
Cc: Russell King <linux@arm.linux.org.uk>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Wolfram Sang <wsa@the-dreams.de>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 3/5] misc: fuse: Add efuse driver for Tegra
Date: Wed, 11 Jun 2014 15:47:31 +0300	[thread overview]
Message-ID: <53984FE3.6010509@nvidia.com> (raw)
In-Reply-To: <1401973754-19701-4-git-send-email-pdeschrijver@nvidia.com>

On 05/06/14 16:09, Peter De Schrijver wrote:
...
> +int tegra_fuse_readl(u32 offset, u32 *val)
> +{
> +       if (!fuse_readl)
> +               return -ENXIO;
> +
> +       *val = fuse_readl(offset);
> +
> +       return 0;
> +}
> +

-EPROBE_DEFER would be a better error value, so that drivers can work 
even if they are initially probed before the fuse driver. Of course, if 
the fuse initialization is moved into machine init then this is a non-issue.

WARNING: multiple messages have this Message-ID (diff)
From: mperttunen@nvidia.com (Mikko Perttunen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 3/5] misc: fuse: Add efuse driver for Tegra
Date: Wed, 11 Jun 2014 15:47:31 +0300	[thread overview]
Message-ID: <53984FE3.6010509@nvidia.com> (raw)
In-Reply-To: <1401973754-19701-4-git-send-email-pdeschrijver@nvidia.com>

On 05/06/14 16:09, Peter De Schrijver wrote:
...
> +int tegra_fuse_readl(u32 offset, u32 *val)
> +{
> +       if (!fuse_readl)
> +               return -ENXIO;
> +
> +       *val = fuse_readl(offset);
> +
> +       return 0;
> +}
> +

-EPROBE_DEFER would be a better error value, so that drivers can work 
even if they are initially probed before the fuse driver. Of course, if 
the fuse initialization is moved into machine init then this is a non-issue.

  parent reply	other threads:[~2014-06-11 12:47 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-05 13:09 [PATCH v7 0/5] efuse driver for Tegra Peter De Schrijver
2014-06-05 13:09 ` Peter De Schrijver
2014-06-05 13:09 ` Peter De Schrijver
2014-06-05 13:09 ` [PATCH v7 1/5] ARM: tegra: export apb dma readl/writel Peter De Schrijver
2014-06-05 13:09   ` Peter De Schrijver
2014-06-05 13:09   ` Peter De Schrijver
     [not found]   ` <1401973754-19701-2-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-06-05 17:57     ` Stephen Warren
2014-06-05 17:57       ` Stephen Warren
2014-06-05 17:57       ` Stephen Warren
     [not found]       ` <5390AF88.9050007-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-06-05 18:06         ` Stephen Warren
2014-06-05 18:06           ` Stephen Warren
2014-06-05 18:06           ` Stephen Warren
2014-06-05 13:09 ` [PATCH v7 2/5] ARM: tegra: move fuse exports to tegra-soc.h Peter De Schrijver
2014-06-05 13:09   ` Peter De Schrijver
2014-06-05 13:09   ` Peter De Schrijver
     [not found] ` <1401973754-19701-1-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-06-05 13:09   ` [PATCH v7 3/5] misc: fuse: Add efuse driver for Tegra Peter De Schrijver
2014-06-05 13:09     ` Peter De Schrijver
2014-06-05 13:09     ` Peter De Schrijver
     [not found]     ` <1401973754-19701-4-git-send-email-pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-06-05 17:01       ` Tuomas Tynkkynen
2014-06-05 17:01         ` Tuomas Tynkkynen
2014-06-05 17:01         ` Tuomas Tynkkynen
2014-06-05 18:09       ` Stephen Warren
2014-06-05 18:09         ` Stephen Warren
2014-06-05 18:09         ` Stephen Warren
2014-06-05 18:37       ` Stephen Warren
2014-06-05 18:37         ` Stephen Warren
2014-06-05 18:37         ` Stephen Warren
     [not found]         ` <5390B8E6.1050600-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-06-05 22:09           ` Peter De Schrijver
2014-06-05 22:09             ` Peter De Schrijver
2014-06-05 22:09             ` Peter De Schrijver
     [not found]             ` <20140605220946.GP5961-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2014-06-05 22:54               ` Stephen Warren
2014-06-05 22:54                 ` Stephen Warren
2014-06-05 22:54                 ` Stephen Warren
     [not found]                 ` <5390F508.8080104-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-06-06  7:35                   ` Peter De Schrijver
2014-06-06  7:35                     ` Peter De Schrijver
2014-06-06  7:35                     ` Peter De Schrijver
     [not found]                     ` <20140606073507.GS5961-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2014-06-09 18:29                       ` Stephen Warren
2014-06-09 18:29                         ` Stephen Warren
2014-06-09 18:29                         ` Stephen Warren
2014-06-11 12:47     ` Mikko Perttunen [this message]
2014-06-11 12:47       ` Mikko Perttunen
     [not found]       ` <53984FE3.6010509-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-06-11 15:25         ` Peter De Schrijver
2014-06-11 15:25           ` Peter De Schrijver
2014-06-11 15:25           ` Peter De Schrijver
2014-06-11 15:58           ` Stephen Warren
2014-06-11 15:58             ` Stephen Warren
2014-06-11 16:19             ` Peter De Schrijver
2014-06-11 16:19               ` Peter De Schrijver
     [not found]               ` <20140611161901.GI5961-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2014-06-11 16:29                 ` Stephen Warren
2014-06-11 16:29                   ` Stephen Warren
2014-06-11 16:29                   ` Stephen Warren
2014-06-05 13:09 ` [PATCH v7 4/5] ARM: tegra: Add efuse and apbmisc bindings Peter De Schrijver
2014-06-05 13:09   ` Peter De Schrijver
2014-06-05 13:09   ` Peter De Schrijver
2014-06-05 18:41   ` Stephen Warren
2014-06-05 18:41     ` Stephen Warren
     [not found]     ` <5390B9F3.8030108-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-06-05 22:13       ` Peter De Schrijver
2014-06-05 22:13         ` Peter De Schrijver
2014-06-05 22:13         ` Peter De Schrijver
     [not found]         ` <20140605221301.GQ5961-Rysk9IDjsxmJz7etNGeUX8VPkgjIgRvpAL8bYrjMMd8@public.gmane.org>
2014-06-05 22:55           ` Stephen Warren
2014-06-05 22:55             ` Stephen Warren
2014-06-05 22:55             ` Stephen Warren
     [not found]             ` <5390F55A.8090207-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-06-06  7:35               ` Peter De Schrijver
2014-06-06  7:35                 ` Peter De Schrijver
2014-06-06  7:35                 ` Peter De Schrijver
2014-06-05 13:09 ` [PATCH v7 5/5] ARM: tegra: build new fuse driver in drivers/misc Peter De Schrijver
2014-06-05 13:09   ` Peter De Schrijver
2014-06-05 13:09   ` Peter De Schrijver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53984FE3.6010509@nvidia.com \
    --to=mperttunen@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=pdeschrijver@nvidia.com \
    --cc=swarren@wwwdotorg.org \
    --cc=thierry.reding@gmail.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.