All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Kumar Gala <galak@codeaurora.org>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Russell King <linux@arm.linux.org.uk>,
	David Brown <davidb@codeaurora.org>
Subject: Re: [PATCH] ARM: qcom: select GSBI from mach kconfig
Date: Tue, 10 Jun 2014 10:31:33 -0700	[thread overview]
Message-ID: <539740F5.9030204@codeaurora.org> (raw)
In-Reply-To: <1402398980-24664-1-git-send-email-srinivas.kandagatla@linaro.org>

On 06/10/14 04:16, Srinivas Kandagatla wrote:
> This patch adds GSBI selection automatically from mach kconfig, As GSBI
> seems to be the very basic SOC specific driver and serial driver depends on it.
> I think this option should be selected via mach kconfig rather than adding
> it to any defconfig.
>
> Without this patch multi_v7_defconfig can not show up console on
> IFC6410.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>

No, we should be getting rid of selects, not adding more. Just put this
in the multi_v7_defconfig.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: qcom: select GSBI from mach kconfig
Date: Tue, 10 Jun 2014 10:31:33 -0700	[thread overview]
Message-ID: <539740F5.9030204@codeaurora.org> (raw)
In-Reply-To: <1402398980-24664-1-git-send-email-srinivas.kandagatla@linaro.org>

On 06/10/14 04:16, Srinivas Kandagatla wrote:
> This patch adds GSBI selection automatically from mach kconfig, As GSBI
> seems to be the very basic SOC specific driver and serial driver depends on it.
> I think this option should be selected via mach kconfig rather than adding
> it to any defconfig.
>
> Without this patch multi_v7_defconfig can not show up console on
> IFC6410.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>

No, we should be getting rid of selects, not adding more. Just put this
in the multi_v7_defconfig.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

  reply	other threads:[~2014-06-10 17:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-10 11:16 [PATCH] ARM: qcom: select GSBI from mach kconfig Srinivas Kandagatla
2014-06-10 11:16 ` Srinivas Kandagatla
2014-06-10 17:31 ` Stephen Boyd [this message]
2014-06-10 17:31   ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=539740F5.9030204@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=davidb@codeaurora.org \
    --cc=galak@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=srinivas.kandagatla@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.