From: Alex J Lennon <ajlennon@dynamicdevices.co.uk>
To: Andrei Gherzan <andrei@gherzan.ro>
Cc: Yocto Project <yocto@yoctoproject.org>
Subject: Re: ***UNCHECKED*** Re: [meta-raspberrypi][PATCH 1/1] gstreamer1.0-omx: Target Raspberry Pi instead of Bellagio.
Date: Wed, 11 Jun 2014 09:19:00 +0100 [thread overview]
Message-ID: <539810F4.3090601@dynamicdevices.co.uk> (raw)
In-Reply-To: <CAK18fxGgMPMY_zdtRnr0nHk9Dc4siGWY-dat-tw9uXVZwZW-qA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2288 bytes --]
On 11/06/2014 08:47, Andrei Gherzan wrote:
>
>
>
> On Wed, Jun 11, 2014 at 2:27 AM, Alex J Lennon
> <ajlennon@dynamicdevices.co.uk <mailto:ajlennon@dynamicdevices.co.uk>>
> wrote:
>
>
> On 10/06/2014 19:59, Andrei Gherzan wrote:
>> Hello Alex.
>>
>> On Sun, Jun 8, 2014 at 1:50 PM, Alex J Lennon
>> <ajlennon@dynamicdevices.co.uk
>> <mailto:ajlennon@dynamicdevices.co.uk>> wrote:
>>
>> This changes the build slightly as there are some #ifdefs in
>> there for Raspberry Pi.
>>
>> Also the codec configuration file used by gstreamer1.0-omx
>> codecs, /etc/xdg/gstomx.conf, is set correctly to
>> core-name=/usr/lib/libopenmaxil.so
>>
>> Change-Id: I2352ecabfd053717d9ccd2d22422e7d4b7588ce4
>> Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk
>> <mailto:ajlennon@dynamicdevices.co.uk>>
>> ---
>> recipes-multimedia/gstreamer/gstreamer1.0-omx.inc
>> | 2 ++
>> recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend
>> | 1 +
>>
>>
>> I was thinking we we really need two files for this... I know
>> that yocto has an inc too. But i don't know if that really makes
>> sense for one line. What do you think?
>>
>
> I came across Yocto best practice here. This is more or less why I
> provided a patch for consideration into Poky on this earlier
> today. It would help me, and I suspect other newbies, to have best
> practice expectations on how to put patches together somewhere up
> front, say in the README.
>
> "Do not merge .inc / .bb files"
>
> https://wiki.yoctoproject.org/wiki/Best_Known_Methods_(BKMs)_for_Package_Updating
> <https://wiki.yoctoproject.org/wiki/Best_Known_Methods_%28BKMs%29_for_Package_Updating>
>
>
> I understand. But I think that this is the case only for bb files. We
> are talking here about a bbappend in which case this would be pretty
> useless. Nobody reuses an inc for a bbappend - never seen something
> like that.
e.g. I have gstreamer1.0-omx_git.bbappend here which reuses the .inc
file. I didn't contribute it as for some reason the git build breaks and
I need to look at why this is
[-- Attachment #2: Type: text/html, Size: 5244 bytes --]
next prev parent reply other threads:[~2014-06-11 8:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-08 10:50 [meta-raspberrypi][PATCH 0/1] gstreamer1.0-omx: Target Raspberry Pi instead of Bellagio Alex J Lennon
2014-06-08 10:50 ` [meta-raspberrypi][PATCH 1/1] " Alex J Lennon
2014-06-10 18:59 ` Andrei Gherzan
2014-06-10 23:27 ` Alex J Lennon
2014-06-11 7:47 ` Andrei Gherzan
2014-06-11 8:19 ` Alex J Lennon [this message]
2014-06-11 17:24 ` Andrei Gherzan
2014-06-11 17:43 ` Alex J Lennon
2014-06-11 17:50 ` Andrei Gherzan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539810F4.3090601@dynamicdevices.co.uk \
--to=ajlennon@dynamicdevices.co.uk \
--cc=andrei@gherzan.ro \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.