* [meta-raspberrypi][PATCH 0/1] gstreamer1.0-omx: Target Raspberry Pi instead of Bellagio.
@ 2014-06-08 10:50 Alex J Lennon
2014-06-08 10:50 ` [meta-raspberrypi][PATCH 1/1] " Alex J Lennon
0 siblings, 1 reply; 9+ messages in thread
From: Alex J Lennon @ 2014-06-08 10:50 UTC (permalink / raw)
To: yocto
Please see following patch for details
Alex J Lennon (1):
gstreamer1.0-omx: Target Raspberry Pi instead of Bellagio.
recipes-multimedia/gstreamer/gstreamer1.0-omx.inc | 2 ++
recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend | 1 +
2 files changed, 3 insertions(+)
create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-omx.inc
create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend
--
2.0.0
^ permalink raw reply [flat|nested] 9+ messages in thread
* [meta-raspberrypi][PATCH 1/1] gstreamer1.0-omx: Target Raspberry Pi instead of Bellagio.
2014-06-08 10:50 [meta-raspberrypi][PATCH 0/1] gstreamer1.0-omx: Target Raspberry Pi instead of Bellagio Alex J Lennon
@ 2014-06-08 10:50 ` Alex J Lennon
2014-06-10 18:59 ` Andrei Gherzan
0 siblings, 1 reply; 9+ messages in thread
From: Alex J Lennon @ 2014-06-08 10:50 UTC (permalink / raw)
To: yocto
This changes the build slightly as there are some #ifdefs in there for Raspberry Pi.
Also the codec configuration file used by gstreamer1.0-omx codecs, /etc/xdg/gstomx.conf, is set correctly to core-name=/usr/lib/libopenmaxil.so
Change-Id: I2352ecabfd053717d9ccd2d22422e7d4b7588ce4
Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>
---
recipes-multimedia/gstreamer/gstreamer1.0-omx.inc | 2 ++
recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend | 1 +
2 files changed, 3 insertions(+)
create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-omx.inc
create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend
diff --git a/recipes-multimedia/gstreamer/gstreamer1.0-omx.inc b/recipes-multimedia/gstreamer/gstreamer1.0-omx.inc
new file mode 100644
index 0000000..eb7cca4
--- /dev/null
+++ b/recipes-multimedia/gstreamer/gstreamer1.0-omx.inc
@@ -0,0 +1,2 @@
+GSTREAMER_1_0_OMX_TARGET="rpi"
+GSTREAMER_1_0_OMX_CORE_NAME="/usr/lib/libopenmaxil.so"
diff --git a/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend b/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend
new file mode 100644
index 0000000..bd54419
--- /dev/null
+++ b/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend
@@ -0,0 +1 @@
+require ${PN}.inc
--
2.0.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [meta-raspberrypi][PATCH 1/1] gstreamer1.0-omx: Target Raspberry Pi instead of Bellagio.
2014-06-08 10:50 ` [meta-raspberrypi][PATCH 1/1] " Alex J Lennon
@ 2014-06-10 18:59 ` Andrei Gherzan
2014-06-10 23:27 ` Alex J Lennon
0 siblings, 1 reply; 9+ messages in thread
From: Andrei Gherzan @ 2014-06-10 18:59 UTC (permalink / raw)
To: Alex J Lennon; +Cc: Yocto Project
[-- Attachment #1: Type: text/plain, Size: 1982 bytes --]
Hello Alex.
On Sun, Jun 8, 2014 at 1:50 PM, Alex J Lennon <ajlennon@dynamicdevices.co.uk
> wrote:
> This changes the build slightly as there are some #ifdefs in there for
> Raspberry Pi.
>
> Also the codec configuration file used by gstreamer1.0-omx codecs,
> /etc/xdg/gstomx.conf, is set correctly to
> core-name=/usr/lib/libopenmaxil.so
>
> Change-Id: I2352ecabfd053717d9ccd2d22422e7d4b7588ce4
> Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>
> ---
> recipes-multimedia/gstreamer/gstreamer1.0-omx.inc | 2 ++
> recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend | 1 +
>
I was thinking we we really need two files for this... I know that yocto
has an inc too. But i don't know if that really makes sense for one line.
What do you think?
> 2 files changed, 3 insertions(+)
> create mode 100644 recipes-multimedia/gstreamer/gstreamer1.0-omx.inc
> create mode 100644
> recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend
>
> diff --git a/recipes-multimedia/gstreamer/gstreamer1.0-omx.inc
> b/recipes-multimedia/gstreamer/gstreamer1.0-omx.inc
> new file mode 100644
> index 0000000..eb7cca4
> --- /dev/null
> +++ b/recipes-multimedia/gstreamer/gstreamer1.0-omx.inc
> @@ -0,0 +1,2 @@
> +GSTREAMER_1_0_OMX_TARGET="rpi"
> +GSTREAMER_1_0_OMX_CORE_NAME="/usr/lib/libopenmaxil.so"
>
These changes should be machine specific.
> diff --git a/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend
> b/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend
> new file mode 100644
> index 0000000..bd54419
> --- /dev/null
> +++ b/recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend
> @@ -0,0 +1 @@
> +require ${PN}.inc
> --
> 2.0.0
>
> --
> _______________________________________________
> yocto mailing list
> yocto@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/yocto
>
--
*Andrei Gherzan*
m: +40.744.478.414 | f: +40.31.816.28.12
[-- Attachment #2: Type: text/html, Size: 3380 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-raspberrypi][PATCH 1/1] gstreamer1.0-omx: Target Raspberry Pi instead of Bellagio.
2014-06-10 18:59 ` Andrei Gherzan
@ 2014-06-10 23:27 ` Alex J Lennon
2014-06-11 7:47 ` Andrei Gherzan
0 siblings, 1 reply; 9+ messages in thread
From: Alex J Lennon @ 2014-06-10 23:27 UTC (permalink / raw)
To: Andrei Gherzan; +Cc: Yocto Project
[-- Attachment #1: Type: text/plain, Size: 1429 bytes --]
On 10/06/2014 19:59, Andrei Gherzan wrote:
> Hello Alex.
>
> On Sun, Jun 8, 2014 at 1:50 PM, Alex J Lennon
> <ajlennon@dynamicdevices.co.uk <mailto:ajlennon@dynamicdevices.co.uk>>
> wrote:
>
> This changes the build slightly as there are some #ifdefs in there
> for Raspberry Pi.
>
> Also the codec configuration file used by gstreamer1.0-omx codecs,
> /etc/xdg/gstomx.conf, is set correctly to
> core-name=/usr/lib/libopenmaxil.so
>
> Change-Id: I2352ecabfd053717d9ccd2d22422e7d4b7588ce4
> Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk
> <mailto:ajlennon@dynamicdevices.co.uk>>
> ---
> recipes-multimedia/gstreamer/gstreamer1.0-omx.inc | 2 ++
> recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend | 1 +
>
>
> I was thinking we we really need two files for this... I know that
> yocto has an inc too. But i don't know if that really makes sense for
> one line. What do you think?
>
I came across Yocto best practice here. This is more or less why I
provided a patch for consideration into Poky on this earlier today. It
would help me, and I suspect other newbies, to have best practice
expectations on how to put patches together somewhere up front, say in
the README.
"Do not merge .inc / .bb files"
https://wiki.yoctoproject.org/wiki/Best_Known_Methods_(BKMs)_for_Package_Updating
Cheers,
Alex
[-- Attachment #2: Type: text/html, Size: 2868 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-raspberrypi][PATCH 1/1] gstreamer1.0-omx: Target Raspberry Pi instead of Bellagio.
2014-06-10 23:27 ` Alex J Lennon
@ 2014-06-11 7:47 ` Andrei Gherzan
2014-06-11 8:19 ` ***UNCHECKED*** " Alex J Lennon
2014-06-11 17:24 ` Andrei Gherzan
0 siblings, 2 replies; 9+ messages in thread
From: Andrei Gherzan @ 2014-06-11 7:47 UTC (permalink / raw)
To: Alex J Lennon; +Cc: Yocto Project
[-- Attachment #1: Type: text/plain, Size: 1707 bytes --]
On Wed, Jun 11, 2014 at 2:27 AM, Alex J Lennon <
ajlennon@dynamicdevices.co.uk> wrote:
>
> On 10/06/2014 19:59, Andrei Gherzan wrote:
>
> Hello Alex.
>
> On Sun, Jun 8, 2014 at 1:50 PM, Alex J Lennon <
> ajlennon@dynamicdevices.co.uk> wrote:
>
>> This changes the build slightly as there are some #ifdefs in there for
>> Raspberry Pi.
>>
>> Also the codec configuration file used by gstreamer1.0-omx codecs,
>> /etc/xdg/gstomx.conf, is set correctly to
>> core-name=/usr/lib/libopenmaxil.so
>>
>> Change-Id: I2352ecabfd053717d9ccd2d22422e7d4b7588ce4
>> Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>
>> ---
>> recipes-multimedia/gstreamer/gstreamer1.0-omx.inc | 2 ++
>> recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend | 1 +
>>
>
> I was thinking we we really need two files for this... I know that yocto
> has an inc too. But i don't know if that really makes sense for one line.
> What do you think?
>
>
>
> I came across Yocto best practice here. This is more or less why I
> provided a patch for consideration into Poky on this earlier today. It
> would help me, and I suspect other newbies, to have best practice
> expectations on how to put patches together somewhere up front, say in the
> README.
>
> "Do not merge .inc / .bb files"
>
>
> https://wiki.yoctoproject.org/wiki/Best_Known_Methods_(BKMs)_for_Package_Updating
>
I understand. But I think that this is the case only for bb files. We are
talking here about a bbappend in which case this would be pretty useless.
Nobody reuses an inc for a bbappend - never seen something like that.
--
*Andrei Gherzan*
m: +40.744.478.414 | f: +40.31.816.28.12
[-- Attachment #2: Type: text/html, Size: 3624 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: ***UNCHECKED*** Re: [meta-raspberrypi][PATCH 1/1] gstreamer1.0-omx: Target Raspberry Pi instead of Bellagio.
2014-06-11 7:47 ` Andrei Gherzan
@ 2014-06-11 8:19 ` Alex J Lennon
2014-06-11 17:24 ` Andrei Gherzan
1 sibling, 0 replies; 9+ messages in thread
From: Alex J Lennon @ 2014-06-11 8:19 UTC (permalink / raw)
To: Andrei Gherzan; +Cc: Yocto Project
[-- Attachment #1: Type: text/plain, Size: 2288 bytes --]
On 11/06/2014 08:47, Andrei Gherzan wrote:
>
>
>
> On Wed, Jun 11, 2014 at 2:27 AM, Alex J Lennon
> <ajlennon@dynamicdevices.co.uk <mailto:ajlennon@dynamicdevices.co.uk>>
> wrote:
>
>
> On 10/06/2014 19:59, Andrei Gherzan wrote:
>> Hello Alex.
>>
>> On Sun, Jun 8, 2014 at 1:50 PM, Alex J Lennon
>> <ajlennon@dynamicdevices.co.uk
>> <mailto:ajlennon@dynamicdevices.co.uk>> wrote:
>>
>> This changes the build slightly as there are some #ifdefs in
>> there for Raspberry Pi.
>>
>> Also the codec configuration file used by gstreamer1.0-omx
>> codecs, /etc/xdg/gstomx.conf, is set correctly to
>> core-name=/usr/lib/libopenmaxil.so
>>
>> Change-Id: I2352ecabfd053717d9ccd2d22422e7d4b7588ce4
>> Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk
>> <mailto:ajlennon@dynamicdevices.co.uk>>
>> ---
>> recipes-multimedia/gstreamer/gstreamer1.0-omx.inc
>> | 2 ++
>> recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend
>> | 1 +
>>
>>
>> I was thinking we we really need two files for this... I know
>> that yocto has an inc too. But i don't know if that really makes
>> sense for one line. What do you think?
>>
>
> I came across Yocto best practice here. This is more or less why I
> provided a patch for consideration into Poky on this earlier
> today. It would help me, and I suspect other newbies, to have best
> practice expectations on how to put patches together somewhere up
> front, say in the README.
>
> "Do not merge .inc / .bb files"
>
> https://wiki.yoctoproject.org/wiki/Best_Known_Methods_(BKMs)_for_Package_Updating
> <https://wiki.yoctoproject.org/wiki/Best_Known_Methods_%28BKMs%29_for_Package_Updating>
>
>
> I understand. But I think that this is the case only for bb files. We
> are talking here about a bbappend in which case this would be pretty
> useless. Nobody reuses an inc for a bbappend - never seen something
> like that.
e.g. I have gstreamer1.0-omx_git.bbappend here which reuses the .inc
file. I didn't contribute it as for some reason the git build breaks and
I need to look at why this is
[-- Attachment #2: Type: text/html, Size: 5244 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-raspberrypi][PATCH 1/1] gstreamer1.0-omx: Target Raspberry Pi instead of Bellagio.
2014-06-11 7:47 ` Andrei Gherzan
2014-06-11 8:19 ` ***UNCHECKED*** " Alex J Lennon
@ 2014-06-11 17:24 ` Andrei Gherzan
2014-06-11 17:43 ` Alex J Lennon
1 sibling, 1 reply; 9+ messages in thread
From: Andrei Gherzan @ 2014-06-11 17:24 UTC (permalink / raw)
To: Alex J Lennon; +Cc: Yocto Project
[-- Attachment #1: Type: text/plain, Size: 2317 bytes --]
On Wed, Jun 11, 2014 at 11:19 AM, Alex J Lennon <
ajlennon@dynamicdevices.co.uk> wrote:
>
> On 11/06/2014 08:47, Andrei Gherzan wrote:
>
>
>
>
> On Wed, Jun 11, 2014 at 2:27 AM, Alex J Lennon <
> ajlennon@dynamicdevices.co.uk> wrote:
>
>>
>> On 10/06/2014 19:59, Andrei Gherzan wrote:
>>
>> Hello Alex.
>>
>> On Sun, Jun 8, 2014 at 1:50 PM, Alex J Lennon <
>> ajlennon@dynamicdevices.co.uk> wrote:
>>
>>> This changes the build slightly as there are some #ifdefs in there for
>>> Raspberry Pi.
>>>
>>> Also the codec configuration file used by gstreamer1.0-omx codecs,
>>> /etc/xdg/gstomx.conf, is set correctly to
>>> core-name=/usr/lib/libopenmaxil.so
>>>
>>> Change-Id: I2352ecabfd053717d9ccd2d22422e7d4b7588ce4
>>> Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>
>>> ---
>>> recipes-multimedia/gstreamer/gstreamer1.0-omx.inc | 2 ++
>>> recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend | 1 +
>>>
>>
>> I was thinking we we really need two files for this... I know that
>> yocto has an inc too. But i don't know if that really makes sense for one
>> line. What do you think?
>>
>>
>>
>> I came across Yocto best practice here. This is more or less why I
>> provided a patch for consideration into Poky on this earlier today. It
>> would help me, and I suspect other newbies, to have best practice
>> expectations on how to put patches together somewhere up front, say in the
>> README.
>>
>> "Do not merge .inc / .bb files"
>>
>>
>> https://wiki.yoctoproject.org/wiki/Best_Known_Methods_(BKMs)_for_Package_Updating
>>
>
> I understand. But I think that this is the case only for bb files. We
> are talking here about a bbappend in which case this would be pretty
> useless. Nobody reuses an inc for a bbappend - never seen something like
> that.
>
>
> e.g. I have gstreamer1.0-omx_git.bbappend here which reuses the .inc file.
> I didn't contribute it as for some reason the git build breaks and I need
> to look at why this is
>
>
So, you say that if you merge your inc file in the bbappend one, the build
breaks? It shouldn't really. I just tested and for me it works.
By the way, I would use _append_raspberrypi for this one too.
--
*Andrei Gherzan*
m: +40.744.478.414 | f: +40.31.816.28.12
[-- Attachment #2: Type: text/html, Size: 5961 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-raspberrypi][PATCH 1/1] gstreamer1.0-omx: Target Raspberry Pi instead of Bellagio.
2014-06-11 17:24 ` Andrei Gherzan
@ 2014-06-11 17:43 ` Alex J Lennon
2014-06-11 17:50 ` Andrei Gherzan
0 siblings, 1 reply; 9+ messages in thread
From: Alex J Lennon @ 2014-06-11 17:43 UTC (permalink / raw)
To: Andrei Gherzan; +Cc: Yocto Project
[-- Attachment #1: Type: text/plain, Size: 4742 bytes --]
On 11/06/2014 18:24, Andrei Gherzan wrote:
>
>
> On Wed, Jun 11, 2014 at 11:19 AM, Alex J Lennon
> <ajlennon@dynamicdevices.co.uk <mailto:ajlennon@dynamicdevices.co.uk>>
> wrote:
>
>
> On 11/06/2014 08:47, Andrei Gherzan wrote:
>>
>>
>>
>> On Wed, Jun 11, 2014 at 2:27 AM, Alex J Lennon
>> <ajlennon@dynamicdevices.co.uk
>> <mailto:ajlennon@dynamicdevices.co.uk>> wrote:
>>
>>
>> On 10/06/2014 19:59, Andrei Gherzan wrote:
>>> Hello Alex.
>>>
>>> On Sun, Jun 8, 2014 at 1:50 PM, Alex J Lennon
>>> <ajlennon@dynamicdevices.co.uk
>>> <mailto:ajlennon@dynamicdevices.co.uk>> wrote:
>>>
>>> This changes the build slightly as there are some
>>> #ifdefs in there for Raspberry Pi.
>>>
>>> Also the codec configuration file used by
>>> gstreamer1.0-omx codecs, /etc/xdg/gstomx.conf, is set
>>> correctly to core-name=/usr/lib/libopenmaxil.so
>>>
>>> Change-Id: I2352ecabfd053717d9ccd2d22422e7d4b7588ce4
>>> Signed-off-by: Alex J Lennon
>>> <ajlennon@dynamicdevices.co.uk
>>> <mailto:ajlennon@dynamicdevices.co.uk>>
>>> ---
>>> recipes-multimedia/gstreamer/gstreamer1.0-omx.inc
>>> | 2 ++
>>> recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend
>>> | 1 +
>>>
>>>
>>> I was thinking we we really need two files for this... I
>>> know that yocto has an inc too. But i don't know if that
>>> really makes sense for one line. What do you think?
>>>
>>
>> I came across Yocto best practice here. This is more or less
>> why I provided a patch for consideration into Poky on this
>> earlier today. It would help me, and I suspect other newbies,
>> to have best practice expectations on how to put patches
>> together somewhere up front, say in the README.
>>
>> "Do not merge .inc / .bb files"
>>
>> https://wiki.yoctoproject.org/wiki/Best_Known_Methods_(BKMs)_for_Package_Updating
>> <https://wiki.yoctoproject.org/wiki/Best_Known_Methods_%28BKMs%29_for_Package_Updating>
>>
>>
>> I understand. But I think that this is the case only for bb
>> files. We are talking here about a bbappend in which case this
>> would be pretty useless. Nobody reuses an inc for a bbappend -
>> never seen something like that.
>
> e.g. I have gstreamer1.0-omx_git.bbappend here which reuses the
> .inc file. I didn't contribute it as for some reason the git build
> breaks and I need to look at why this is
>
>
> So, you say that if you merge your inc file in the bbappend one, the
> build breaks? It shouldn't really. I just tested and for me it works.
>
Not quite. I mean that I am reusing the code in the .inc file in another
.bbappend file, called gstreamer1.0-omx_git.bbappend
This is identical to gstreamer1.0-omx_1.0.0.bbappend in that it just
requires the inc file, so I don't have duplication of code.
Targetting gstreamer-omx 1.0.0 at the RPi works fine, but when I tried
targetting the git source at RPi the build broke, so I didn't provide
that recipe to you.
e.g. with my local.conf set to PREFERRED_VERSION_gstreamer1.0-omx =
"git" the git build gives this
cc1: error: .../tmp/sysroots/raspberrypi/usr/include/vc: No such file or
directory [-Werror]
cc1: error: .../tmp/sysroots/raspberrypi/usr/include/interface: No such
file or directory [-Werror]
cc1: error: .../tmp/sysroots/raspberrypi/usr/include/interface/vcos: No
such file or directory [-Werror]
cc1: error:
.../tmp/sysroots/raspberrypi/usr/include/interface/vcos/pthreads: No
such file or directory $
cc1: all warnings being treated as errors
make[2]: *** [libgstomx_la-gstomxvideoenc.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
I think there's something missing or some path not set correctly for the
more recent gstreamer-omx code, but I haven't had a chance to look into it.
> By the way, I would use _append_raspberrypi for this one too.
>
>
>
OK, I just tried this instead of the anonymous python method I created
in the last patch-set.
Perhaps I'm misunderstanding but, for example, we need
GSTREAMER_1_0_OMX_TARGET set to 'rpi" when machine is raspberrypi
When I try,
GSTREAMER_1_0_OMX_TARGET_append_raspberrypi = "rpi"
I end up with the original value 'bellagio' appended with 'rpi' to give
'bellagiorpi'
Maybe I need something more like this?
GSTREAMER_1_0_OMX_TARGET_override_raspberrypi = "rpi"
Does such a mechanism exist in bitbake?
Regards,
Alex
[-- Attachment #2: Type: text/html, Size: 10632 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-raspberrypi][PATCH 1/1] gstreamer1.0-omx: Target Raspberry Pi instead of Bellagio.
2014-06-11 17:43 ` Alex J Lennon
@ 2014-06-11 17:50 ` Andrei Gherzan
0 siblings, 0 replies; 9+ messages in thread
From: Andrei Gherzan @ 2014-06-11 17:50 UTC (permalink / raw)
To: Alex J Lennon; +Cc: Yocto Project
[-- Attachment #1: Type: text/plain, Size: 4634 bytes --]
On Wed, Jun 11, 2014 at 8:43 PM, Alex J Lennon <
ajlennon@dynamicdevices.co.uk> wrote:
>
> On 11/06/2014 18:24, Andrei Gherzan wrote:
>
>
>
> On Wed, Jun 11, 2014 at 11:19 AM, Alex J Lennon <
> ajlennon@dynamicdevices.co.uk> wrote:
>
>>
>> On 11/06/2014 08:47, Andrei Gherzan wrote:
>>
>>
>>
>>
>> On Wed, Jun 11, 2014 at 2:27 AM, Alex J Lennon <
>> ajlennon@dynamicdevices.co.uk> wrote:
>>
>>>
>>> On 10/06/2014 19:59, Andrei Gherzan wrote:
>>>
>>> Hello Alex.
>>>
>>> On Sun, Jun 8, 2014 at 1:50 PM, Alex J Lennon <
>>> ajlennon@dynamicdevices.co.uk> wrote:
>>>
>>>> This changes the build slightly as there are some #ifdefs in there for
>>>> Raspberry Pi.
>>>>
>>>> Also the codec configuration file used by gstreamer1.0-omx codecs,
>>>> /etc/xdg/gstomx.conf, is set correctly to
>>>> core-name=/usr/lib/libopenmaxil.so
>>>>
>>>> Change-Id: I2352ecabfd053717d9ccd2d22422e7d4b7588ce4
>>>> Signed-off-by: Alex J Lennon <ajlennon@dynamicdevices.co.uk>
>>>> ---
>>>> recipes-multimedia/gstreamer/gstreamer1.0-omx.inc | 2 ++
>>>> recipes-multimedia/gstreamer/gstreamer1.0-omx_1.0.0.bbappend | 1 +
>>>>
>>>
>>> I was thinking we we really need two files for this... I know that
>>> yocto has an inc too. But i don't know if that really makes sense for one
>>> line. What do you think?
>>>
>>>
>>>
>>> I came across Yocto best practice here. This is more or less why I
>>> provided a patch for consideration into Poky on this earlier today. It
>>> would help me, and I suspect other newbies, to have best practice
>>> expectations on how to put patches together somewhere up front, say in the
>>> README.
>>>
>>> "Do not merge .inc / .bb files"
>>>
>>>
>>> https://wiki.yoctoproject.org/wiki/Best_Known_Methods_(BKMs)_for_Package_Updating
>>>
>>
>> I understand. But I think that this is the case only for bb files. We
>> are talking here about a bbappend in which case this would be pretty
>> useless. Nobody reuses an inc for a bbappend - never seen something like
>> that.
>>
>>
>> e.g. I have gstreamer1.0-omx_git.bbappend here which reuses the .inc
>> file. I didn't contribute it as for some reason the git build breaks and I
>> need to look at why this is
>>
>>
> So, you say that if you merge your inc file in the bbappend one, the
> build breaks? It shouldn't really. I just tested and for me it works.
>
>
> Not quite. I mean that I am reusing the code in the .inc file in another
> .bbappend file, called gstreamer1.0-omx_git.bbappend
>
>
Got it now. Makes sense in this case, agreed.
> This is identical to gstreamer1.0-omx_1.0.0.bbappend in that it just
> requires the inc file, so I don't have duplication of code.
>
> Targetting gstreamer-omx 1.0.0 at the RPi works fine, but when I tried
> targetting the git source at RPi the build broke, so I didn't provide that
> recipe to you.
>
> e.g. with my local.conf set to PREFERRED_VERSION_gstreamer1.0-omx = "git"
> the git build gives this
>
> cc1: error: .../tmp/sysroots/raspberrypi/usr/include/vc: No such file or
> directory [-Werror]
> cc1: error: .../tmp/sysroots/raspberrypi/usr/include/interface: No such
> file or directory [-Werror]
> cc1: error: .../tmp/sysroots/raspberrypi/usr/include/interface/vcos: No
> such file or directory [-Werror]
> cc1: error:
> .../tmp/sysroots/raspberrypi/usr/include/interface/vcos/pthreads: No such
> file or directory $
> cc1: all warnings being treated as errors
> make[2]: *** [libgstomx_la-gstomxvideoenc.lo] Error 1
> make[2]: *** Waiting for unfinished jobs....
>
> I think there's something missing or some path not set correctly for the
> more recent gstreamer-omx code, but I haven't had a chance to look into it.
>
>
> Most probably you mangle some paths there. Needs some investigation.
> By the way, I would use _append_raspberrypi for this one too.
>
>
>
>
> OK, I just tried this instead of the anonymous python method I created in
> the last patch-set.
>
> Perhaps I'm misunderstanding but, for example, we need
> GSTREAMER_1_0_OMX_TARGET set to 'rpi" when machine is raspberrypi
>
> When I try,
>
> GSTREAMER_1_0_OMX_TARGET_append_raspberrypi = "rpi"
>
> I end up with the original value 'bellagio' appended with 'rpi' to give
> 'bellagiorpi'
>
> Maybe I need something more like this?
>
> GSTREAMER_1_0_OMX_TARGET_override_raspberrypi = "rpi"
>
> Does such a mechanism exist in bitbake?
>
>
Yes. To override a variable you just don't use "append":
VARIABLE_mymachine = "my value"
--
*Andrei Gherzan*
m: +40.744.478.414 | f: +40.31.816.28.12
[-- Attachment #2: Type: text/html, Size: 11280 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-06-11 17:50 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-08 10:50 [meta-raspberrypi][PATCH 0/1] gstreamer1.0-omx: Target Raspberry Pi instead of Bellagio Alex J Lennon
2014-06-08 10:50 ` [meta-raspberrypi][PATCH 1/1] " Alex J Lennon
2014-06-10 18:59 ` Andrei Gherzan
2014-06-10 23:27 ` Alex J Lennon
2014-06-11 7:47 ` Andrei Gherzan
2014-06-11 8:19 ` ***UNCHECKED*** " Alex J Lennon
2014-06-11 17:24 ` Andrei Gherzan
2014-06-11 17:43 ` Alex J Lennon
2014-06-11 17:50 ` Andrei Gherzan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.