From: Tomasz Figa <tomasz.figa@gmail.com>
To: Tushar Behera <tushar.b@samsung.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: mturquette@linaro.org, t.figa@samsung.com,
linux@arm.linux.org.uk, galak@codeaurora.org,
ijc+devicetree@hellion.org.uk, mark.rutland@arm.com,
pawel.moll@arm.com, robh+dt@kernel.org, kgene.kim@samsung.com,
khilman@linaro.org, dianders@google.com, trblinux@gmail.com,
Shaik Ameer Basha <shaik.ameer@samsung.com>
Subject: Re: [PATCH 1/3] clk: exynos-audss: Keep the parent of mout_audss always enabled
Date: Wed, 11 Jun 2014 19:28:48 +0200 [thread overview]
Message-ID: <539891D0.8090309@gmail.com> (raw)
In-Reply-To: <1402464739-19044-2-git-send-email-tushar.b@samsung.com>
Hi Tushar,
On 11.06.2014 07:32, Tushar Behera wrote:
> When the output clock of AUDSS mux is disabled, we are getting kernel
> oops while doing a clk_get() on other clocks provided by AUDSS. Though
> user manual doesn't specify this dependency, we came across this issue
> while disabling the parent of AUDSS mux clocks.
Could you provide more data about this oops? E.g. kernel log, platforms
it affects (just peach-pit or also others), test case, extra patches
applied on top of mainline (if any).
I don't like this solution, because keeping a clock always enabled is
usually not desirable and this driver is also used on other platforms
than peach-pit, so this change will affect all of them.
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] clk: exynos-audss: Keep the parent of mout_audss always enabled
Date: Wed, 11 Jun 2014 19:28:48 +0200 [thread overview]
Message-ID: <539891D0.8090309@gmail.com> (raw)
In-Reply-To: <1402464739-19044-2-git-send-email-tushar.b@samsung.com>
Hi Tushar,
On 11.06.2014 07:32, Tushar Behera wrote:
> When the output clock of AUDSS mux is disabled, we are getting kernel
> oops while doing a clk_get() on other clocks provided by AUDSS. Though
> user manual doesn't specify this dependency, we came across this issue
> while disabling the parent of AUDSS mux clocks.
Could you provide more data about this oops? E.g. kernel log, platforms
it affects (just peach-pit or also others), test case, extra patches
applied on top of mainline (if any).
I don't like this solution, because keeping a clock always enabled is
usually not desirable and this driver is also used on other platforms
than peach-pit, so this change will affect all of them.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-06-11 17:28 UTC|newest]
Thread overview: 108+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 5:32 [PATCH 0/3] Fix boot-hang on Peach-pit and Enable audio Tushar Behera
2014-06-11 5:32 ` Tushar Behera
2014-06-11 5:32 ` [PATCH 1/3] clk: exynos-audss: Keep the parent of mout_audss always enabled Tushar Behera
2014-06-11 5:32 ` Tushar Behera
2014-06-11 15:58 ` Javier Martinez Canillas
2014-06-11 15:58 ` Javier Martinez Canillas
[not found] ` <1402464739-19044-2-git-send-email-tushar.b-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-06-11 16:50 ` Mike Turquette
2014-06-11 16:50 ` Mike Turquette
2014-06-11 16:50 ` Mike Turquette
2014-06-12 7:29 ` Tushar Behera
2014-06-12 7:29 ` Tushar Behera
2014-06-12 21:09 ` Mike Turquette
2014-06-12 21:09 ` Mike Turquette
2014-07-11 6:18 ` Tushar Behera
2014-07-11 6:18 ` Tushar Behera
2014-07-29 6:58 ` Mike Turquette
2014-07-29 6:58 ` Mike Turquette
2014-06-11 16:50 ` Kevin Hilman
2014-06-11 16:50 ` Kevin Hilman
2014-06-12 7:40 ` Tushar Behera
2014-06-12 7:40 ` Tushar Behera
2014-06-24 22:59 ` Doug Anderson
2014-06-24 22:59 ` Doug Anderson
2014-06-25 3:09 ` Tushar Behera
2014-06-25 3:09 ` Tushar Behera
2014-06-25 4:02 ` Doug Anderson
2014-06-25 4:02 ` Doug Anderson
2014-06-11 17:28 ` Tomasz Figa [this message]
2014-06-11 17:28 ` Tomasz Figa
2014-06-12 7:30 ` Tushar Behera
2014-06-12 7:30 ` Tushar Behera
2014-06-11 5:32 ` [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420 Tushar Behera
2014-06-11 5:32 ` Tushar Behera
2014-06-11 15:58 ` Javier Martinez Canillas
2014-06-11 15:58 ` Javier Martinez Canillas
2014-06-16 11:26 ` Tushar Behera
2014-06-16 11:26 ` Tushar Behera
2014-06-22 15:53 ` Tushar Behera
2014-06-22 15:53 ` Tushar Behera
2014-06-24 23:00 ` Doug Anderson
2014-06-24 23:00 ` Doug Anderson
2014-06-25 23:21 ` Kevin Hilman
2014-06-25 23:21 ` Kevin Hilman
2014-06-25 23:21 ` Kevin Hilman
2014-06-26 3:20 ` Tushar Behera
2014-06-26 3:20 ` Tushar Behera
2014-06-26 16:08 ` Kevin Hilman
2014-06-26 16:08 ` Kevin Hilman
2014-06-26 16:08 ` Kevin Hilman
2014-06-27 3:38 ` Tushar Behera
2014-06-27 3:38 ` Tushar Behera
2014-06-27 14:18 ` Kevin Hilman
2014-06-27 14:18 ` Kevin Hilman
2014-06-27 14:48 ` Kevin Hilman
2014-06-27 14:48 ` Kevin Hilman
2014-07-01 11:59 ` Tushar Behera
2014-07-01 11:59 ` Tushar Behera
2014-07-07 23:34 ` Kukjin Kim
2014-07-07 23:34 ` Kukjin Kim
2014-07-08 3:00 ` Tushar Behera
2014-07-08 3:00 ` Tushar Behera
2014-07-09 10:14 ` Javier Martinez Canillas
2014-07-09 10:14 ` Javier Martinez Canillas
2014-07-09 12:11 ` Tushar Behera
2014-07-09 12:11 ` Tushar Behera
[not found] ` <53BD3157.7030804-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-07-09 13:03 ` Javier Martinez Canillas
2014-07-09 13:03 ` Javier Martinez Canillas
2014-07-09 13:03 ` Javier Martinez Canillas
2014-07-09 16:01 ` Doug Anderson
2014-07-09 16:01 ` Doug Anderson
2014-07-09 17:46 ` Javier Martinez Canillas
2014-07-09 17:46 ` Javier Martinez Canillas
[not found] ` <CABxcv==v9whax3oraJQnTiDwfAUznjQP6WHK-auPv3q-LOmdnA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-09 17:52 ` Doug Anderson
2014-07-09 17:52 ` Doug Anderson
2014-07-09 17:52 ` Doug Anderson
[not found] ` <1402464739-19044-1-git-send-email-tushar.b-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-06-11 5:32 ` [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board Tushar Behera
2014-06-11 5:32 ` Tushar Behera
2014-06-11 5:32 ` Tushar Behera
2014-06-13 17:03 ` Doug Anderson
2014-06-13 17:03 ` Doug Anderson
2014-06-13 17:05 ` Mark Brown
2014-06-13 17:05 ` Mark Brown
2014-06-13 17:13 ` Doug Anderson
2014-06-13 17:13 ` Doug Anderson
[not found] ` <CAD=FV=VvkvH1TPiKttm9VXbBRnBo7kmTVK8bZZvexK=bAvaO4Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-06-13 21:58 ` Doug Anderson
2014-06-13 21:58 ` Doug Anderson
2014-06-13 21:58 ` Doug Anderson
2014-06-13 22:04 ` Mark Brown
2014-06-13 22:04 ` Mark Brown
2014-06-13 22:04 ` Mark Brown
[not found] ` <20140613220421.GD5099-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-06-13 22:50 ` Doug Anderson
2014-06-13 22:50 ` Doug Anderson
2014-06-13 22:50 ` Doug Anderson
2014-06-16 11:19 ` Tushar Behera
2014-06-16 11:19 ` Tushar Behera
[not found] ` <539ED2C0.8030405-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-06-16 16:49 ` Doug Anderson
2014-06-16 16:49 ` Doug Anderson
2014-06-16 16:49 ` Doug Anderson
2014-06-16 16:51 ` Mark Brown
2014-06-16 16:51 ` Mark Brown
2014-06-16 17:02 ` Doug Anderson
2014-06-16 17:02 ` Doug Anderson
2014-06-17 3:39 ` Tushar Behera
2014-06-17 3:39 ` Tushar Behera
2014-06-17 3:36 ` Tushar Behera
2014-06-17 3:36 ` Tushar Behera
2014-06-17 4:07 ` Doug Anderson
2014-06-17 4:07 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539891D0.8090309@gmail.com \
--to=tomasz.figa@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@google.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kgene.kim@samsung.com \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mturquette@linaro.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=shaik.ameer@samsung.com \
--cc=t.figa@samsung.com \
--cc=trblinux@gmail.com \
--cc=tushar.b@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.