All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tushar Behera <trblinux@gmail.com>
To: Kevin Hilman <khilman@linaro.org>
Cc: Javier Martinez Canillas <javier@dowhile0.org>,
	Tushar Behera <tushar.b@samsung.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	linux-samsung-soc@vger.kernel.org,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	mturquette@linaro.org, t.figa@samsung.com,
	Russell King <linux@arm.linux.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Mark Rutland <mark.rutland@arm.com>,
	Pawel Moll <pawel.moll@arm.com>, Rob Herring <robh+dt@kernel.org>,
	Kukjin Kim <kgene.kim@samsung.com>,
	dianders@google.com, Shaik Ameer Basha <shaik.ameer@samsung.com>
Subject: Re: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420
Date: Mon, 16 Jun 2014 16:56:42 +0530	[thread overview]
Message-ID: <539ED472.5020102@gmail.com> (raw)
In-Reply-To: <CABxcv=kX07pNCd-YPYp6J8S5hHzG1rsoer1YRfdPE0g-xFqZnQ@mail.gmail.com>

On 06/11/2014 09:28 PM, Javier Martinez Canillas wrote:
> On Wed, Jun 11, 2014 at 7:32 AM, Tushar Behera <tushar.b@samsung.com> wrote:
>> Currently CLK_FOUT_EPLL was set as one of the parents of AUDSS mux.
>> As per the user manual, it should be CLK_MAU_EPLL.
>>
>> The problem surfaced when the bootloader in Peach-pit board set
>> the EPLL clock as the parent of AUDSS mux. While booting the kernel,
>> we used to get a system hang during late boot if CLK_MAU_EPLL was
>> disabled.
>>
>> Signed-off-by: Tushar Behera <tushar.b@samsung.com>
>> Signed-off-by: Shaik Ameer Basha <shaik.ameer@samsung.com>
>> Reported-by: Kevin Hilman <khilman@linaro.org>
>> ---
>>  arch/arm/boot/dts/exynos5420.dtsi |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
>> index e385322..79e9119 100644
>> --- a/arch/arm/boot/dts/exynos5420.dtsi
>> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>> @@ -167,7 +167,7 @@
>>                 compatible = "samsung,exynos5420-audss-clock";
>>                 reg = <0x03810000 0x0C>;
>>                 #clock-cells = <1>;
>> -               clocks = <&clock CLK_FIN_PLL>, <&clock CLK_FOUT_EPLL>,
>> +               clocks = <&clock CLK_FIN_PLL>, <&clock CLK_MAU_EPLL>,
>>                          <&clock CLK_SCLK_MAUDIO0>, <&clock CLK_SCLK_MAUPCM0>;
>>                 clock-names = "pll_ref", "pll_in", "sclk_audio", "sclk_pcm_in";
>>         };
>> --
>> 1.7.9.5
>>
>> --
> 
> Tested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> 

Kukjin,

Would you please take this patch as a fix for 3.16?

-- 
Tushar Behera

WARNING: multiple messages have this Message-ID (diff)
From: trblinux@gmail.com (Tushar Behera)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420
Date: Mon, 16 Jun 2014 16:56:42 +0530	[thread overview]
Message-ID: <539ED472.5020102@gmail.com> (raw)
In-Reply-To: <CABxcv=kX07pNCd-YPYp6J8S5hHzG1rsoer1YRfdPE0g-xFqZnQ@mail.gmail.com>

On 06/11/2014 09:28 PM, Javier Martinez Canillas wrote:
> On Wed, Jun 11, 2014 at 7:32 AM, Tushar Behera <tushar.b@samsung.com> wrote:
>> Currently CLK_FOUT_EPLL was set as one of the parents of AUDSS mux.
>> As per the user manual, it should be CLK_MAU_EPLL.
>>
>> The problem surfaced when the bootloader in Peach-pit board set
>> the EPLL clock as the parent of AUDSS mux. While booting the kernel,
>> we used to get a system hang during late boot if CLK_MAU_EPLL was
>> disabled.
>>
>> Signed-off-by: Tushar Behera <tushar.b@samsung.com>
>> Signed-off-by: Shaik Ameer Basha <shaik.ameer@samsung.com>
>> Reported-by: Kevin Hilman <khilman@linaro.org>
>> ---
>>  arch/arm/boot/dts/exynos5420.dtsi |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
>> index e385322..79e9119 100644
>> --- a/arch/arm/boot/dts/exynos5420.dtsi
>> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>> @@ -167,7 +167,7 @@
>>                 compatible = "samsung,exynos5420-audss-clock";
>>                 reg = <0x03810000 0x0C>;
>>                 #clock-cells = <1>;
>> -               clocks = <&clock CLK_FIN_PLL>, <&clock CLK_FOUT_EPLL>,
>> +               clocks = <&clock CLK_FIN_PLL>, <&clock CLK_MAU_EPLL>,
>>                          <&clock CLK_SCLK_MAUDIO0>, <&clock CLK_SCLK_MAUPCM0>;
>>                 clock-names = "pll_ref", "pll_in", "sclk_audio", "sclk_pcm_in";
>>         };
>> --
>> 1.7.9.5
>>
>> --
> 
> Tested-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> 

Kukjin,

Would you please take this patch as a fix for 3.16?

-- 
Tushar Behera

  reply	other threads:[~2014-06-16 11:26 UTC|newest]

Thread overview: 108+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-11  5:32 [PATCH 0/3] Fix boot-hang on Peach-pit and Enable audio Tushar Behera
2014-06-11  5:32 ` Tushar Behera
2014-06-11  5:32 ` [PATCH 1/3] clk: exynos-audss: Keep the parent of mout_audss always enabled Tushar Behera
2014-06-11  5:32   ` Tushar Behera
2014-06-11 15:58   ` Javier Martinez Canillas
2014-06-11 15:58     ` Javier Martinez Canillas
     [not found]   ` <1402464739-19044-2-git-send-email-tushar.b-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-06-11 16:50     ` Mike Turquette
2014-06-11 16:50       ` Mike Turquette
2014-06-11 16:50       ` Mike Turquette
2014-06-12  7:29       ` Tushar Behera
2014-06-12  7:29         ` Tushar Behera
2014-06-12 21:09         ` Mike Turquette
2014-06-12 21:09           ` Mike Turquette
2014-07-11  6:18           ` Tushar Behera
2014-07-11  6:18             ` Tushar Behera
2014-07-29  6:58             ` Mike Turquette
2014-07-29  6:58               ` Mike Turquette
2014-06-11 16:50   ` Kevin Hilman
2014-06-11 16:50     ` Kevin Hilman
2014-06-12  7:40     ` Tushar Behera
2014-06-12  7:40       ` Tushar Behera
2014-06-24 22:59       ` Doug Anderson
2014-06-24 22:59         ` Doug Anderson
2014-06-25  3:09         ` Tushar Behera
2014-06-25  3:09           ` Tushar Behera
2014-06-25  4:02           ` Doug Anderson
2014-06-25  4:02             ` Doug Anderson
2014-06-11 17:28   ` Tomasz Figa
2014-06-11 17:28     ` Tomasz Figa
2014-06-12  7:30     ` Tushar Behera
2014-06-12  7:30       ` Tushar Behera
2014-06-11  5:32 ` [PATCH 2/3] ARM: dts: Update the parent for Audss clocks in Exynos5420 Tushar Behera
2014-06-11  5:32   ` Tushar Behera
2014-06-11 15:58   ` Javier Martinez Canillas
2014-06-11 15:58     ` Javier Martinez Canillas
2014-06-16 11:26     ` Tushar Behera [this message]
2014-06-16 11:26       ` Tushar Behera
2014-06-22 15:53       ` Tushar Behera
2014-06-22 15:53         ` Tushar Behera
2014-06-24 23:00   ` Doug Anderson
2014-06-24 23:00     ` Doug Anderson
2014-06-25 23:21     ` Kevin Hilman
2014-06-25 23:21       ` Kevin Hilman
2014-06-25 23:21       ` Kevin Hilman
2014-06-26  3:20       ` Tushar Behera
2014-06-26  3:20         ` Tushar Behera
2014-06-26 16:08         ` Kevin Hilman
2014-06-26 16:08           ` Kevin Hilman
2014-06-26 16:08           ` Kevin Hilman
2014-06-27  3:38           ` Tushar Behera
2014-06-27  3:38             ` Tushar Behera
2014-06-27 14:18             ` Kevin Hilman
2014-06-27 14:18               ` Kevin Hilman
2014-06-27 14:48               ` Kevin Hilman
2014-06-27 14:48                 ` Kevin Hilman
2014-07-01 11:59                 ` Tushar Behera
2014-07-01 11:59                   ` Tushar Behera
2014-07-07 23:34                   ` Kukjin Kim
2014-07-07 23:34                     ` Kukjin Kim
2014-07-08  3:00                     ` Tushar Behera
2014-07-08  3:00                       ` Tushar Behera
2014-07-09 10:14                       ` Javier Martinez Canillas
2014-07-09 10:14                         ` Javier Martinez Canillas
2014-07-09 12:11                         ` Tushar Behera
2014-07-09 12:11                           ` Tushar Behera
     [not found]                           ` <53BD3157.7030804-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-07-09 13:03                             ` Javier Martinez Canillas
2014-07-09 13:03                               ` Javier Martinez Canillas
2014-07-09 13:03                               ` Javier Martinez Canillas
2014-07-09 16:01                               ` Doug Anderson
2014-07-09 16:01                                 ` Doug Anderson
2014-07-09 17:46                                 ` Javier Martinez Canillas
2014-07-09 17:46                                   ` Javier Martinez Canillas
     [not found]                                   ` <CABxcv==v9whax3oraJQnTiDwfAUznjQP6WHK-auPv3q-LOmdnA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-07-09 17:52                                     ` Doug Anderson
2014-07-09 17:52                                       ` Doug Anderson
2014-07-09 17:52                                       ` Doug Anderson
     [not found] ` <1402464739-19044-1-git-send-email-tushar.b-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-06-11  5:32   ` [PATCH 3/3] ARM: dts: Enable audio support for Peach-pi board Tushar Behera
2014-06-11  5:32     ` Tushar Behera
2014-06-11  5:32     ` Tushar Behera
2014-06-13 17:03     ` Doug Anderson
2014-06-13 17:03       ` Doug Anderson
2014-06-13 17:05       ` Mark Brown
2014-06-13 17:05         ` Mark Brown
2014-06-13 17:13         ` Doug Anderson
2014-06-13 17:13           ` Doug Anderson
     [not found]           ` <CAD=FV=VvkvH1TPiKttm9VXbBRnBo7kmTVK8bZZvexK=bAvaO4Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-06-13 21:58             ` Doug Anderson
2014-06-13 21:58               ` Doug Anderson
2014-06-13 21:58               ` Doug Anderson
2014-06-13 22:04               ` Mark Brown
2014-06-13 22:04                 ` Mark Brown
2014-06-13 22:04                 ` Mark Brown
     [not found]                 ` <20140613220421.GD5099-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-06-13 22:50                   ` Doug Anderson
2014-06-13 22:50                     ` Doug Anderson
2014-06-13 22:50                     ` Doug Anderson
2014-06-16 11:19       ` Tushar Behera
2014-06-16 11:19         ` Tushar Behera
     [not found]         ` <539ED2C0.8030405-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-06-16 16:49           ` Doug Anderson
2014-06-16 16:49             ` Doug Anderson
2014-06-16 16:49             ` Doug Anderson
2014-06-16 16:51             ` Mark Brown
2014-06-16 16:51               ` Mark Brown
2014-06-16 17:02               ` Doug Anderson
2014-06-16 17:02                 ` Doug Anderson
2014-06-17  3:39                 ` Tushar Behera
2014-06-17  3:39                   ` Tushar Behera
2014-06-17  3:36             ` Tushar Behera
2014-06-17  3:36               ` Tushar Behera
2014-06-17  4:07               ` Doug Anderson
2014-06-17  4:07                 ` Doug Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=539ED472.5020102@gmail.com \
    --to=trblinux@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@google.com \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=javier@dowhile0.org \
    --cc=kgene.kim@samsung.com \
    --cc=khilman@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@linaro.org \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=shaik.ameer@samsung.com \
    --cc=t.figa@samsung.com \
    --cc=tushar.b@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.