Support upper case identifier in vm.cfg for xl?

Support upper case identifier in vm.cfg for xl?

[Zhigang Wang]

[-- Attachment #1: Type: text/plain, Size: 907 bytes --]

Hi,

It seems we only support `[a-z][._0-9a-z]*` as identifiers in vm.cfg for xl
and upper case letter is not supported. This is different from xm.

An use case is: management tools may put arbitrary key/value pairs into vm.cfg.
Current xl has limited support of this feature: xl will ignore unknown options.

I wonder whether we can make xl support uppercase letters? Then management
tools don't need to change if they already use upper letter identifiers.

Attached patch is a quick fix and seems working for me. Please help to comment on:

1. Was there a specific reason not to support upper cases?
  (I know it's simple and if there's no xm, this design is the best.)

2. If we support upper case letters, will it affect other components?

2. Is this patch correct?

3. If we want this patch, someone (Ian J.?) also need to generate the in tree 
   libxlu_cfg_i.h and libxlu_cfg_l.c.

Thanks,

Zhigang


[-- Attachment #2: xen-tools-xl-vm-cfg-upper-ident.patch --]
[-- Type: text/x-patch, Size: 714 bytes --]

commit d347511769289703e534a999c75badb5cc93b3eb
Author: Zhigang Wang <zhigang.x.wang@oracle.com>
Date:   Fri Jun 13 16:06:10 2014 -0400

    tools/xl: support upper case letters as vm.cfg identifiers
    
    Signed-off-by: Zhigang Wang <zhigang.x.wang@oracle.com>

diff --git a/tools/libxl/libxlu_cfg_l.l b/tools/libxl/libxlu_cfg_l.l
index e0ea8cf..b03f0f1 100644
--- a/tools/libxl/libxlu_cfg_l.l
+++ b/tools/libxl/libxlu_cfg_l.l
@@ -52,7 +52,7 @@ void xlu__cfg_yyset_column(int  column_no, yyscan_t yyscanner);
 
 %%
 
-[a-z][._0-9a-z]*        {
+[a-zA-Z][._0-9a-zA-Z]*  {
                           yylval->string= xlu__cfgl_strdup(ctx,yytext);
                           GOT(IDENT);
                         }

[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: Support upper case identifier in vm.cfg for xl?

[Ian Campbell]

On Fri, 2014-06-13 at 16:11 -0400, Zhigang Wang wrote:
> Hi,
> 
> It seems we only support `[a-z][._0-9a-z]*` as identifiers in vm.cfg for xl
> and upper case letter is not supported. This is different from xm.
> 
> An use case is: management tools may put arbitrary key/value pairs into vm.cfg.
> Current xl has limited support of this feature: xl will ignore unknown options.
> 
> I wonder whether we can make xl support uppercase letters?

I think maybe you mean "make the libxlu cfg file parser support
uppercase letters", because you are reusing that library in your
management tool perhaps? 

>  Then management
> tools don't need to change if they already use upper letter identifiers.
> 
> Attached patch is a quick fix and seems working for me. Please help to comment on:
> 
> 1. Was there a specific reason not to support upper cases?
>   (I know it's simple and if there's no xm, this design is the best.)
> 
> 2. If we support upper case letters, will it affect other components?
> 
> 2. Is this patch correct?
> 
> 3. If we want this patch, someone (Ian J.?) also need to generate the in tree 
>    libxlu_cfg_i.h and libxlu_cfg_l.c.
> 
> Thanks,
> 
> Zhigang
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

Re: Support upper case identifier in vm.cfg for xl?

[Zhigang Wang]

On 06/16/2014 05:18 AM, Ian Campbell wrote:
> On Fri, 2014-06-13 at 16:11 -0400, Zhigang Wang wrote:
>> Hi,
>>
>> It seems we only support `[a-z][._0-9a-z]*` as identifiers in vm.cfg for xl
>> and upper case letter is not supported. This is different from xm.
>>
>> An use case is: management tools may put arbitrary key/value pairs into vm.cfg.
>> Current xl has limited support of this feature: xl will ignore unknown options.
>>
>> I wonder whether we can make xl support uppercase letters?
> 
> I think maybe you mean "make the libxlu cfg file parser support
> uppercase letters", because you are reusing that library in your
> management tool perhaps? 

Yes. That's what I want.

We are planning to use both xl command line and the libxl library.

Thanks,

Zhigang
 
>>  Then management
>> tools don't need to change if they already use upper letter identifiers.
>>
>> Attached patch is a quick fix and seems working for me. Please help to comment on:
>>
>> 1. Was there a specific reason not to support upper cases?
>>   (I know it's simple and if there's no xm, this design is the best.)
>>
>> 2. If we support upper case letters, will it affect other components?
>>
>> 2. Is this patch correct?
>>
>> 3. If we want this patch, someone (Ian J.?) also need to generate the in tree 
>>    libxlu_cfg_i.h and libxlu_cfg_l.c.
>>
>> Thanks,
>>
>> Zhigang
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xen.org
>> http://lists.xen.org/xen-devel
> 
> 

Re: Support upper case identifier in vm.cfg for xl?

[Ian Campbell]

On Mon, 2014-06-16 at 09:17 -0400, Zhigang Wang wrote:
> On 06/16/2014 05:18 AM, Ian Campbell wrote:
> > On Fri, 2014-06-13 at 16:11 -0400, Zhigang Wang wrote:
> >> Hi,
> >>
> >> It seems we only support `[a-z][._0-9a-z]*` as identifiers in vm.cfg for xl
> >> and upper case letter is not supported. This is different from xm.
> >>
> >> An use case is: management tools may put arbitrary key/value pairs into vm.cfg.
> >> Current xl has limited support of this feature: xl will ignore unknown options.
> >>
> >> I wonder whether we can make xl support uppercase letters?
> > 
> > I think maybe you mean "make the libxlu cfg file parser support
> > uppercase letters", because you are reusing that library in your
> > management tool perhaps? 
> 
> Yes. That's what I want.
> 
> We are planning to use both xl command line and the libxl library.

OK. Just to be pedantic the xl cfg parser is part of the libxlu utility
library, which is neither libxl nor xl. libxlu is essentially xl stuff
which might be useful to other toolstack but which isn't formally part
of libxl. (e.g. disk parsing is in there because we knew libvirt would
also want to parse xm style disk configuration strings)

Ian.