From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Andrew Bresticker
<abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v3 1/4] of: Add NVIDIA Tegra XUSB pad controller binding
Date: Mon, 16 Jun 2014 15:35:20 -0600 [thread overview]
Message-ID: <539F6318.5010306@wwwdotorg.org> (raw)
In-Reply-To: <1402930623-28886-1-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On 06/16/2014 08:57 AM, Thierry Reding wrote:
> From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>
> This patch adds the device tree binding documentation for the XUSB pad
> controller found on NVIDIA Tegra SoCs. It exposes both pinmuxing and PHY
> capabilities.
This looks fine to me, with one issue below:
> diff --git a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra124-xusb-padctl.txt b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra124-xusb-padctl.txt
> +Required properties:
> +--------------------
> +- #address-cells: Should be 0.
> +- #size-cells: Should be 0.
I don't think those properties are needed. If they are, a value of 0 for
both doesn't seem useful. I assume those two lines should just be
deleted, and also from the example below.
Assuming I take this through the Tegra tree, If this is the only issue,
I can delete those lines when applying.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/4] of: Add NVIDIA Tegra XUSB pad controller binding
Date: Mon, 16 Jun 2014 15:35:20 -0600 [thread overview]
Message-ID: <539F6318.5010306@wwwdotorg.org> (raw)
In-Reply-To: <1402930623-28886-1-git-send-email-thierry.reding@gmail.com>
On 06/16/2014 08:57 AM, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> This patch adds the device tree binding documentation for the XUSB pad
> controller found on NVIDIA Tegra SoCs. It exposes both pinmuxing and PHY
> capabilities.
This looks fine to me, with one issue below:
> diff --git a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra124-xusb-padctl.txt b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra124-xusb-padctl.txt
> +Required properties:
> +--------------------
> +- #address-cells: Should be 0.
> +- #size-cells: Should be 0.
I don't think those properties are needed. If they are, a value of 0 for
both doesn't seem useful. I assume those two lines should just be
deleted, and also from the example below.
Assuming I take this through the Tegra tree, If this is the only issue,
I can delete those lines when applying.
next prev parent reply other threads:[~2014-06-16 21:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 14:57 [PATCH v3 1/4] of: Add NVIDIA Tegra XUSB pad controller binding Thierry Reding
2014-06-16 14:57 ` Thierry Reding
[not found] ` <1402930623-28886-1-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-06-16 14:57 ` [PATCH v3 2/4] pinctrl: Add NVIDIA Tegra XUSB pad controller support Thierry Reding
2014-06-16 14:57 ` Thierry Reding
[not found] ` <1402930623-28886-2-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-06-17 11:20 ` Mikko Perttunen
2014-06-17 11:20 ` Mikko Perttunen
[not found] ` <53A02479.8080405-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-06-17 12:09 ` Thierry Reding
2014-06-17 12:09 ` Thierry Reding
2014-06-16 14:57 ` [PATCH v3 3/4] ARM: tegra: tegra124: Add XUSB pad controller Thierry Reding
2014-06-16 14:57 ` Thierry Reding
2014-06-16 14:57 ` [PATCH v3 4/4] ARM: tegra: jetson-tk1: " Thierry Reding
2014-06-16 14:57 ` Thierry Reding
[not found] ` <1402930623-28886-4-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-06-16 21:39 ` Stephen Warren
2014-06-16 21:39 ` Stephen Warren
2014-06-16 21:35 ` Stephen Warren [this message]
2014-06-16 21:35 ` [PATCH v3 1/4] of: Add NVIDIA Tegra XUSB pad controller binding Stephen Warren
[not found] ` <539F6318.5010306-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-06-17 12:09 ` Thierry Reding
2014-06-17 12:09 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539F6318.5010306@wwwdotorg.org \
--to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
--cc=abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.