From: Mikko Perttunen <mperttunen-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Andrew Bresticker
<abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH v3 2/4] pinctrl: Add NVIDIA Tegra XUSB pad controller support
Date: Tue, 17 Jun 2014 14:20:25 +0300 [thread overview]
Message-ID: <53A02479.8080405@nvidia.com> (raw)
In-Reply-To: <1402930623-28886-2-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
This v3 breaks SATA; see below
On 16/06/14 17:57, Thierry Reding wrote:
...
> + regval = padctl_readl(padctl, lane->offset);
> +
> + if (!value)
> + regval &= ~lane->iddq;
> + else
> + regval |= lane->iddq;
> +
> + padctl_writel(padctl, regval, lane->offset);
...
The bits at at lane->iddq are actually IDDQ_DISABLE bits, so this is the
wrong way around: having iddq = <0> in device tree leads to the device
turning off. So either the DT property should be renamed or the branches
of the if here should be switched around.
v2 used the wrong variable so the else branch ended up being chosen each
time, this also meant that SATA worked by chance.
- Mikko
WARNING: multiple messages have this Message-ID (diff)
From: mperttunen@nvidia.com (Mikko Perttunen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/4] pinctrl: Add NVIDIA Tegra XUSB pad controller support
Date: Tue, 17 Jun 2014 14:20:25 +0300 [thread overview]
Message-ID: <53A02479.8080405@nvidia.com> (raw)
In-Reply-To: <1402930623-28886-2-git-send-email-thierry.reding@gmail.com>
This v3 breaks SATA; see below
On 16/06/14 17:57, Thierry Reding wrote:
...
> + regval = padctl_readl(padctl, lane->offset);
> +
> + if (!value)
> + regval &= ~lane->iddq;
> + else
> + regval |= lane->iddq;
> +
> + padctl_writel(padctl, regval, lane->offset);
...
The bits at at lane->iddq are actually IDDQ_DISABLE bits, so this is the
wrong way around: having iddq = <0> in device tree leads to the device
turning off. So either the DT property should be renamed or the branches
of the if here should be switched around.
v2 used the wrong variable so the else branch ended up being chosen each
time, this also meant that SATA worked by chance.
- Mikko
next prev parent reply other threads:[~2014-06-17 11:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 14:57 [PATCH v3 1/4] of: Add NVIDIA Tegra XUSB pad controller binding Thierry Reding
2014-06-16 14:57 ` Thierry Reding
[not found] ` <1402930623-28886-1-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-06-16 14:57 ` [PATCH v3 2/4] pinctrl: Add NVIDIA Tegra XUSB pad controller support Thierry Reding
2014-06-16 14:57 ` Thierry Reding
[not found] ` <1402930623-28886-2-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-06-17 11:20 ` Mikko Perttunen [this message]
2014-06-17 11:20 ` Mikko Perttunen
[not found] ` <53A02479.8080405-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-06-17 12:09 ` Thierry Reding
2014-06-17 12:09 ` Thierry Reding
2014-06-16 14:57 ` [PATCH v3 3/4] ARM: tegra: tegra124: Add XUSB pad controller Thierry Reding
2014-06-16 14:57 ` Thierry Reding
2014-06-16 14:57 ` [PATCH v3 4/4] ARM: tegra: jetson-tk1: " Thierry Reding
2014-06-16 14:57 ` Thierry Reding
[not found] ` <1402930623-28886-4-git-send-email-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-06-16 21:39 ` Stephen Warren
2014-06-16 21:39 ` Stephen Warren
2014-06-16 21:35 ` [PATCH v3 1/4] of: Add NVIDIA Tegra XUSB pad controller binding Stephen Warren
2014-06-16 21:35 ` Stephen Warren
[not found] ` <539F6318.5010306-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-06-17 12:09 ` Thierry Reding
2014-06-17 12:09 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A02479.8080405@nvidia.com \
--to=mperttunen-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.