[PATCH] fs/cifs: fix regression in cifs_create_mf_symlink()

[PATCH] fs/cifs: fix regression in cifs_create_mf_symlink()

[Björn Baumbach]

commit d81b8a40e2ece0a9ab57b1fe1798e291e75bf8fc
("CIFS: Cleanup cifs open codepath")
changed disposition to FILE_OPEN.

Signed-off-by: Björn Baumbach <bb@sernet.de>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Cc: <stable@vger.kernel.org> # v3.14+
Cc: Pavel Shilovsky <piastry@etersoft.ru>
Cc: Steve French <sfrench@samba.org>
---
 fs/cifs/link.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/cifs/link.c b/fs/cifs/link.c
index 264ece7..68559fd 100644
--- a/fs/cifs/link.c
+++ b/fs/cifs/link.c
@@ -374,7 +374,7 @@ cifs_create_mf_symlink(unsigned int xid, struct cifs_tcon *tcon,
 	oparms.cifs_sb = cifs_sb;
 	oparms.desired_access = GENERIC_WRITE;
 	oparms.create_options = create_options;
-	oparms.disposition = FILE_OPEN;
+	oparms.disposition = FILE_CREATE;
 	oparms.path = path;
 	oparms.fid = &fid;
 	oparms.reconnect = false;
-- 
1.7.9.5

Re: [PATCH] fs/cifs: fix regression in cifs_create_mf_symlink()

[Stefan (metze) Metzmacher]

[-- Attachment #1: Type: text/plain, Size: 1313 bytes --]

Hi Steve,

any comments on this? How can we get this fixed upstream?

Thanks!
metze

Am 10.06.2014 12:03, schrieb Björn Baumbach:
> commit d81b8a40e2ece0a9ab57b1fe1798e291e75bf8fc
> ("CIFS: Cleanup cifs open codepath")
> changed disposition to FILE_OPEN.
> 
> Signed-off-by: Björn Baumbach <bb-3ekOc4rQMZmzQB+pC5nmwQ@public.gmane.org>
> Signed-off-by: Stefan Metzmacher <metze-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
> Reviewed-by: Stefan Metzmacher <metze-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
> Cc: <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> # v3.14+
> Cc: Pavel Shilovsky <piastry-7qunaywFIewox3rIn2DAYQ@public.gmane.org>
> Cc: Steve French <sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>
> ---
>  fs/cifs/link.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/cifs/link.c b/fs/cifs/link.c
> index 264ece7..68559fd 100644
> --- a/fs/cifs/link.c
> +++ b/fs/cifs/link.c
> @@ -374,7 +374,7 @@ cifs_create_mf_symlink(unsigned int xid, struct cifs_tcon *tcon,
>  	oparms.cifs_sb = cifs_sb;
>  	oparms.desired_access = GENERIC_WRITE;
>  	oparms.create_options = create_options;
> -	oparms.disposition = FILE_OPEN;
> +	oparms.disposition = FILE_CREATE;
>  	oparms.path = path;
>  	oparms.fid = &fid;
>  	oparms.reconnect = false;
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

Re: [PATCH] fs/cifs: fix regression in cifs_create_mf_symlink()

[Stefan (metze) Metzmacher]

[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]

Hi Steve,

any comments on this? How can we get this fixed upstream?

Thanks!
metze

Am 10.06.2014 12:03, schrieb Björn Baumbach:
> commit d81b8a40e2ece0a9ab57b1fe1798e291e75bf8fc
> ("CIFS: Cleanup cifs open codepath")
> changed disposition to FILE_OPEN.
> 
> Signed-off-by: Björn Baumbach <bb@sernet.de>
> Signed-off-by: Stefan Metzmacher <metze@samba.org>
> Reviewed-by: Stefan Metzmacher <metze@samba.org>
> Cc: <stable@vger.kernel.org> # v3.14+
> Cc: Pavel Shilovsky <piastry@etersoft.ru>
> Cc: Steve French <sfrench@samba.org>
> ---
>  fs/cifs/link.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/cifs/link.c b/fs/cifs/link.c
> index 264ece7..68559fd 100644
> --- a/fs/cifs/link.c
> +++ b/fs/cifs/link.c
> @@ -374,7 +374,7 @@ cifs_create_mf_symlink(unsigned int xid, struct cifs_tcon *tcon,
>  	oparms.cifs_sb = cifs_sb;
>  	oparms.desired_access = GENERIC_WRITE;
>  	oparms.create_options = create_options;
> -	oparms.disposition = FILE_OPEN;
> +	oparms.disposition = FILE_CREATE;
>  	oparms.path = path;
>  	oparms.fid = &fid;
>  	oparms.reconnect = false;
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

Re: [PATCH] fs/cifs: fix regression in cifs_create_mf_symlink()

[Steve French]

Although I have merged this into cifs-2.6.git for-next, in my testing
I am also seeing this fail with vers=3.0 (and probably 2.0 and 2.1) so
I would like to fix that too (and mfsymlinks may be at least as
important there)

On Mon, Jun 16, 2014 at 8:49 AM, Stefan (metze) Metzmacher
<metze@samba.org> wrote:
> Hi Steve,
>
> any comments on this? How can we get this fixed upstream?
>
> Thanks!
> metze
>
> Am 10.06.2014 12:03, schrieb Björn Baumbach:
>> commit d81b8a40e2ece0a9ab57b1fe1798e291e75bf8fc
>> ("CIFS: Cleanup cifs open codepath")
>> changed disposition to FILE_OPEN.
>>
>> Signed-off-by: Björn Baumbach <bb@sernet.de>
>> Signed-off-by: Stefan Metzmacher <metze@samba.org>
>> Reviewed-by: Stefan Metzmacher <metze@samba.org>
>> Cc: <stable@vger.kernel.org> # v3.14+
>> Cc: Pavel Shilovsky <piastry@etersoft.ru>
>> Cc: Steve French <sfrench@samba.org>
>> ---
>>  fs/cifs/link.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/cifs/link.c b/fs/cifs/link.c
>> index 264ece7..68559fd 100644
>> --- a/fs/cifs/link.c
>> +++ b/fs/cifs/link.c
>> @@ -374,7 +374,7 @@ cifs_create_mf_symlink(unsigned int xid, struct cifs_tcon *tcon,
>>       oparms.cifs_sb = cifs_sb;
>>       oparms.desired_access = GENERIC_WRITE;
>>       oparms.create_options = create_options;
>> -     oparms.disposition = FILE_OPEN;
>> +     oparms.disposition = FILE_CREATE;
>>       oparms.path = path;
>>       oparms.fid = &fid;
>>       oparms.reconnect = false;
>>
>



-- 
Thanks,

Steve

Re: [PATCH] fs/cifs: fix regression in cifs_create_mf_symlink()

[Stefan (metze) Metzmacher]

[-- Attachment #1: Type: text/plain, Size: 342 bytes --]

Hi Steve,

> Although I have merged this into cifs-2.6.git for-next, in my testing
> I am also seeing this fail with vers=3.0 (and probably 2.0 and 2.1) so
> I would like to fix that too (and mfsymlinks may be at least as
> important there)

Thanks! When can we expect this to be proposed for 3.16 (and stable
3.14/3.15)?

metze


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]