From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Mark Brown <broonie@kernel.org>
Cc: linux-sh@vger.kernel.org,
Linux-ALSA <alsa-devel@alsa-project.org>,
Simon <horms@verge.net.au>,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 09/12] ASoC: rsnd: enable SRC setting via DT
Date: Wed, 18 Jun 2014 18:20:18 +0400 [thread overview]
Message-ID: <53A1A022.1020801@cogentembedded.com> (raw)
In-Reply-To: <87zjhay4s6.wl%kuninori.morimoto.gx@renesas.com>
Hello.
On 06/18/2014 12:56 PM, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> some special board wants to exchange sampling rate by using SRC.
> This patch enables its settings.
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
[...]
> diff --git a/sound/soc/sh/rcar/src.c b/sound/soc/sh/rcar/src.c
> index 4d39505..93a5e58 100644
> --- a/sound/soc/sh/rcar/src.c
> +++ b/sound/soc/sh/rcar/src.c
[...]
> @@ -640,6 +640,16 @@ static void rsnd_of_parse_src(struct platform_device *pdev,
> info->src_info = src_info;
> info->src_info_nr = nr;
>
> + i = 0;
> + for_each_child_of_node(src_node, np) {
> + src_info = info->src_info + i;
> +
> + of_property_read_u32(src_node, "convert-rate",
Are you sure it's 'src_node' here, not 'np'?
> + &src_info->convert_rate);
> +
> + i++;
> + }
> +
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Mark Brown <broonie@kernel.org>
Cc: linux-sh@vger.kernel.org,
Linux-ALSA <alsa-devel@alsa-project.org>,
Simon <horms@verge.net.au>,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 09/12] ASoC: rsnd: enable SRC setting via DT
Date: Wed, 18 Jun 2014 14:20:18 +0000 [thread overview]
Message-ID: <53A1A022.1020801@cogentembedded.com> (raw)
In-Reply-To: <87zjhay4s6.wl%kuninori.morimoto.gx@renesas.com>
Hello.
On 06/18/2014 12:56 PM, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> some special board wants to exchange sampling rate by using SRC.
> This patch enables its settings.
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
[...]
> diff --git a/sound/soc/sh/rcar/src.c b/sound/soc/sh/rcar/src.c
> index 4d39505..93a5e58 100644
> --- a/sound/soc/sh/rcar/src.c
> +++ b/sound/soc/sh/rcar/src.c
[...]
> @@ -640,6 +640,16 @@ static void rsnd_of_parse_src(struct platform_device *pdev,
> info->src_info = src_info;
> info->src_info_nr = nr;
>
> + i = 0;
> + for_each_child_of_node(src_node, np) {
> + src_info = info->src_info + i;
> +
> + of_property_read_u32(src_node, "convert-rate",
Are you sure it's 'src_node' here, not 'np'?
> + &src_info->convert_rate);
> +
> + i++;
> + }
> +
WBR, Sergei
next prev parent reply other threads:[~2014-06-18 14:20 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 8:53 [PATCH 0/12] ASoC: rsnd: fixup and DT support patches Kuninori Morimoto
2014-06-18 8:53 ` Kuninori Morimoto
2014-06-18 8:54 ` [PATCH 01/12] ASoC: rsnd: fixup rsnd_gen_dma_addr() for Gen1 Kuninori Morimoto
2014-06-18 8:54 ` Kuninori Morimoto
2014-06-18 10:06 ` Mark Brown
2014-06-18 10:06 ` Mark Brown
2014-07-28 12:58 ` Simon Horman
2014-07-28 12:58 ` Simon Horman
2014-07-28 13:48 ` Mark Brown
2014-07-28 13:48 ` Mark Brown
2014-07-29 0:52 ` Simon Horman
2014-07-29 0:52 ` Simon Horman
2014-06-18 8:55 ` [PATCH 02/12] ASoC: rsnd: fixup loop exit timing of dma name search Kuninori Morimoto
2014-06-18 8:55 ` Kuninori Morimoto
2014-06-18 10:07 ` Mark Brown
2014-06-18 10:07 ` Mark Brown
2014-06-18 8:55 ` [PATCH 03/12] ASoC: rsnd: SSI + DMA can select BUSIF Kuninori Morimoto
2014-06-18 8:55 ` Kuninori Morimoto
2014-06-18 8:55 ` [PATCH 04/12] ASoC: fsi: use SNDRV_DMA_TYPE_DEV for sound buffer Kuninori Morimoto
2014-06-18 8:55 ` Kuninori Morimoto
2014-06-18 8:56 ` [PATCH 05/12] ASoC: fsi: add fsi_pointer_update() for common pointer method Kuninori Morimoto
2014-06-18 8:56 ` Kuninori Morimoto
2014-06-18 8:56 ` [PATCH 06/12] ASoC: fsi: use dmaengine_prep_dma_cyclic() for DMA transfer Kuninori Morimoto
2014-06-18 8:56 ` Kuninori Morimoto
2014-06-18 8:56 ` [PATCH 07/12] ASoC: rsnd: use dmaengine_prep_dma_cyclic() instead of original method Kuninori Morimoto
2014-06-18 8:56 ` Kuninori Morimoto
2014-06-18 8:56 ` [PATCH 08/12] ASoC: rsnd: enable DVC when capture Kuninori Morimoto
2014-06-18 8:56 ` Kuninori Morimoto
2014-06-18 8:56 ` [PATCH 09/12] ASoC: rsnd: enable SRC setting via DT Kuninori Morimoto
2014-06-18 8:56 ` Kuninori Morimoto
2014-06-18 14:20 ` Sergei Shtylyov [this message]
2014-06-18 14:20 ` Sergei Shtylyov
2014-06-19 0:54 ` Kuninori Morimoto
2014-06-19 0:54 ` Kuninori Morimoto
2014-06-18 8:56 ` [PATCH 10/12] ASoC: rsnd: DMA cleanup for flexible SSI/SRC selection Kuninori Morimoto
2014-06-18 8:56 ` Kuninori Morimoto
2014-06-18 8:57 ` [PATCH 11/12] ASoC: rsnd: DMA start address is properly used for each DMAC Kuninori Morimoto
2014-06-18 8:57 ` Kuninori Morimoto
2014-06-18 14:22 ` Sergei Shtylyov
2014-06-18 14:22 ` Sergei Shtylyov
2014-06-18 8:57 ` [PATCH 12/12] ASoC: rsnd: add DT support to DVC Kuninori Morimoto
2014-06-18 8:57 ` Kuninori Morimoto
2014-06-23 0:54 ` [PATCH 0/10 v2] ASoC: rsnd: fixup and DT support patches Kuninori Morimoto
2014-06-23 0:54 ` Kuninori Morimoto
2014-06-23 0:55 ` [PATCH 01/10 v2] ASoC: fsi: use SNDRV_DMA_TYPE_DEV for sound buffer Kuninori Morimoto
2014-06-23 0:55 ` Kuninori Morimoto
2014-06-23 0:55 ` [PATCH 02/10 v2] ASoC: fsi: add fsi_pointer_update() for common pointer method Kuninori Morimoto
2014-06-23 0:55 ` Kuninori Morimoto
2014-06-23 0:55 ` [PATCH 03/10] ASoC: fsi: use dmaengine_prep_dma_cyclic() for DMA transfer Kuninori Morimoto
2014-06-23 0:55 ` Kuninori Morimoto
2014-06-23 0:56 ` [PATCH 04/10 v2] ASoC: rsnd: SSI + DMA can select BUSIF Kuninori Morimoto
2014-06-23 0:56 ` Kuninori Morimoto
2014-06-23 0:56 ` [PATCH 05/10 v2] ASoC: rsnd: use dmaengine_prep_dma_cyclic() instead of original method Kuninori Morimoto
2014-06-23 0:56 ` Kuninori Morimoto
2014-06-23 0:57 ` [PATCH 06/10 v2] ASoC: rsnd: enable DVC when capture Kuninori Morimoto
2014-06-23 0:57 ` Kuninori Morimoto
2014-06-28 13:41 ` Mark Brown
2014-06-28 13:41 ` Mark Brown
2014-06-23 0:57 ` [PATCH 07/10 v2] ASoC: rsnd: enable SRC setting via DT Kuninori Morimoto
2014-06-23 0:57 ` Kuninori Morimoto
2014-06-28 13:40 ` Mark Brown
2014-06-28 13:40 ` Mark Brown
2014-06-30 0:41 ` Kuninori Morimoto
2014-06-30 0:41 ` Kuninori Morimoto
2014-06-23 0:58 ` [PATCH 08/10 v2] ASoC: rsnd: DMA cleanup for flexible SSI/SRC selection Kuninori Morimoto
2014-06-23 0:58 ` Kuninori Morimoto
2014-07-02 11:25 ` Mark Brown
2014-07-02 11:25 ` Mark Brown
2014-06-23 0:59 ` [PATCH 09/10 v2] ASoC: rsnd: DMA start address is properly used for each DMAC Kuninori Morimoto
2014-06-23 0:59 ` Kuninori Morimoto
2014-07-02 11:36 ` Mark Brown
2014-07-02 11:36 ` Mark Brown
2014-06-23 0:59 ` [PATCH 10/10 v2] ASoC: rsnd: add DT support to DVC Kuninori Morimoto
2014-06-23 0:59 ` Kuninori Morimoto
2014-07-02 11:36 ` Mark Brown
2014-07-02 11:36 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A1A022.1020801@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.