From: James Hogan <james.hogan@imgtec.com>
To: Sorin Dumitru <sdumitru@ixiacom.com>,
<linux-kernel@vger.kernel.org>, <linux-mips@linux-mips.org>
Cc: <ralf@linux-mips.org>
Subject: Re: [PATCH] mips: n32: use compat getsockopt syscall
Date: Fri, 20 Jun 2014 10:54:26 +0100 [thread overview]
Message-ID: <53A404D2.3030303@imgtec.com> (raw)
In-Reply-To: <1403250786-9763-1-git-send-email-sdumitru@ixiacom.com>
On 20/06/14 08:53, Sorin Dumitru wrote:
> Signed-off-by: Sorin Dumitru <sdumitru@ixiacom.com>
A little more commit message wouldn't hurt. Did it break a particular
program?
It's consistent with compat_sys_socketcall(), include/uapi/asm/unistd.h,
and commit 515c7af85ed9 (which does same thing for x32) though so it
looks good to me.
Reviewed-by: James Hogan <james.hogan@imgtec.com>
Cheers
James
> ---
> arch/mips/kernel/scall64-n32.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/kernel/scall64-n32.S b/arch/mips/kernel/scall64-n32.S
> index c1dbcda..e543861 100644
> --- a/arch/mips/kernel/scall64-n32.S
> +++ b/arch/mips/kernel/scall64-n32.S
> @@ -162,7 +162,7 @@ EXPORT(sysn32_call_table)
> PTR sys_getpeername
> PTR sys_socketpair
> PTR compat_sys_setsockopt
> - PTR sys_getsockopt
> + PTR compat_sys_getsockopt
> PTR __sys_clone /* 6055 */
> PTR __sys_fork
> PTR compat_sys_execve
>
WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@imgtec.com>
To: Sorin Dumitru <sdumitru@ixiacom.com>,
linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
Cc: ralf@linux-mips.org
Subject: Re: [PATCH] mips: n32: use compat getsockopt syscall
Date: Fri, 20 Jun 2014 10:54:26 +0100 [thread overview]
Message-ID: <53A404D2.3030303@imgtec.com> (raw)
Message-ID: <20140620095426.bZ1ciQsOOSyeanZGcr4kc99i3K2hio-1Zr459OzJ1TQ@z> (raw)
In-Reply-To: <1403250786-9763-1-git-send-email-sdumitru@ixiacom.com>
On 20/06/14 08:53, Sorin Dumitru wrote:
> Signed-off-by: Sorin Dumitru <sdumitru@ixiacom.com>
A little more commit message wouldn't hurt. Did it break a particular
program?
It's consistent with compat_sys_socketcall(), include/uapi/asm/unistd.h,
and commit 515c7af85ed9 (which does same thing for x32) though so it
looks good to me.
Reviewed-by: James Hogan <james.hogan@imgtec.com>
Cheers
James
> ---
> arch/mips/kernel/scall64-n32.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/kernel/scall64-n32.S b/arch/mips/kernel/scall64-n32.S
> index c1dbcda..e543861 100644
> --- a/arch/mips/kernel/scall64-n32.S
> +++ b/arch/mips/kernel/scall64-n32.S
> @@ -162,7 +162,7 @@ EXPORT(sysn32_call_table)
> PTR sys_getpeername
> PTR sys_socketpair
> PTR compat_sys_setsockopt
> - PTR sys_getsockopt
> + PTR compat_sys_getsockopt
> PTR __sys_clone /* 6055 */
> PTR __sys_fork
> PTR compat_sys_execve
>
next prev parent reply other threads:[~2014-06-20 9:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 7:53 [PATCH] mips: n32: use compat getsockopt syscall Sorin Dumitru
2014-06-20 7:53 ` Sorin Dumitru
2014-06-20 9:54 ` James Hogan [this message]
2014-06-20 9:54 ` James Hogan
2014-06-20 10:40 ` Sorin Dumitru
2014-06-20 10:40 ` Sorin Dumitru
2014-06-20 10:50 ` James Hogan
2014-06-20 10:50 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A404D2.3030303@imgtec.com \
--to=james.hogan@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sdumitru@ixiacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.