From: James Hogan <james.hogan@imgtec.com>
To: Sorin Dumitru <sdumitru@ixiacom.com>,
<linux-kernel@vger.kernel.org>, <linux-mips@linux-mips.org>
Cc: <ralf@linux-mips.org>
Subject: Re: [PATCH] mips: n32: use compat getsockopt syscall
Date: Fri, 20 Jun 2014 11:50:39 +0100 [thread overview]
Message-ID: <53A411FF.5070505@imgtec.com> (raw)
In-Reply-To: <53A40FB0.2020503@ixiacom.com>
On 20/06/14 11:40, Sorin Dumitru wrote:
> On 06/20/14 12:54, James Hogan wrote:
>> On 20/06/14 08:53, Sorin Dumitru wrote:
>>> Signed-off-by: Sorin Dumitru <sdumitru@ixiacom.com>
>>
>> A little more commit message wouldn't hurt. Did it break a particular
>> program?
>
> Yes, it was found by an internal program trying to get IP_PKTOPTIONS on
> a cavium octeon board.
>
> Should I resubmit stating what was broken in the commit message?
Yeh, if you don't mind. I think it's useful to know exactly why a change
was made and what it fixes when later digging through the git history
(e.g. commit 515c7af85ed9 is a great example of that).
Thanks
James
WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@imgtec.com>
To: Sorin Dumitru <sdumitru@ixiacom.com>,
linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
Cc: ralf@linux-mips.org
Subject: Re: [PATCH] mips: n32: use compat getsockopt syscall
Date: Fri, 20 Jun 2014 11:50:39 +0100 [thread overview]
Message-ID: <53A411FF.5070505@imgtec.com> (raw)
Message-ID: <20140620105039.j26bPqpJQsLG2WBlc4z_Dbisa2-OPhg3xMpA03Parfs@z> (raw)
In-Reply-To: <53A40FB0.2020503@ixiacom.com>
On 20/06/14 11:40, Sorin Dumitru wrote:
> On 06/20/14 12:54, James Hogan wrote:
>> On 20/06/14 08:53, Sorin Dumitru wrote:
>>> Signed-off-by: Sorin Dumitru <sdumitru@ixiacom.com>
>>
>> A little more commit message wouldn't hurt. Did it break a particular
>> program?
>
> Yes, it was found by an internal program trying to get IP_PKTOPTIONS on
> a cavium octeon board.
>
> Should I resubmit stating what was broken in the commit message?
Yeh, if you don't mind. I think it's useful to know exactly why a change
was made and what it fixes when later digging through the git history
(e.g. commit 515c7af85ed9 is a great example of that).
Thanks
James
next prev parent reply other threads:[~2014-06-20 10:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 7:53 [PATCH] mips: n32: use compat getsockopt syscall Sorin Dumitru
2014-06-20 7:53 ` Sorin Dumitru
2014-06-20 9:54 ` James Hogan
2014-06-20 9:54 ` James Hogan
2014-06-20 10:40 ` Sorin Dumitru
2014-06-20 10:40 ` Sorin Dumitru
2014-06-20 10:50 ` James Hogan [this message]
2014-06-20 10:50 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A411FF.5070505@imgtec.com \
--to=james.hogan@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sdumitru@ixiacom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.