From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dt/documentation: add specification of dma bus information
Date: Fri, 20 Jun 2014 15:02:43 -0400 [thread overview]
Message-ID: <53A48553.2080504@ti.com> (raw)
In-Reply-To: <4193075.zZSpRTFEYz@wuerfel>
On Friday 20 June 2014 02:56 PM, Arnd Bergmann wrote:
> On Friday 20 June 2014 13:17:43 Santosh Shilimkar wrote:
>>>> + dma-coherent;
>>>> + dma-ranges;
>>>> +
>>>> + dwc3 at 2690000 {
>>>> + compatible = "synopsys,dwc3";
>>>> + [...]
>>>> + };
>>>
>>> This example is a bit strange. I don't understand the relationship
>>> between keystone-dwc3 and synopsys,dwc3, nor do I want to. I'd prefer
>>> to see a simple example here.
>
>
>>> dma-ranges is a property of the parent which you show, but
>>> dma-coherent originally was a property of the bus master itself. While
>>> we need to support that, are we changing that? We need to be clear on
>>> where the property belongs even if the kernel is more lax.
>>>
>> I don't think we are changing it fundamentally but may be I missing
>> your point. The dma-coherent as is now a per-device property.
>> USB is one of the bus master supports coherency and hence showed
>> up in above example.
>
> I think it's enough if you just drop the "synopsys,dwc3" node and the
> intermediate dma-ranges property from the example, leaving the
> dma-coherent property in the "ti,keystone-dwc3" node.
>
Thanks Arnd. That should avoid the confusion. Just to see if Rob is
fine by it, the example will look like below.
Example:
soc {
compatible = "ti,keystone","simple-bus";
ranges = <0x0 0x0 0x0 0xc0000000>;
dma-ranges = <0x80000000 0x8 0x00000000 0x80000000>;
[...]
usb: usb at 2680000 {
compatible = "ti,keystone-dwc3";
[...]
dma-coherent;
};
};
Regards,
Santosh
WARNING: multiple messages have this Message-ID (diff)
From: Santosh Shilimkar <santosh.shilimkar-l0cyMroinI0@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Grygorii Strashko
<grygorii.strashko-l0cyMroinI0@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
linux-kernel
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Shawn Guo <shawn.guo-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Subject: Re: [PATCH] dt/documentation: add specification of dma bus information
Date: Fri, 20 Jun 2014 15:02:43 -0400 [thread overview]
Message-ID: <53A48553.2080504@ti.com> (raw)
In-Reply-To: <4193075.zZSpRTFEYz@wuerfel>
On Friday 20 June 2014 02:56 PM, Arnd Bergmann wrote:
> On Friday 20 June 2014 13:17:43 Santosh Shilimkar wrote:
>>>> + dma-coherent;
>>>> + dma-ranges;
>>>> +
>>>> + dwc3@2690000 {
>>>> + compatible = "synopsys,dwc3";
>>>> + [...]
>>>> + };
>>>
>>> This example is a bit strange. I don't understand the relationship
>>> between keystone-dwc3 and synopsys,dwc3, nor do I want to. I'd prefer
>>> to see a simple example here.
>
>
>>> dma-ranges is a property of the parent which you show, but
>>> dma-coherent originally was a property of the bus master itself. While
>>> we need to support that, are we changing that? We need to be clear on
>>> where the property belongs even if the kernel is more lax.
>>>
>> I don't think we are changing it fundamentally but may be I missing
>> your point. The dma-coherent as is now a per-device property.
>> USB is one of the bus master supports coherency and hence showed
>> up in above example.
>
> I think it's enough if you just drop the "synopsys,dwc3" node and the
> intermediate dma-ranges property from the example, leaving the
> dma-coherent property in the "ti,keystone-dwc3" node.
>
Thanks Arnd. That should avoid the confusion. Just to see if Rob is
fine by it, the example will look like below.
Example:
soc {
compatible = "ti,keystone","simple-bus";
ranges = <0x0 0x0 0x0 0xc0000000>;
dma-ranges = <0x80000000 0x8 0x00000000 0x80000000>;
[...]
usb: usb@2680000 {
compatible = "ti,keystone-dwc3";
[...]
dma-coherent;
};
};
Regards,
Santosh
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Arnd Bergmann <arnd@arndb.de>, Rob Herring <robherring2@gmail.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Russell King <linux@arm.linux.org.uk>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
linux-kernel <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Kumar Gala <galak@codeaurora.org>,
Grant Likely <grant.likely@linaro.org>,
Fabio Estevam <festevam@gmail.com>,
Shawn Guo <shawn.guo@freescale.com>
Subject: Re: [PATCH] dt/documentation: add specification of dma bus information
Date: Fri, 20 Jun 2014 15:02:43 -0400 [thread overview]
Message-ID: <53A48553.2080504@ti.com> (raw)
In-Reply-To: <4193075.zZSpRTFEYz@wuerfel>
On Friday 20 June 2014 02:56 PM, Arnd Bergmann wrote:
> On Friday 20 June 2014 13:17:43 Santosh Shilimkar wrote:
>>>> + dma-coherent;
>>>> + dma-ranges;
>>>> +
>>>> + dwc3@2690000 {
>>>> + compatible = "synopsys,dwc3";
>>>> + [...]
>>>> + };
>>>
>>> This example is a bit strange. I don't understand the relationship
>>> between keystone-dwc3 and synopsys,dwc3, nor do I want to. I'd prefer
>>> to see a simple example here.
>
>
>>> dma-ranges is a property of the parent which you show, but
>>> dma-coherent originally was a property of the bus master itself. While
>>> we need to support that, are we changing that? We need to be clear on
>>> where the property belongs even if the kernel is more lax.
>>>
>> I don't think we are changing it fundamentally but may be I missing
>> your point. The dma-coherent as is now a per-device property.
>> USB is one of the bus master supports coherency and hence showed
>> up in above example.
>
> I think it's enough if you just drop the "synopsys,dwc3" node and the
> intermediate dma-ranges property from the example, leaving the
> dma-coherent property in the "ti,keystone-dwc3" node.
>
Thanks Arnd. That should avoid the confusion. Just to see if Rob is
fine by it, the example will look like below.
Example:
soc {
compatible = "ti,keystone","simple-bus";
ranges = <0x0 0x0 0x0 0xc0000000>;
dma-ranges = <0x80000000 0x8 0x00000000 0x80000000>;
[...]
usb: usb@2680000 {
compatible = "ti,keystone-dwc3";
[...]
dma-coherent;
};
};
Regards,
Santosh
next prev parent reply other threads:[~2014-06-20 19:02 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 15:22 [PATCH] dt/documentation: add specification of dma bus information Santosh Shilimkar
2014-06-05 15:22 ` Santosh Shilimkar
2014-06-05 15:22 ` Santosh Shilimkar
2014-06-09 2:06 ` Shawn Guo
2014-06-09 2:06 ` Shawn Guo
2014-06-09 2:06 ` Shawn Guo
2014-06-09 2:13 ` Fabio Estevam
2014-06-09 2:13 ` Fabio Estevam
2014-06-09 2:13 ` Fabio Estevam
2014-06-09 13:59 ` Santosh Shilimkar
2014-06-09 13:59 ` Santosh Shilimkar
2014-06-09 13:59 ` Santosh Shilimkar
2014-06-20 15:04 ` Santosh Shilimkar
2014-06-20 15:04 ` Santosh Shilimkar
2014-06-20 15:04 ` Santosh Shilimkar
2014-06-20 15:50 ` Rob Herring
2014-06-20 15:50 ` Rob Herring
2014-06-20 17:17 ` Santosh Shilimkar
2014-06-20 17:17 ` Santosh Shilimkar
2014-06-20 18:56 ` Arnd Bergmann
2014-06-20 18:56 ` Arnd Bergmann
2014-06-20 19:02 ` Santosh Shilimkar [this message]
2014-06-20 19:02 ` Santosh Shilimkar
2014-06-20 19:02 ` Santosh Shilimkar
2014-06-20 19:46 ` Rob Herring
2014-06-20 19:46 ` Rob Herring
2014-06-20 19:46 ` Rob Herring
2014-06-22 19:40 ` Santosh Shilimkar
2014-06-22 19:40 ` Santosh Shilimkar
2014-09-19 18:29 ` Grygorii Strashko
2014-09-19 18:29 ` Grygorii Strashko
2014-09-19 18:29 ` Grygorii Strashko
2014-09-26 16:32 ` Rob Herring
2014-09-26 16:32 ` Rob Herring
2014-09-26 16:32 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A48553.2080504@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.