* Re: [Gitorious] Activity: prabhakar requested a merge of prab... [not found] <53a829dc98811_78d23ff48250bea851769@ratt.gitorious.c.bitbit.net.mail> @ 2014-06-23 16:12 ` Oliver Hartkopp 2014-06-23 16:22 ` Marc Kleine-Budde 0 siblings, 1 reply; 7+ messages in thread From: Oliver Hartkopp @ 2014-06-23 16:12 UTC (permalink / raw) To: prabhakar.csengg; +Cc: linux-can@vger.kernel.org Hi Prabhakar, thanks for your patch. Can you please send it with git send-email to the mailing list for a review? Additionally: Does this patch introduce any backward compatibility restrictions (e.g. you need at least the includes from 2.6.14+ to build candump ...). You only provide to configure a value for SCHED_RR. Does it make sense to provide other scheduling policies too? Regards, Oliver On 23.06.2014 15:21, Gitorious wrote: > > Hello hartkopp, > > One of your favorites has a new activity: > ------------------------------------------------------------------------ > prabhakar requested a merge of prabhakar-can-utils with can-utils. > The merge request is at https://gitorious.org/linux-can/can-utils/merge_requests/2 > ------------------------------------------------------------------------ > > You are receiving this email because you have chosen to be notified by > email whenever this favorite has new activity. You can manage your > favorite subscriptions at https://gitorious.org/favorites > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Gitorious] Activity: prabhakar requested a merge of prab... 2014-06-23 16:12 ` [Gitorious] Activity: prabhakar requested a merge of prab Oliver Hartkopp @ 2014-06-23 16:22 ` Marc Kleine-Budde 2014-06-23 16:30 ` Oliver Hartkopp 0 siblings, 1 reply; 7+ messages in thread From: Marc Kleine-Budde @ 2014-06-23 16:22 UTC (permalink / raw) To: Oliver Hartkopp, prabhakar.csengg; +Cc: linux-can@vger.kernel.org [-- Attachment #1: Type: text/plain, Size: 893 bytes --] On 06/23/2014 06:12 PM, Oliver Hartkopp wrote: > Hi Prabhakar, > > thanks for your patch. > > Can you please send it with git send-email to the mailing list for a review? > > Additionally: > > Does this patch introduce any backward compatibility restrictions (e.g. you > need at least the includes from 2.6.14+ to build candump ...). When was CAN support added to the linux kernel? :) > You only provide to configure a value for SCHED_RR. > Does it make sense to provide other scheduling policies too? I would use chrt to start the tool, if I need non standard scheduling policies. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 242 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Gitorious] Activity: prabhakar requested a merge of prab... 2014-06-23 16:22 ` Marc Kleine-Budde @ 2014-06-23 16:30 ` Oliver Hartkopp 2014-06-23 16:46 ` Marc Kleine-Budde 0 siblings, 1 reply; 7+ messages in thread From: Oliver Hartkopp @ 2014-06-23 16:30 UTC (permalink / raw) To: Marc Kleine-Budde, prabhakar.csengg; +Cc: linux-can@vger.kernel.org On 23.06.2014 18:22, Marc Kleine-Budde wrote: > On 06/23/2014 06:12 PM, Oliver Hartkopp wrote: >> Hi Prabhakar, >> >> thanks for your patch. >> >> Can you please send it with git send-email to the mailing list for a review? >> >> Additionally: >> >> Does this patch introduce any backward compatibility restrictions (e.g. you >> need at least the includes from 2.6.14+ to build candump ...). > > When was CAN support added to the linux kernel? :) I know that you would detect this joke ;-) Btw. I backported SocketCAN to 2.6.13 - so my question is not totally brain-damaged when talking about the can-utils which are not sticking to a specific kernel version. > >> You only provide to configure a value for SCHED_RR. >> Does it make sense to provide other scheduling policies too? > > I would use chrt to start the tool, if I need non standard scheduling > policies. But then you would like to specifiy the scheduling policy?? Regards, Oliver ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Gitorious] Activity: prabhakar requested a merge of prab... 2014-06-23 16:30 ` Oliver Hartkopp @ 2014-06-23 16:46 ` Marc Kleine-Budde 2014-06-24 11:06 ` Prabhakar Lad 0 siblings, 1 reply; 7+ messages in thread From: Marc Kleine-Budde @ 2014-06-23 16:46 UTC (permalink / raw) To: Oliver Hartkopp, prabhakar.csengg; +Cc: linux-can@vger.kernel.org [-- Attachment #1: Type: text/plain, Size: 1701 bytes --] On 06/23/2014 06:30 PM, Oliver Hartkopp wrote: > On 23.06.2014 18:22, Marc Kleine-Budde wrote: >> On 06/23/2014 06:12 PM, Oliver Hartkopp wrote: >>> Hi Prabhakar, >>> >>> thanks for your patch. >>> >>> Can you please send it with git send-email to the mailing list for a review? >>> >>> Additionally: >>> >>> Does this patch introduce any backward compatibility restrictions (e.g. you >>> need at least the includes from 2.6.14+ to build candump ...). >> >> When was CAN support added to the linux kernel? :) > > I know that you would detect this joke ;-) > Btw. I backported SocketCAN to 2.6.13 - so my question is not totally > brain-damaged when talking about the can-utils which are not sticking to a > specific kernel version. I was assuming that there was a certain seriousness in your statement :D Do you mean the inclusion of "sched.h"? I think this comes from the glibc. However, we can add autotool support to detect this. >>> You only provide to configure a value for SCHED_RR. >>> Does it make sense to provide other scheduling policies too? >> >> I would use chrt to start the tool, if I need non standard scheduling >> policies. > > But then you would like to specifiy the scheduling policy?? You can use chrt to start another program with different scheduling policies, it's like nice, but with more functionality. See man page of chrt for more information. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 242 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Gitorious] Activity: prabhakar requested a merge of prab... 2014-06-23 16:46 ` Marc Kleine-Budde @ 2014-06-24 11:06 ` Prabhakar Lad 2014-06-24 11:11 ` Marc Kleine-Budde 0 siblings, 1 reply; 7+ messages in thread From: Prabhakar Lad @ 2014-06-24 11:06 UTC (permalink / raw) To: Marc Kleine-Budde; +Cc: Oliver Hartkopp, linux-can@vger.kernel.org Hi On Mon, Jun 23, 2014 at 5:46 PM, Marc Kleine-Budde <mkl@pengutronix.de> wrote: > On 06/23/2014 06:30 PM, Oliver Hartkopp wrote: >> On 23.06.2014 18:22, Marc Kleine-Budde wrote: >>> On 06/23/2014 06:12 PM, Oliver Hartkopp wrote: >>>> Hi Prabhakar, >>>> >>>> thanks for your patch. >>>> >>>> Can you please send it with git send-email to the mailing list for a review? >>>> >>>> Additionally: >>>> >>>> Does this patch introduce any backward compatibility restrictions (e.g. you >>>> need at least the includes from 2.6.14+ to build candump ...). >>> >>> When was CAN support added to the linux kernel? :) >> >> I know that you would detect this joke ;-) >> Btw. I backported SocketCAN to 2.6.13 - so my question is not totally >> brain-damaged when talking about the can-utils which are not sticking to a >> specific kernel version. > > I was assuming that there was a certain seriousness in your statement :D > > Do you mean the inclusion of "sched.h"? I think this comes from the > glibc. However, we can add autotool support to detect this. > >>>> You only provide to configure a value for SCHED_RR. >>>> Does it make sense to provide other scheduling policies too? >>> >>> I would use chrt to start the tool, if I need non standard scheduling >>> policies. >> >> But then you would like to specifiy the scheduling policy?? > > You can use chrt to start another program with different scheduling > policies, it's like nice, but with more functionality. See man page of > chrt for more information. > What do you suggest to go with the patch or just use chrt ? Regards, --Prabhakar ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Gitorious] Activity: prabhakar requested a merge of prab... 2014-06-24 11:06 ` Prabhakar Lad @ 2014-06-24 11:11 ` Marc Kleine-Budde 2014-06-24 13:50 ` Prabhakar Lad 0 siblings, 1 reply; 7+ messages in thread From: Marc Kleine-Budde @ 2014-06-24 11:11 UTC (permalink / raw) To: Prabhakar Lad; +Cc: Oliver Hartkopp, linux-can@vger.kernel.org [-- Attachment #1: Type: text/plain, Size: 2139 bytes --] On 06/24/2014 01:06 PM, Prabhakar Lad wrote: > Hi > > On Mon, Jun 23, 2014 at 5:46 PM, Marc Kleine-Budde <mkl@pengutronix.de> wrote: >> On 06/23/2014 06:30 PM, Oliver Hartkopp wrote: >>> On 23.06.2014 18:22, Marc Kleine-Budde wrote: >>>> On 06/23/2014 06:12 PM, Oliver Hartkopp wrote: >>>>> Hi Prabhakar, >>>>> >>>>> thanks for your patch. >>>>> >>>>> Can you please send it with git send-email to the mailing list for a review? >>>>> >>>>> Additionally: >>>>> >>>>> Does this patch introduce any backward compatibility restrictions (e.g. you >>>>> need at least the includes from 2.6.14+ to build candump ...). >>>> >>>> When was CAN support added to the linux kernel? :) >>> >>> I know that you would detect this joke ;-) >>> Btw. I backported SocketCAN to 2.6.13 - so my question is not totally >>> brain-damaged when talking about the can-utils which are not sticking to a >>> specific kernel version. >> >> I was assuming that there was a certain seriousness in your statement :D >> >> Do you mean the inclusion of "sched.h"? I think this comes from the >> glibc. However, we can add autotool support to detect this. >> >>>>> You only provide to configure a value for SCHED_RR. >>>>> Does it make sense to provide other scheduling policies too? >>>> >>>> I would use chrt to start the tool, if I need non standard scheduling >>>> policies. >>> >>> But then you would like to specifiy the scheduling policy?? >> >> You can use chrt to start another program with different scheduling >> policies, it's like nice, but with more functionality. See man page of >> chrt for more information. >> > What do you suggest to go with the patch or just use chrt ? From my point of view candump is a debugging tool anyways, using it together with chrt makes sense. Do you have a good argument why not to use chrt? Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 242 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Gitorious] Activity: prabhakar requested a merge of prab... 2014-06-24 11:11 ` Marc Kleine-Budde @ 2014-06-24 13:50 ` Prabhakar Lad 0 siblings, 0 replies; 7+ messages in thread From: Prabhakar Lad @ 2014-06-24 13:50 UTC (permalink / raw) To: Marc Kleine-Budde; +Cc: Oliver Hartkopp, linux-can@vger.kernel.org On Tue, Jun 24, 2014 at 12:11 PM, Marc Kleine-Budde <mkl@pengutronix.de> wrote: > On 06/24/2014 01:06 PM, Prabhakar Lad wrote: >> Hi >> >> On Mon, Jun 23, 2014 at 5:46 PM, Marc Kleine-Budde <mkl@pengutronix.de> wrote: >>> On 06/23/2014 06:30 PM, Oliver Hartkopp wrote: >>>> On 23.06.2014 18:22, Marc Kleine-Budde wrote: >>>>> On 06/23/2014 06:12 PM, Oliver Hartkopp wrote: >>>>>> Hi Prabhakar, >>>>>> >>>>>> thanks for your patch. >>>>>> >>>>>> Can you please send it with git send-email to the mailing list for a review? >>>>>> >>>>>> Additionally: >>>>>> >>>>>> Does this patch introduce any backward compatibility restrictions (e.g. you >>>>>> need at least the includes from 2.6.14+ to build candump ...). >>>>> >>>>> When was CAN support added to the linux kernel? :) >>>> >>>> I know that you would detect this joke ;-) >>>> Btw. I backported SocketCAN to 2.6.13 - so my question is not totally >>>> brain-damaged when talking about the can-utils which are not sticking to a >>>> specific kernel version. >>> >>> I was assuming that there was a certain seriousness in your statement :D >>> >>> Do you mean the inclusion of "sched.h"? I think this comes from the >>> glibc. However, we can add autotool support to detect this. >>> >>>>>> You only provide to configure a value for SCHED_RR. >>>>>> Does it make sense to provide other scheduling policies too? >>>>> >>>>> I would use chrt to start the tool, if I need non standard scheduling >>>>> policies. >>>> >>>> But then you would like to specifiy the scheduling policy?? >>> >>> You can use chrt to start another program with different scheduling >>> policies, it's like nice, but with more functionality. See man page of >>> chrt for more information. >>> >> What do you suggest to go with the patch or just use chrt ? > > From my point of view candump is a debugging tool anyways, using it > together with chrt makes sense. Do you have a good argument why not to > use chrt? > Yea that's fine with me using chrt :), So Ill drop the patch instead. Thanks, --Prabhakar Lad > Marc > > -- > Pengutronix e.K. | Marc Kleine-Budde | > Industrial Linux Solutions | Phone: +49-231-2826-924 | > Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | > Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | > ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-06-24 13:50 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <53a829dc98811_78d23ff48250bea851769@ratt.gitorious.c.bitbit.net.mail>
2014-06-23 16:12 ` [Gitorious] Activity: prabhakar requested a merge of prab Oliver Hartkopp
2014-06-23 16:22 ` Marc Kleine-Budde
2014-06-23 16:30 ` Oliver Hartkopp
2014-06-23 16:46 ` Marc Kleine-Budde
2014-06-24 11:06 ` Prabhakar Lad
2014-06-24 11:11 ` Marc Kleine-Budde
2014-06-24 13:50 ` Prabhakar Lad
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.