All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Qiaowei Ren <qiaowei.ren@intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, X86 ML <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Linux MM <linux-mm@kvack.org>
Subject: Re: [PATCH v6 02/10] x86, mpx: add MPX specific mmap interface
Date: Mon, 23 Jun 2014 13:28:20 -0700	[thread overview]
Message-ID: <53A88DE4.8050107@intel.com> (raw)
In-Reply-To: <CALCETrXYZZiZsDiUvvZd0636+qHP9a0sHTN6wt_ZKjvLaeeBzw@mail.gmail.com>

On 06/23/2014 01:06 PM, Andy Lutomirski wrote:
> Can the new vm_operation "name" be use for this?  The magic "always
> written to core dumps" feature might need to be reconsidered.

One thing I'd like to avoid is an MPX vma getting merged with a non-MPX
vma.  I don't see any code to prevent two VMAs with different
vm_ops->names from getting merged.  That seems like a bit of a design
oversight for ->name.  Right?

Thinking out loud a bit... There are also some more complicated but more
performant cleanup mechanisms that I'd like to go after in the future.
Given a page, we might want to figure out if it is an MPX page or not.
I wonder if we'll ever collide with some other user of vm_ops->name.  It
looks fairly narrowly used at the moment, but would this keep us from
putting these pages on, say, a tmpfs mount?  Doesn't look that way at
the moment.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@intel.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Qiaowei Ren <qiaowei.ren@intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, X86 ML <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Linux MM <linux-mm@kvack.org>
Subject: Re: [PATCH v6 02/10] x86, mpx: add MPX specific mmap interface
Date: Mon, 23 Jun 2014 13:28:20 -0700	[thread overview]
Message-ID: <53A88DE4.8050107@intel.com> (raw)
In-Reply-To: <CALCETrXYZZiZsDiUvvZd0636+qHP9a0sHTN6wt_ZKjvLaeeBzw@mail.gmail.com>

On 06/23/2014 01:06 PM, Andy Lutomirski wrote:
> Can the new vm_operation "name" be use for this?  The magic "always
> written to core dumps" feature might need to be reconsidered.

One thing I'd like to avoid is an MPX vma getting merged with a non-MPX
vma.  I don't see any code to prevent two VMAs with different
vm_ops->names from getting merged.  That seems like a bit of a design
oversight for ->name.  Right?

Thinking out loud a bit... There are also some more complicated but more
performant cleanup mechanisms that I'd like to go after in the future.
Given a page, we might want to figure out if it is an MPX page or not.
I wonder if we'll ever collide with some other user of vm_ops->name.  It
looks fairly narrowly used at the moment, but would this keep us from
putting these pages on, say, a tmpfs mount?  Doesn't look that way at
the moment.

  reply	other threads:[~2014-06-23 20:28 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-18  9:44 [PATCH v6 00/10] Intel MPX support Qiaowei Ren
2014-06-18  9:44 ` [PATCH v6 01/10] x86, mpx: introduce VM_MPX to indicate that a VMA is MPX specific Qiaowei Ren
2014-06-18  9:44 ` [PATCH v6 02/10] x86, mpx: add MPX specific mmap interface Qiaowei Ren
2014-06-23 19:49   ` Andy Lutomirski
2014-06-23 19:49     ` Andy Lutomirski
2014-06-23 20:03     ` Dave Hansen
2014-06-23 20:03       ` Dave Hansen
2014-06-23 20:06       ` Andy Lutomirski
2014-06-23 20:06         ` Andy Lutomirski
2014-06-23 20:28         ` Dave Hansen [this message]
2014-06-23 20:28           ` Dave Hansen
2014-06-23 21:04           ` Andy Lutomirski
2014-06-23 21:04             ` Andy Lutomirski
2014-06-24  5:53             ` Ren, Qiaowei
2014-06-24  5:53               ` Ren, Qiaowei
2014-06-24 23:55               ` Andy Lutomirski
2014-06-24 23:55                 ` Andy Lutomirski
2014-06-25  1:40                 ` Ren, Qiaowei
2014-06-25  1:40                   ` Ren, Qiaowei
2014-06-25 21:04                   ` Andy Lutomirski
2014-06-25 21:04                     ` Andy Lutomirski
2014-06-25 21:05                     ` Andy Lutomirski
2014-06-25 21:05                       ` Andy Lutomirski
2014-06-25 21:45                       ` Dave Hansen
2014-06-25 21:45                         ` Dave Hansen
2014-06-26 22:19                         ` Andy Lutomirski
2014-06-26 22:19                           ` Andy Lutomirski
2014-06-26 22:58                           ` Dave Hansen
2014-06-26 22:58                             ` Dave Hansen
2014-06-26 23:15                             ` Andy Lutomirski
2014-06-26 23:15                               ` Andy Lutomirski
2014-06-27  0:19                               ` Dave Hansen
2014-06-27  0:19                                 ` Dave Hansen
2014-06-27  0:26                                 ` Andy Lutomirski
2014-06-27  0:26                                   ` Andy Lutomirski
2014-06-27 17:34                                   ` Dave Hansen
2014-06-27 17:34                                     ` Dave Hansen
2014-06-27 17:42                                     ` Dave Hansen
2014-06-27 17:42                                       ` Dave Hansen
2014-06-27 18:57                                       ` Andy Lutomirski
2014-06-27 18:57                                         ` Andy Lutomirski
2014-06-25 21:43                     ` Dave Hansen
2014-06-25 21:43                       ` Dave Hansen
2014-06-24  2:53     ` Ren, Qiaowei
2014-06-24  2:53       ` Ren, Qiaowei
2014-06-18  9:44 ` [PATCH v6 03/10] x86, mpx: add macro cpu_has_mpx Qiaowei Ren
2014-06-18  9:57   ` Borislav Petkov
2014-06-18 14:35     ` Dave Hansen
2014-06-18 14:44       ` Borislav Petkov
2014-06-18 14:58         ` Dave Hansen
2014-06-18 15:25           ` Borislav Petkov
2014-06-18 16:17             ` Dave Hansen
2014-06-18 15:00         ` H. Peter Anvin
2014-06-18 15:27           ` Borislav Petkov
2014-06-18 14:59       ` H. Peter Anvin
2014-06-18 16:25         ` Dave Hansen
2014-06-18 17:21           ` Borislav Petkov
2014-06-19 18:02           ` H. Peter Anvin
2014-06-19 18:50             ` Dave Hansen
2014-06-20  3:28               ` H. Peter Anvin
2014-06-18  9:44 ` [PATCH v6 04/10] x86, mpx: hook #BR exception handler to allocate bound tables Qiaowei Ren
2014-06-23 19:54   ` Andy Lutomirski
2014-06-24  1:53     ` Ren, Qiaowei
2014-07-11 16:23   ` Dave Hansen
2014-06-18  9:44 ` [PATCH v6 05/10] x86, mpx: extend siginfo structure to include bound violation information Qiaowei Ren
2014-06-18  9:44 ` [PATCH v6 06/10] mips: sync struct siginfo with general version Qiaowei Ren
2014-06-18  9:44 ` [PATCH v6 07/10] x86, mpx: decode MPX instruction to get bound violation information Qiaowei Ren
2014-06-18 10:07   ` Borislav Petkov
2014-06-19  1:13     ` Ren, Qiaowei
2014-06-19  6:28       ` Borislav Petkov
2014-06-19  6:53         ` Ren, Qiaowei
2014-06-19 17:04           ` Dave Hansen
2014-06-19 17:32             ` H. Peter Anvin
2014-06-20  3:21               ` Ren, Qiaowei
2014-06-18  9:44 ` [PATCH v6 08/10] x86, mpx: add prctl commands PR_MPX_REGISTER, PR_MPX_UNREGISTER Qiaowei Ren
2014-06-19 20:58   ` Dave Hansen
2014-06-23 20:00   ` Andy Lutomirski
2014-06-23 20:09     ` Dave Hansen
2014-06-23 22:00       ` Andy Lutomirski
2014-06-23 23:42         ` Dave Hansen
2014-06-24  0:01           ` Andy Lutomirski
2014-06-24  0:10             ` Dave Hansen
2014-06-18  9:44 ` [PATCH v6 09/10] x86, mpx: cleanup unused bound tables Qiaowei Ren
2014-06-23 19:57   ` Andy Lutomirski
2014-06-18  9:44 ` [PATCH v6 10/10] x86, mpx: add documentation on Intel MPX Qiaowei Ren
2014-06-18 14:41 ` [PATCH v6 00/10] Intel MPX support Dave Hansen
2014-06-18 14:41   ` Dave Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A88DE4.8050107@intel.com \
    --to=dave.hansen@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=luto@amacapital.net \
    --cc=mingo@redhat.com \
    --cc=qiaowei.ren@intel.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.