From: Dave Hansen <dave.hansen@intel.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: "Ren, Qiaowei" <qiaowei.ren@intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, X86 ML <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>
Subject: Re: [PATCH v6 02/10] x86, mpx: add MPX specific mmap interface
Date: Thu, 26 Jun 2014 15:58:59 -0700 [thread overview]
Message-ID: <53ACA5B3.3010702@intel.com> (raw)
In-Reply-To: <CALCETrVTTh9yuXH0hfcOpytyBd25K6thPfqqUBQtnOqx90ZRqw@mail.gmail.com>
On 06/26/2014 03:19 PM, Andy Lutomirski wrote:
> On Wed, Jun 25, 2014 at 2:45 PM, Dave Hansen <dave.hansen@intel.com> wrote:
>> On 06/25/2014 02:05 PM, Andy Lutomirski wrote:
>>> Hmm. the memfd_create thing may be able to do this for you. If you
>>> created a per-mm memfd and mapped it, it all just might work.
>>
>> memfd_create() seems to bring a fair amount of baggage along (the fd
>> part :) if all we want is a marker. Really, all we need is _a_ bit, and
>> some way to plumb to userspace the RSS values of VMAs with that bit set.
>>
>> Creating and mmap()'ing a fd seems a rather roundabout way to get there.
>
> Hmm. So does VM_MPX, though. If this stuff were done entirely in
> userspace, then memfd_create would be exactly the right solution, I
> think.
>
> Would it work to just scan the bound directory to figure out how many
> bound tables exist?
Theoretically, perhaps.
Practically, the bounds directory is 2GB, and it is likely to be very
sparse. You would have to walk the page tables finding where pages were
mapped, then search the mapped pages for bounds table entries.
Assuming that it was aligned and minimally populated, that's a *MINIMUM*
search looking for a PGD entry, then you have to look at 512 PUD
entries. A full search would have to look at half a million ptes.
That's just finding out how sparse the first level of the tables are
before you've looked at a byte of actual data, and if they were empty.
We could keep another, parallel, data structure that handles this better
other than the hardware tables. Like, say, an rbtree that stores ranges
of virtual addresses. We could call them vm_area_somethings ... wait a
sec... we have a structure like that. ;)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@intel.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: "Ren, Qiaowei" <qiaowei.ren@intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, X86 ML <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>
Subject: Re: [PATCH v6 02/10] x86, mpx: add MPX specific mmap interface
Date: Thu, 26 Jun 2014 15:58:59 -0700 [thread overview]
Message-ID: <53ACA5B3.3010702@intel.com> (raw)
In-Reply-To: <CALCETrVTTh9yuXH0hfcOpytyBd25K6thPfqqUBQtnOqx90ZRqw@mail.gmail.com>
On 06/26/2014 03:19 PM, Andy Lutomirski wrote:
> On Wed, Jun 25, 2014 at 2:45 PM, Dave Hansen <dave.hansen@intel.com> wrote:
>> On 06/25/2014 02:05 PM, Andy Lutomirski wrote:
>>> Hmm. the memfd_create thing may be able to do this for you. If you
>>> created a per-mm memfd and mapped it, it all just might work.
>>
>> memfd_create() seems to bring a fair amount of baggage along (the fd
>> part :) if all we want is a marker. Really, all we need is _a_ bit, and
>> some way to plumb to userspace the RSS values of VMAs with that bit set.
>>
>> Creating and mmap()'ing a fd seems a rather roundabout way to get there.
>
> Hmm. So does VM_MPX, though. If this stuff were done entirely in
> userspace, then memfd_create would be exactly the right solution, I
> think.
>
> Would it work to just scan the bound directory to figure out how many
> bound tables exist?
Theoretically, perhaps.
Practically, the bounds directory is 2GB, and it is likely to be very
sparse. You would have to walk the page tables finding where pages were
mapped, then search the mapped pages for bounds table entries.
Assuming that it was aligned and minimally populated, that's a *MINIMUM*
search looking for a PGD entry, then you have to look at 512 PUD
entries. A full search would have to look at half a million ptes.
That's just finding out how sparse the first level of the tables are
before you've looked at a byte of actual data, and if they were empty.
We could keep another, parallel, data structure that handles this better
other than the hardware tables. Like, say, an rbtree that stores ranges
of virtual addresses. We could call them vm_area_somethings ... wait a
sec... we have a structure like that. ;)
next prev parent reply other threads:[~2014-06-26 22:59 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 9:44 [PATCH v6 00/10] Intel MPX support Qiaowei Ren
2014-06-18 9:44 ` [PATCH v6 01/10] x86, mpx: introduce VM_MPX to indicate that a VMA is MPX specific Qiaowei Ren
2014-06-18 9:44 ` [PATCH v6 02/10] x86, mpx: add MPX specific mmap interface Qiaowei Ren
2014-06-23 19:49 ` Andy Lutomirski
2014-06-23 19:49 ` Andy Lutomirski
2014-06-23 20:03 ` Dave Hansen
2014-06-23 20:03 ` Dave Hansen
2014-06-23 20:06 ` Andy Lutomirski
2014-06-23 20:06 ` Andy Lutomirski
2014-06-23 20:28 ` Dave Hansen
2014-06-23 20:28 ` Dave Hansen
2014-06-23 21:04 ` Andy Lutomirski
2014-06-23 21:04 ` Andy Lutomirski
2014-06-24 5:53 ` Ren, Qiaowei
2014-06-24 5:53 ` Ren, Qiaowei
2014-06-24 23:55 ` Andy Lutomirski
2014-06-24 23:55 ` Andy Lutomirski
2014-06-25 1:40 ` Ren, Qiaowei
2014-06-25 1:40 ` Ren, Qiaowei
2014-06-25 21:04 ` Andy Lutomirski
2014-06-25 21:04 ` Andy Lutomirski
2014-06-25 21:05 ` Andy Lutomirski
2014-06-25 21:05 ` Andy Lutomirski
2014-06-25 21:45 ` Dave Hansen
2014-06-25 21:45 ` Dave Hansen
2014-06-26 22:19 ` Andy Lutomirski
2014-06-26 22:19 ` Andy Lutomirski
2014-06-26 22:58 ` Dave Hansen [this message]
2014-06-26 22:58 ` Dave Hansen
2014-06-26 23:15 ` Andy Lutomirski
2014-06-26 23:15 ` Andy Lutomirski
2014-06-27 0:19 ` Dave Hansen
2014-06-27 0:19 ` Dave Hansen
2014-06-27 0:26 ` Andy Lutomirski
2014-06-27 0:26 ` Andy Lutomirski
2014-06-27 17:34 ` Dave Hansen
2014-06-27 17:34 ` Dave Hansen
2014-06-27 17:42 ` Dave Hansen
2014-06-27 17:42 ` Dave Hansen
2014-06-27 18:57 ` Andy Lutomirski
2014-06-27 18:57 ` Andy Lutomirski
2014-06-25 21:43 ` Dave Hansen
2014-06-25 21:43 ` Dave Hansen
2014-06-24 2:53 ` Ren, Qiaowei
2014-06-24 2:53 ` Ren, Qiaowei
2014-06-18 9:44 ` [PATCH v6 03/10] x86, mpx: add macro cpu_has_mpx Qiaowei Ren
2014-06-18 9:57 ` Borislav Petkov
2014-06-18 14:35 ` Dave Hansen
2014-06-18 14:44 ` Borislav Petkov
2014-06-18 14:58 ` Dave Hansen
2014-06-18 15:25 ` Borislav Petkov
2014-06-18 16:17 ` Dave Hansen
2014-06-18 15:00 ` H. Peter Anvin
2014-06-18 15:27 ` Borislav Petkov
2014-06-18 14:59 ` H. Peter Anvin
2014-06-18 16:25 ` Dave Hansen
2014-06-18 17:21 ` Borislav Petkov
2014-06-19 18:02 ` H. Peter Anvin
2014-06-19 18:50 ` Dave Hansen
2014-06-20 3:28 ` H. Peter Anvin
2014-06-18 9:44 ` [PATCH v6 04/10] x86, mpx: hook #BR exception handler to allocate bound tables Qiaowei Ren
2014-06-23 19:54 ` Andy Lutomirski
2014-06-24 1:53 ` Ren, Qiaowei
2014-07-11 16:23 ` Dave Hansen
2014-06-18 9:44 ` [PATCH v6 05/10] x86, mpx: extend siginfo structure to include bound violation information Qiaowei Ren
2014-06-18 9:44 ` [PATCH v6 06/10] mips: sync struct siginfo with general version Qiaowei Ren
2014-06-18 9:44 ` [PATCH v6 07/10] x86, mpx: decode MPX instruction to get bound violation information Qiaowei Ren
2014-06-18 10:07 ` Borislav Petkov
2014-06-19 1:13 ` Ren, Qiaowei
2014-06-19 6:28 ` Borislav Petkov
2014-06-19 6:53 ` Ren, Qiaowei
2014-06-19 17:04 ` Dave Hansen
2014-06-19 17:32 ` H. Peter Anvin
2014-06-20 3:21 ` Ren, Qiaowei
2014-06-18 9:44 ` [PATCH v6 08/10] x86, mpx: add prctl commands PR_MPX_REGISTER, PR_MPX_UNREGISTER Qiaowei Ren
2014-06-19 20:58 ` Dave Hansen
2014-06-23 20:00 ` Andy Lutomirski
2014-06-23 20:09 ` Dave Hansen
2014-06-23 22:00 ` Andy Lutomirski
2014-06-23 23:42 ` Dave Hansen
2014-06-24 0:01 ` Andy Lutomirski
2014-06-24 0:10 ` Dave Hansen
2014-06-18 9:44 ` [PATCH v6 09/10] x86, mpx: cleanup unused bound tables Qiaowei Ren
2014-06-23 19:57 ` Andy Lutomirski
2014-06-18 9:44 ` [PATCH v6 10/10] x86, mpx: add documentation on Intel MPX Qiaowei Ren
2014-06-18 14:41 ` [PATCH v6 00/10] Intel MPX support Dave Hansen
2014-06-18 14:41 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53ACA5B3.3010702@intel.com \
--to=dave.hansen@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=qiaowei.ren@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.