All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	linux-media@vger.kernel.org
Cc: linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 07/23] v4l: vsp1: Release buffers at stream stop
Date: Tue, 24 Jun 2014 12:00:45 +0000	[thread overview]
Message-ID: <53A9686D.5040508@cogentembedded.com> (raw)
In-Reply-To: <1403567669-18539-8-git-send-email-laurent.pinchart+renesas@ideasonboard.com>

Hello.

On 06/24/2014 03:54 AM, Laurent Pinchart wrote:

> videobuf2 expects no buffer to be owned by the driver when the
> stop_stream queue operation returns. As the vsp1 driver fails to do so,
> a warning is generated at stream top time.

> Fix this by mark releasing all buffers queued on the IRQ queue in the

    Mark releasing?

> stop_stream operation handler and marking them as erroneous.

> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

WBR, Sergei


WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	linux-media@vger.kernel.org
Cc: linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 07/23] v4l: vsp1: Release buffers at stream stop
Date: Tue, 24 Jun 2014 16:00:45 +0400	[thread overview]
Message-ID: <53A9686D.5040508@cogentembedded.com> (raw)
In-Reply-To: <1403567669-18539-8-git-send-email-laurent.pinchart+renesas@ideasonboard.com>

Hello.

On 06/24/2014 03:54 AM, Laurent Pinchart wrote:

> videobuf2 expects no buffer to be owned by the driver when the
> stop_stream queue operation returns. As the vsp1 driver fails to do so,
> a warning is generated at stream top time.

> Fix this by mark releasing all buffers queued on the IRQ queue in the

    Mark releasing?

> stop_stream operation handler and marking them as erroneous.

> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

WBR, Sergei


  reply	other threads:[~2014-06-24 12:00 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-23 23:54 [PATCH v2 00/23] Renesas VSP1: alpha support and miscellaneous fixes Laurent Pinchart
2014-06-23 23:54 ` Laurent Pinchart
2014-06-23 23:54 ` [PATCH v2 01/23] v4l: Add ARGB and XRGB pixel formats Laurent Pinchart
2014-06-23 23:54   ` Laurent Pinchart
2014-06-27  9:34   ` Hans Verkuil
2014-06-27  9:34     ` Hans Verkuil
2014-07-17 21:53   ` Hans Verkuil
2014-07-17 21:53     ` Hans Verkuil
2014-07-18 12:31     ` Laurent Pinchart
2014-07-18 12:31       ` Laurent Pinchart
2014-07-18 13:14       ` Hans Verkuil
2014-07-18 13:14         ` Hans Verkuil
2014-07-18 13:21         ` Hans Verkuil
2014-07-18 13:21           ` Hans Verkuil
2014-06-23 23:54 ` [PATCH v2 02/23] DocBook: media: Document ALPHA_COMPONENT control usage on output devices Laurent Pinchart
2014-06-23 23:54   ` Laurent Pinchart
2014-06-27  9:34   ` Hans Verkuil
2014-06-27  9:34     ` Hans Verkuil
2014-06-23 23:54 ` [PATCH v2 03/23] v4l: Support extending the v4l2_pix_format structure Laurent Pinchart
2014-06-23 23:54   ` Laurent Pinchart
2014-06-27 12:36   ` Hans Verkuil
2014-06-27 12:36     ` Hans Verkuil
2014-06-29 20:41     ` Laurent Pinchart
2014-06-29 20:41       ` Laurent Pinchart
2014-07-17 21:04   ` Hans Verkuil
2014-07-17 21:04     ` Hans Verkuil
2014-07-21 20:56     ` Laurent Pinchart
2014-07-21 20:56       ` Laurent Pinchart
2014-07-21 22:17       ` Hans Verkuil
2014-07-21 22:17         ` Hans Verkuil
2014-07-17 21:22   ` Hans Verkuil
2014-07-17 21:22     ` Hans Verkuil
2014-07-18  5:10     ` Hans Verkuil
2014-07-18  5:10       ` Hans Verkuil
2014-07-18 12:27       ` Laurent Pinchart
2014-07-18 12:27         ` Laurent Pinchart
2014-07-18 13:12         ` Hans Verkuil
2014-07-18 13:12           ` Hans Verkuil
2014-06-23 23:54 ` [PATCH v2 04/23] v4l: Add premultiplied alpha flag for pixel formats Laurent Pinchart
2014-06-23 23:54   ` Laurent Pinchart
2014-06-27 12:39   ` Hans Verkuil
2014-06-27 12:39     ` Hans Verkuil
2014-06-23 23:54 ` [PATCH v2 05/23] v4l: vb2: Fix stream start and buffer completion race Laurent Pinchart
2014-06-23 23:54   ` Laurent Pinchart
2014-06-24 10:25   ` Hans Verkuil
2014-06-24 10:25     ` Hans Verkuil
2014-06-23 23:54 ` [PATCH v2 06/23] v4l: vsp1: Fix routing cleanup when stopping the stream Laurent Pinchart
2014-06-23 23:54   ` Laurent Pinchart
2014-06-23 23:54 ` [PATCH v2 07/23] v4l: vsp1: Release buffers at stream stop Laurent Pinchart
2014-06-23 23:54   ` Laurent Pinchart
2014-06-24 12:00   ` Sergei Shtylyov [this message]
2014-06-24 12:00     ` Sergei Shtylyov
2014-07-01  7:16     ` Laurent Pinchart
2014-07-01  7:16       ` Laurent Pinchart
2014-06-23 23:54 ` [PATCH v2 08/23] v4l: vsp1: Fix pipeline stop timeout Laurent Pinchart
2014-06-23 23:54   ` Laurent Pinchart
2014-06-23 23:54 ` [PATCH v2 09/23] v4l: vsp1: Fix typos Laurent Pinchart
2014-06-23 23:54   ` Laurent Pinchart
2014-06-23 23:54 ` [PATCH v2 10/23] v4l: vsp1: Cleanup video nodes at removal time Laurent Pinchart
2014-06-23 23:54   ` Laurent Pinchart
2014-06-23 23:54 ` [PATCH v2 11/23] v4l: vsp1: Propagate vsp1_device_get errors to the callers Laurent Pinchart
2014-06-23 23:54   ` Laurent Pinchart
2014-06-23 23:54 ` [PATCH v2 12/23] v4l: vsp1: Setup control handler automatically at stream on time Laurent Pinchart
2014-06-23 23:54   ` Laurent Pinchart
2014-06-23 23:54 ` [PATCH v2 13/23] v4l: vsp1: sru: Fix the intensity control default value Laurent Pinchart
2014-06-23 23:54   ` Laurent Pinchart
2014-06-23 23:54 ` [PATCH v2 14/23] v4l: vsp1: sru: Make the intensity controllable during streaming Laurent Pinchart
2014-06-23 23:54   ` Laurent Pinchart
2014-06-23 23:54 ` [PATCH v2 15/23] v4l: vsp1: wpf: Simplify cast to pipeline structure Laurent Pinchart
2014-06-23 23:54   ` Laurent Pinchart
2014-06-23 23:54 ` [PATCH v2 16/23] v4l: vsp1: wpf: Clear RPF to WPF association at stream off time Laurent Pinchart
2014-06-23 23:54   ` Laurent Pinchart
2014-06-23 23:54 ` [PATCH v2 17/23] v4l: vsp1: Switch to XRGB formats Laurent Pinchart
2014-06-23 23:54   ` Laurent Pinchart
2014-06-23 23:54 ` [PATCH v2 18/23] v4l: vsp1: Add alpha channel support to the memory ports Laurent Pinchart
2014-06-23 23:54   ` Laurent Pinchart
2014-06-23 23:54 ` [PATCH v2 19/23] v4l: vsp1: Add V4L2_CID_ALPHA_COMPONENT control support Laurent Pinchart
2014-06-23 23:54   ` Laurent Pinchart
2014-06-23 23:54 ` [PATCH v2 20/23] v4l: vsp1: bru: Support premultiplied alpha at the BRU inputs Laurent Pinchart
2014-06-23 23:54   ` Laurent Pinchart
2014-06-23 23:54 ` [PATCH v2 21/23] v4l: vsp1: bru: Support non-premultiplied colors at the BRU output Laurent Pinchart
2014-06-23 23:54   ` Laurent Pinchart
2014-06-23 23:54 ` [PATCH v2 22/23] v4l: vsp1: bru: Make the background color configurable Laurent Pinchart
2014-06-23 23:54   ` Laurent Pinchart
2014-06-23 23:54 ` [PATCH v2 23/23] v4l: vsp1: uds: Fix scaling of alpha layer Laurent Pinchart
2014-06-23 23:54   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A9686D.5040508@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.