All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 1/2] ARM: shmobile: r8a7790: add internal PCI bridge nodes
Date: Thu, 26 Jun 2014 03:37:37 +0000	[thread overview]
Message-ID: <53AB9581.7090806@renesas.com> (raw)
In-Reply-To: <CANqRtoSsx+NAz2W_utN-A2fx+=e_Ywt5eD=Tf9uGnEDvk3w-PQ@mail.gmail.com>

Hi Magnus-san,

(2014/06/26 12:01), Magnus Damm wrote:
> Hi Shimoda-san,
> 
> On Thu, Jun 26, 2014 at 11:47 AM, Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@renesas.com> wrote:
>> Hi Sergei,
>>
>> (2014/06/25 2:59), Sergei Shtylyov wrote:
>>> From: Ben Dooks <ben.dooks@codethink.co.uk>
>>>
>>> Add device nodes for the R8A7790 internal PCI bridge devices.
>>>
>>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>>> Reviewed-by: Ian Molton <ian.molton@codethink.co.uk>
>>> [Sergei: added several properties to the PCI bridge nodes]
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>
>> Thank you for the patch!
>> I tested this patch on my lager board and a usb memory, and it works.
>>
>> Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> 
> Thanks for testing. Just one quick question from my side: Which USB
> port did you test?

I tested usb ch1 only...

> I somehow assumed that at least the majority of the USB ports on R-Car
> Gen2 require a USB PHY device driver to work?

Thank you for the point.
About usb ch1, a USB PHY device driver doesn't need, I think.
But, about ch0 and ch2, I think that they should require a USB PHY device driver.

Best regards,
Yoshihiro Shimoda

> Cheers,
> 
> / magnus
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

WARNING: multiple messages have this Message-ID (diff)
From: yoshihiro.shimoda.uh@renesas.com (Yoshihiro Shimoda)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/2] ARM: shmobile: r8a7790: add internal PCI bridge nodes
Date: Thu, 26 Jun 2014 12:37:37 +0900	[thread overview]
Message-ID: <53AB9581.7090806@renesas.com> (raw)
In-Reply-To: <CANqRtoSsx+NAz2W_utN-A2fx+=e_Ywt5eD=Tf9uGnEDvk3w-PQ@mail.gmail.com>

Hi Magnus-san,

(2014/06/26 12:01), Magnus Damm wrote:
> Hi Shimoda-san,
> 
> On Thu, Jun 26, 2014 at 11:47 AM, Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@renesas.com> wrote:
>> Hi Sergei,
>>
>> (2014/06/25 2:59), Sergei Shtylyov wrote:
>>> From: Ben Dooks <ben.dooks@codethink.co.uk>
>>>
>>> Add device nodes for the R8A7790 internal PCI bridge devices.
>>>
>>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>>> Reviewed-by: Ian Molton <ian.molton@codethink.co.uk>
>>> [Sergei: added several properties to the PCI bridge nodes]
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>
>> Thank you for the patch!
>> I tested this patch on my lager board and a usb memory, and it works.
>>
>> Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> 
> Thanks for testing. Just one quick question from my side: Which USB
> port did you test?

I tested usb ch1 only...

> I somehow assumed that at least the majority of the USB ports on R-Car
> Gen2 require a USB PHY device driver to work?

Thank you for the point.
About usb ch1, a USB PHY device driver doesn't need, I think.
But, about ch0 and ch2, I think that they should require a USB PHY device driver.

Best regards,
Yoshihiro Shimoda

> Cheers,
> 
> / magnus
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

WARNING: multiple messages have this Message-ID (diff)
From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
	"horms@verge.net.au" <horms@verge.net.au>,
	"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"pawel.moll@arm.com" <pawel.moll@arm.com>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
	"galak@codeaurora.org" <galak@codeaurora.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"ben.dooks@codethink.co.uk" <ben.dooks@codethink.co.uk>
Subject: Re: [PATCH v5 1/2] ARM: shmobile: r8a7790: add internal PCI bridge nodes
Date: Thu, 26 Jun 2014 12:37:37 +0900	[thread overview]
Message-ID: <53AB9581.7090806@renesas.com> (raw)
In-Reply-To: <CANqRtoSsx+NAz2W_utN-A2fx+=e_Ywt5eD=Tf9uGnEDvk3w-PQ@mail.gmail.com>

Hi Magnus-san,

(2014/06/26 12:01), Magnus Damm wrote:
> Hi Shimoda-san,
> 
> On Thu, Jun 26, 2014 at 11:47 AM, Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@renesas.com> wrote:
>> Hi Sergei,
>>
>> (2014/06/25 2:59), Sergei Shtylyov wrote:
>>> From: Ben Dooks <ben.dooks@codethink.co.uk>
>>>
>>> Add device nodes for the R8A7790 internal PCI bridge devices.
>>>
>>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>>> Reviewed-by: Ian Molton <ian.molton@codethink.co.uk>
>>> [Sergei: added several properties to the PCI bridge nodes]
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>
>> Thank you for the patch!
>> I tested this patch on my lager board and a usb memory, and it works.
>>
>> Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> 
> Thanks for testing. Just one quick question from my side: Which USB
> port did you test?

I tested usb ch1 only...

> I somehow assumed that at least the majority of the USB ports on R-Car
> Gen2 require a USB PHY device driver to work?

Thank you for the point.
About usb ch1, a USB PHY device driver doesn't need, I think.
But, about ch0 and ch2, I think that they should require a USB PHY device driver.

Best regards,
Yoshihiro Shimoda

> Cheers,
> 
> / magnus
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

  reply	other threads:[~2014-06-26  3:37 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-24 17:57 [PATCH v5 0/2] Add R8A7790/Lager board PCI USB DT support Sergei Shtylyov
2014-06-24 17:57 ` Sergei Shtylyov
2014-06-24 17:57 ` Sergei Shtylyov
2014-06-24 17:59 ` [PATCH v5 1/2] ARM: shmobile: r8a7790: add internal PCI bridge nodes Sergei Shtylyov
2014-06-24 17:59   ` Sergei Shtylyov
2014-06-24 17:59   ` Sergei Shtylyov
2014-06-24 18:11   ` Arnd Bergmann
2014-06-24 18:11     ` Arnd Bergmann
2014-06-24 18:11     ` Arnd Bergmann
2014-06-26  2:47   ` Yoshihiro Shimoda
2014-06-26  2:47     ` Yoshihiro Shimoda
2014-06-26  2:47     ` Yoshihiro Shimoda
2014-06-26  3:01     ` Magnus Damm
2014-06-26  3:01       ` Magnus Damm
2014-06-26  3:01       ` Magnus Damm
2014-06-26  3:37       ` Yoshihiro Shimoda [this message]
2014-06-26  3:37         ` Yoshihiro Shimoda
2014-06-26  3:37         ` Yoshihiro Shimoda
2014-06-26  3:53         ` Magnus Damm
2014-06-26  3:53           ` Magnus Damm
2014-06-26  3:53           ` Magnus Damm
2014-06-26 12:34         ` Sergei Shtylyov
2014-06-26 12:34           ` Sergei Shtylyov
2014-06-26 12:34           ` Sergei Shtylyov
2014-06-30  7:58           ` Yoshihiro Shimoda
2014-06-30  7:58             ` Yoshihiro Shimoda
2014-06-30  7:58             ` Yoshihiro Shimoda
2014-06-26 12:28       ` Sergei Shtylyov
2014-06-26 12:28         ` Sergei Shtylyov
2014-06-26 12:28         ` Sergei Shtylyov
2014-06-24 18:02 ` [PATCH v5 2/2] ARM: shmobile: lager: enable internal PCI Sergei Shtylyov
2014-06-24 18:02   ` Sergei Shtylyov
2014-06-24 18:02   ` Sergei Shtylyov
2014-06-26  2:48   ` Yoshihiro Shimoda
2014-06-26  2:48     ` Yoshihiro Shimoda
2014-06-26  2:48     ` Yoshihiro Shimoda
2014-06-27 23:56 ` [PATCH v5 0/2] Add R8A7790/Lager board PCI USB DT support Simon Horman
2014-06-27 23:56   ` Simon Horman
2014-06-27 23:56   ` Simon Horman
2014-06-27 23:56   ` Simon Horman
2014-06-27 23:56     ` Simon Horman
2014-06-27 23:56     ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53AB9581.7090806@renesas.com \
    --to=yoshihiro.shimoda.uh@renesas.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.