From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] serial-pci: remove memory regions from BAR before destroying them
Date: Thu, 26 Jun 2014 12:08:30 +0200 [thread overview]
Message-ID: <53ABF11E.4030508@redhat.com> (raw)
In-Reply-To: <877g442kie.fsf@blackfin.pond.sub.org>
Il 26/06/2014 09:32, Markus Armbruster ha scritto:
>> > Reported-by: Markus Armbruster <armbru@redhat.com>
>> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>
> Would it make sense to add a "must not contain subregions" to
> memory_region_destroy()'s function comment?
I don't know, in the end the assertion is pretty self-explanatory. If
we add hotplug support to libqos, we can test it.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH] serial-pci: remove memory regions from BAR before destroying them
Date: Thu, 26 Jun 2014 12:08:30 +0200 [thread overview]
Message-ID: <53ABF11E.4030508@redhat.com> (raw)
In-Reply-To: <877g442kie.fsf@blackfin.pond.sub.org>
Il 26/06/2014 09:32, Markus Armbruster ha scritto:
>> > Reported-by: Markus Armbruster <armbru@redhat.com>
>> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>
> Would it make sense to add a "must not contain subregions" to
> memory_region_destroy()'s function comment?
I don't know, in the end the assertion is pretty self-explanatory. If
we add hotplug support to libqos, we can test it.
Paolo
next prev parent reply other threads:[~2014-06-26 10:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 18:21 [Qemu-trivial] [PATCH] serial-pci: remove memory regions from BAR before destroying them Paolo Bonzini
2014-06-25 18:21 ` [Qemu-devel] " Paolo Bonzini
2014-06-26 7:32 ` [Qemu-trivial] " Markus Armbruster
2014-06-26 7:32 ` Markus Armbruster
2014-06-26 10:08 ` Paolo Bonzini [this message]
2014-06-26 10:08 ` Paolo Bonzini
2014-07-14 12:36 ` [Qemu-trivial] " Peter Crosthwaite
2014-07-14 12:36 ` Peter Crosthwaite
2014-07-14 14:20 ` [Qemu-trivial] " Paolo Bonzini
2014-07-14 14:20 ` Paolo Bonzini
2014-07-14 14:28 ` [Qemu-trivial] " Peter Crosthwaite
2014-07-14 14:28 ` Peter Crosthwaite
2014-07-14 15:25 ` [Qemu-trivial] " Markus Armbruster
2014-07-14 15:25 ` Markus Armbruster
2014-07-15 8:35 ` [Qemu-trivial] " Gerd Hoffmann
2014-07-15 8:35 ` Gerd Hoffmann
2014-07-15 8:39 ` [Qemu-trivial] " Paolo Bonzini
2014-07-15 8:39 ` [Qemu-devel] " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53ABF11E.4030508@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.