All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
	Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-trivial] [PATCH] serial-pci: remove memory regions from BAR before destroying them
Date: Tue, 15 Jul 2014 10:39:55 +0200	[thread overview]
Message-ID: <53C4E8DB.1040502@redhat.com> (raw)
In-Reply-To: <1405413340.23139.7.camel@nilsson.home.kraxel.org>

Il 15/07/2014 10:35, Gerd Hoffmann ha scritto:
> On Mo, 2014-07-14 at 17:25 +0200, Markus Armbruster wrote:
>> Peter Crosthwaite <peter.crosthwaite@xilinx.com> writes:
>>
>>> On Thu, Jun 26, 2014 at 5:32 PM, Markus Armbruster <armbru@redhat.com> wrote:
>>>> Paolo Bonzini <pbonzini@redhat.com> writes:
>>>>
>>>>> Otherwise, hot-unplug of pci-serial-2x trips the assertion
>>>>> in memory_region_destroy:
>>>>>
>>>>>     (qemu) device_del gg
>>>>>     (qemu) qemu-system-x86_64: /work/armbru/tmp/qemu/memory.c:1021:
>>>>> memory_region_destroy: Assertion `((&mr->subregions)->tqh_first ==
>>>>> ((void *)0))' failed.
>>>>>     Aborted (core dumped)
>>>>>
>>>>> Reported-by: Markus Armbruster <armbru@redhat.com>
>>>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>>>
>>>> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>>>>
>>>
>>> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
>>
>> Nominating for 2.1, just to be explicit.
>>
>> [...]
>
> Hmm, is trivial out of service?  I remember thinking "Ok, trivial patch,
> qemu-trivial is cc'ed, that'll pick it up, nothing to do for me."

I think it's more likely that Michael went on vacation, from a quick 
look at his posting history.

Paolo



WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
	Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] serial-pci: remove memory regions from BAR before destroying them
Date: Tue, 15 Jul 2014 10:39:55 +0200	[thread overview]
Message-ID: <53C4E8DB.1040502@redhat.com> (raw)
In-Reply-To: <1405413340.23139.7.camel@nilsson.home.kraxel.org>

Il 15/07/2014 10:35, Gerd Hoffmann ha scritto:
> On Mo, 2014-07-14 at 17:25 +0200, Markus Armbruster wrote:
>> Peter Crosthwaite <peter.crosthwaite@xilinx.com> writes:
>>
>>> On Thu, Jun 26, 2014 at 5:32 PM, Markus Armbruster <armbru@redhat.com> wrote:
>>>> Paolo Bonzini <pbonzini@redhat.com> writes:
>>>>
>>>>> Otherwise, hot-unplug of pci-serial-2x trips the assertion
>>>>> in memory_region_destroy:
>>>>>
>>>>>     (qemu) device_del gg
>>>>>     (qemu) qemu-system-x86_64: /work/armbru/tmp/qemu/memory.c:1021:
>>>>> memory_region_destroy: Assertion `((&mr->subregions)->tqh_first ==
>>>>> ((void *)0))' failed.
>>>>>     Aborted (core dumped)
>>>>>
>>>>> Reported-by: Markus Armbruster <armbru@redhat.com>
>>>>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>>>
>>>> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>>>>
>>>
>>> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
>>
>> Nominating for 2.1, just to be explicit.
>>
>> [...]
>
> Hmm, is trivial out of service?  I remember thinking "Ok, trivial patch,
> qemu-trivial is cc'ed, that'll pick it up, nothing to do for me."

I think it's more likely that Michael went on vacation, from a quick 
look at his posting history.

Paolo

  reply	other threads:[~2014-07-15  8:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-25 18:21 [Qemu-trivial] [PATCH] serial-pci: remove memory regions from BAR before destroying them Paolo Bonzini
2014-06-25 18:21 ` [Qemu-devel] " Paolo Bonzini
2014-06-26  7:32 ` [Qemu-trivial] " Markus Armbruster
2014-06-26  7:32   ` Markus Armbruster
2014-06-26 10:08   ` [Qemu-trivial] " Paolo Bonzini
2014-06-26 10:08     ` Paolo Bonzini
2014-07-14 12:36   ` [Qemu-trivial] " Peter Crosthwaite
2014-07-14 12:36     ` Peter Crosthwaite
2014-07-14 14:20     ` [Qemu-trivial] " Paolo Bonzini
2014-07-14 14:20       ` Paolo Bonzini
2014-07-14 14:28       ` [Qemu-trivial] " Peter Crosthwaite
2014-07-14 14:28         ` Peter Crosthwaite
2014-07-14 15:25     ` [Qemu-trivial] " Markus Armbruster
2014-07-14 15:25       ` Markus Armbruster
2014-07-15  8:35       ` [Qemu-trivial] " Gerd Hoffmann
2014-07-15  8:35         ` Gerd Hoffmann
2014-07-15  8:39         ` Paolo Bonzini [this message]
2014-07-15  8:39           ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C4E8DB.1040502@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=armbru@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.