[PATCH] pinctrl: pinctrl-st.c: Cleaning up if unsigned is less than zero

All of lore.kernel.org
 help / color / mirror / Atom feed

* [PATCH] pinctrl: pinctrl-st.c: Cleaning up if unsigned is less than zero
@ 2014-06-26 11:32 ` Rickard Strandqvist
  0 siblings, 0 replies; 10+ messages in thread
From: Rickard Strandqvist @ 2014-06-26 11:32 UTC (permalink / raw)
  To: linux-arm-kernel

Remove checking if a unsigned is less than zero

This was found using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
 drivers/pinctrl/pinctrl-st.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
index 1bd6363bc9..f4ee1b1 100644
--- a/drivers/pinctrl/pinctrl-st.c
+++ b/drivers/pinctrl/pinctrl-st.c
@@ -1256,7 +1256,7 @@ static int st_pctl_parse_functions(struct device_node *np,
 	func = &info->functions[index];
 	func->name = np->name;
 	func->ngroups = of_get_child_count(np);
-	if (func->ngroups <= 0) {
+	if (func->ngroups == 0) {
 		dev_err(info->dev, "No groups defined\n");
 		return -EINVAL;
 	}
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH] pinctrl: pinctrl-st.c:  Cleaning up if unsigned is less than zero
@ 2014-06-26 11:32 ` Rickard Strandqvist
  0 siblings, 0 replies; 10+ messages in thread
From: Rickard Strandqvist @ 2014-06-26 11:32 UTC (permalink / raw)
  To: Srinivas Kandagatla, Maxime Coquelin
  Cc: Rickard Strandqvist, Patrice Chotard, Linus Walleij, Grant Likely,
	Rob Herring, linux-arm-kernel, kernel, linux-kernel, devicetree

Remove checking if a unsigned is less than zero

This was found using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
 drivers/pinctrl/pinctrl-st.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
index 1bd6363bc9..f4ee1b1 100644
--- a/drivers/pinctrl/pinctrl-st.c
+++ b/drivers/pinctrl/pinctrl-st.c
@@ -1256,7 +1256,7 @@ static int st_pctl_parse_functions(struct device_node *np,
 	func = &info->functions[index];
 	func->name = np->name;
 	func->ngroups = of_get_child_count(np);
-	if (func->ngroups <= 0) {
+	if (func->ngroups == 0) {
 		dev_err(info->dev, "No groups defined\n");
 		return -EINVAL;
 	}
-- 
1.7.10.4


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH] pinctrl: pinctrl-st.c:  Cleaning up if unsigned is less than zero
@ 2014-06-26 11:32 ` Rickard Strandqvist
  0 siblings, 0 replies; 10+ messages in thread
From: Rickard Strandqvist @ 2014-06-26 11:32 UTC (permalink / raw)
  To: Srinivas Kandagatla, Maxime Coquelin
  Cc: Rickard Strandqvist, Patrice Chotard, Linus Walleij, Grant Likely,
	Rob Herring, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	kernel-F5mvAk5X5gdBDgjK7y7TUQ,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA

Remove checking if a unsigned is less than zero

This was found using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist-IW2WV5XWFqGZkjO+N0TKoMugMpMbD5Xr@public.gmane.org>
---
 drivers/pinctrl/pinctrl-st.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
index 1bd6363bc9..f4ee1b1 100644
--- a/drivers/pinctrl/pinctrl-st.c
+++ b/drivers/pinctrl/pinctrl-st.c
@@ -1256,7 +1256,7 @@ static int st_pctl_parse_functions(struct device_node *np,
 	func = &info->functions[index];
 	func->name = np->name;
 	func->ngroups = of_get_child_count(np);
-	if (func->ngroups <= 0) {
+	if (func->ngroups == 0) {
 		dev_err(info->dev, "No groups defined\n");
 		return -EINVAL;
 	}
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH] pinctrl: pinctrl-st.c: Cleaning up if unsigned is less than zero
  2014-06-26 11:32 ` Rickard Strandqvist
@ 2014-06-26 11:47   ` Srinivas Kandagatla
  -1 siblings, 0 replies; 10+ messages in thread
From: Srinivas Kandagatla @ 2014-06-26 11:47 UTC (permalink / raw)
  To: linux-arm-kernel



On 26/06/14 12:32, Rickard Strandqvist wrote:
> Remove checking if a unsigned is less than zero
>
> This was found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
>   drivers/pinctrl/pinctrl-st.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index 1bd6363bc9..f4ee1b1 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -1256,7 +1256,7 @@ static int st_pctl_parse_functions(struct device_node *np,
>   	func = &info->functions[index];
>   	func->name = np->name;
>   	func->ngroups = of_get_child_count(np);
> -	if (func->ngroups <= 0) {
> +	if (func->ngroups == 0) {

Makes sense

Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>


>   		dev_err(info->dev, "No groups defined\n");
>   		return -EINVAL;
>   	}
>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] pinctrl: pinctrl-st.c: Cleaning up if unsigned is less than zero
@ 2014-06-26 11:47   ` Srinivas Kandagatla
  0 siblings, 0 replies; 10+ messages in thread
From: Srinivas Kandagatla @ 2014-06-26 11:47 UTC (permalink / raw)
  To: Rickard Strandqvist, Srinivas Kandagatla, Maxime Coquelin
  Cc: devicetree, kernel, Linus Walleij, Patrice Chotard, linux-kernel,
	Rob Herring, Grant Likely, linux-arm-kernel



On 26/06/14 12:32, Rickard Strandqvist wrote:
> Remove checking if a unsigned is less than zero
>
> This was found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
>   drivers/pinctrl/pinctrl-st.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
> index 1bd6363bc9..f4ee1b1 100644
> --- a/drivers/pinctrl/pinctrl-st.c
> +++ b/drivers/pinctrl/pinctrl-st.c
> @@ -1256,7 +1256,7 @@ static int st_pctl_parse_functions(struct device_node *np,
>   	func = &info->functions[index];
>   	func->name = np->name;
>   	func->ngroups = of_get_child_count(np);
> -	if (func->ngroups <= 0) {
> +	if (func->ngroups == 0) {

Makes sense

Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>


>   		dev_err(info->dev, "No groups defined\n");
>   		return -EINVAL;
>   	}
>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH] pinctrl: pinctrl-st.c:  Cleaning up if unsigned is less than zero
  2014-06-26 11:32 ` Rickard Strandqvist
  (?)
@ 2014-06-26 12:03   ` Maxime Coquelin
  -1 siblings, 0 replies; 10+ messages in thread
From: Maxime Coquelin @ 2014-06-26 12:03 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Rickard,

On 06/26/2014 01:32 PM, Rickard Strandqvist wrote:
> Remove checking if a unsigned is less than zero
> 
> This was found using a static code analysis program called
> cppcheck.
> 
> Signed-off-by: Rickard Strandqvist
> <rickard_strandqvist@spectrumdigital.se>

You can add my:
Acked-by: Maxime Coquelin <maxime.coquelin@st.com>

Thanks,
Maxime
> --- drivers/pinctrl/pinctrl-st.c |    2 +- 1 file changed, 1
> insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-st.c
> b/drivers/pinctrl/pinctrl-st.c index 1bd6363bc9..f4ee1b1 100644 ---
> a/drivers/pinctrl/pinctrl-st.c +++ b/drivers/pinctrl/pinctrl-st.c 
> @@ -1256,7 +1256,7 @@ static int st_pctl_parse_functions(struct
> device_node *np, func = &info->functions[index]; func->name =
> np->name; func->ngroups = of_get_child_count(np); -	if
> (func->ngroups <= 0) { +	if (func->ngroups == 0) { 
> dev_err(info->dev, "No groups defined\n"); return -EINVAL; }
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] pinctrl: pinctrl-st.c:  Cleaning up if unsigned is less than zero
@ 2014-06-26 12:03   ` Maxime Coquelin
  0 siblings, 0 replies; 10+ messages in thread
From: Maxime Coquelin @ 2014-06-26 12:03 UTC (permalink / raw)
  To: Rickard Strandqvist, Srinivas Kandagatla
  Cc: Patrice Chotard, Linus Walleij, Grant Likely, Rob Herring,
	linux-arm-kernel, kernel, linux-kernel, devicetree

Hi Rickard,

On 06/26/2014 01:32 PM, Rickard Strandqvist wrote:
> Remove checking if a unsigned is less than zero
> 
> This was found using a static code analysis program called
> cppcheck.
> 
> Signed-off-by: Rickard Strandqvist
> <rickard_strandqvist@spectrumdigital.se>

You can add my:
Acked-by: Maxime Coquelin <maxime.coquelin@st.com>

Thanks,
Maxime
> --- drivers/pinctrl/pinctrl-st.c |    2 +- 1 file changed, 1
> insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-st.c
> b/drivers/pinctrl/pinctrl-st.c index 1bd6363bc9..f4ee1b1 100644 ---
> a/drivers/pinctrl/pinctrl-st.c +++ b/drivers/pinctrl/pinctrl-st.c 
> @@ -1256,7 +1256,7 @@ static int st_pctl_parse_functions(struct
> device_node *np, func = &info->functions[index]; func->name =
> np->name; func->ngroups = of_get_child_count(np); -	if
> (func->ngroups <= 0) { +	if (func->ngroups == 0) { 
> dev_err(info->dev, "No groups defined\n"); return -EINVAL; }
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] pinctrl: pinctrl-st.c:  Cleaning up if unsigned is less than zero
@ 2014-06-26 12:03   ` Maxime Coquelin
  0 siblings, 0 replies; 10+ messages in thread
From: Maxime Coquelin @ 2014-06-26 12:03 UTC (permalink / raw)
  To: Rickard Strandqvist, Srinivas Kandagatla
  Cc: Patrice Chotard, Linus Walleij, Grant Likely, Rob Herring,
	linux-arm-kernel, kernel, linux-kernel, devicetree

Hi Rickard,

On 06/26/2014 01:32 PM, Rickard Strandqvist wrote:
> Remove checking if a unsigned is less than zero
> 
> This was found using a static code analysis program called
> cppcheck.
> 
> Signed-off-by: Rickard Strandqvist
> <rickard_strandqvist@spectrumdigital.se>

You can add my:
Acked-by: Maxime Coquelin <maxime.coquelin@st.com>

Thanks,
Maxime
> --- drivers/pinctrl/pinctrl-st.c |    2 +- 1 file changed, 1
> insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-st.c
> b/drivers/pinctrl/pinctrl-st.c index 1bd6363bc9..f4ee1b1 100644 ---
> a/drivers/pinctrl/pinctrl-st.c +++ b/drivers/pinctrl/pinctrl-st.c 
> @@ -1256,7 +1256,7 @@ static int st_pctl_parse_functions(struct
> device_node *np, func = &info->functions[index]; func->name =
> np->name; func->ngroups = of_get_child_count(np); -	if
> (func->ngroups <= 0) { +	if (func->ngroups == 0) { 
> dev_err(info->dev, "No groups defined\n"); return -EINVAL; }
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH] pinctrl: pinctrl-st.c: Cleaning up if unsigned is less than zero
  2014-06-26 11:32 ` Rickard Strandqvist
@ 2014-07-07 15:42   ` Linus Walleij
  -1 siblings, 0 replies; 10+ messages in thread
From: Linus Walleij @ 2014-07-07 15:42 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Jun 26, 2014 at 1:32 PM, Rickard Strandqvist
<rickard_strandqvist@spectrumdigital.se> wrote:

> Remove checking if a unsigned is less than zero
>
> This was found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>

Patch applied with the ACKs. Thanks!

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] pinctrl: pinctrl-st.c: Cleaning up if unsigned is less than zero
@ 2014-07-07 15:42   ` Linus Walleij
  0 siblings, 0 replies; 10+ messages in thread
From: Linus Walleij @ 2014-07-07 15:42 UTC (permalink / raw)
  To: Rickard Strandqvist
  Cc: Srinivas Kandagatla, Maxime Coquelin, Patrice Chotard,
	Grant Likely, Rob Herring, linux-arm-kernel@lists.infradead.org,
	kernel, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org

On Thu, Jun 26, 2014 at 1:32 PM, Rickard Strandqvist
<rickard_strandqvist@spectrumdigital.se> wrote:

> Remove checking if a unsigned is less than zero
>
> This was found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>

Patch applied with the ACKs. Thanks!

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2014-07-07 15:42 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-26 11:32 [PATCH] pinctrl: pinctrl-st.c: Cleaning up if unsigned is less than zero Rickard Strandqvist
2014-06-26 11:32 ` Rickard Strandqvist
2014-06-26 11:32 ` Rickard Strandqvist
2014-06-26 11:47 ` Srinivas Kandagatla
2014-06-26 11:47   ` Srinivas Kandagatla
2014-06-26 12:03 ` Maxime Coquelin
2014-06-26 12:03   ` Maxime Coquelin
2014-06-26 12:03   ` Maxime Coquelin
2014-07-07 15:42 ` Linus Walleij
2014-07-07 15:42   ` Linus Walleij

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.