All of lore.kernel.org
 help / color / mirror / Atom feed
From: elfring@users.sourceforge.net (SF Markus Elfring)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?
Date: Sat, 28 Jun 2014 23:00:22 +0200	[thread overview]
Message-ID: <53AF2CE6.5020300@users.sourceforge.net> (raw)
In-Reply-To: <20140628140157.98304218ad0919b1567cfee4@skynet.be>

> Sorry but I'm not working on coccinelle ; just did a small script for kernel tree.

I would appreciate a more constructive feedback for my update suggestions around
the topic "Deletion of unnecessary checks before specific function calls".
- Did you look at the concrete patches?
- How do you think about the general approach?

Examples:
https://systeme.lip6.fr/pipermail/cocci/2014-March/000676.html
http://marc.info/?l=kernel-janitors&m=139405971927100&w=2

https://systeme.lip6.fr/pipermail/cocci/2014-March/000677.html
http://marc.info/?l=kernel-janitors&m=139405983727148&w=2

Regards,
Markus

WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org, Coccinelle <cocci@systeme.lip6.fr>,
	Joe Perches <joe@perches.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?
Date: Sat, 28 Jun 2014 23:00:22 +0200	[thread overview]
Message-ID: <53AF2CE6.5020300@users.sourceforge.net> (raw)
In-Reply-To: <20140628140157.98304218ad0919b1567cfee4@skynet.be>

> Sorry but I'm not working on coccinelle ; just did a small script for kernel tree.

I would appreciate a more constructive feedback for my update suggestions around
the topic "Deletion of unnecessary checks before specific function calls".
- Did you look at the concrete patches?
- How do you think about the general approach?

Examples:
https://systeme.lip6.fr/pipermail/cocci/2014-March/000676.html
http://marc.info/?l=kernel-janitors&m=139405971927100&w=2

https://systeme.lip6.fr/pipermail/cocci/2014-March/000677.html
http://marc.info/?l=kernel-janitors&m=139405983727148&w=2

Regards,
Markus

  reply	other threads:[~2014-06-28 21:00 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-28  8:47 [PATCH V3] scripts/coccinelle/free: add NULL test before freeing functions Fabian Frederick
2014-06-28  9:08 ` [Cocci] [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions? SF Markus Elfring
2014-06-28  9:08   ` SF Markus Elfring
2014-06-28 10:00   ` [Cocci] " Fabian Frederick
2014-06-28 10:00     ` Fabian Frederick
2014-06-28 11:38     ` [Cocci] " SF Markus Elfring
2014-06-28 11:38       ` SF Markus Elfring
2014-06-28 12:01       ` [Cocci] " Fabian Frederick
2014-06-28 12:01         ` Fabian Frederick
2014-06-28 21:00         ` SF Markus Elfring [this message]
2014-06-28 21:00           ` SF Markus Elfring
2014-06-28 21:28           ` [Cocci] " Julia Lawall
2014-06-28 21:28             ` Julia Lawall
2014-06-29 10:45             ` SF Markus Elfring
2014-06-29 10:45               ` SF Markus Elfring
2014-06-29  8:27           ` Fabian Frederick
2014-06-29  8:27             ` Fabian Frederick
2014-06-29 11:00             ` [Cocci] " SF Markus Elfring
2014-06-29 11:00               ` SF Markus Elfring
2014-06-28 18:32   ` [Cocci] " Julia Lawall
2014-06-28 18:32     ` Julia Lawall
2014-06-28 17:55 ` [PATCH V3] scripts/coccinelle/free: add NULL test before freeing functions Julia Lawall
2014-06-28 17:58   ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53AF2CE6.5020300@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.