From: elfring@users.sourceforge.net (SF Markus Elfring)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?
Date: Sun, 29 Jun 2014 12:45:41 +0200 [thread overview]
Message-ID: <53AFEE55.7080906@users.sourceforge.net> (raw)
In-Reply-To: <alpine.DEB.2.02.1406282326010.2022@localhost6.localdomain6>
>> https://systeme.lip6.fr/pipermail/cocci/2014-March/000676.html
>> http://marc.info/?l=kernel-janitors&m=139405971927100&w=2
> Regular expressions do not allow taking advantage of the optimizations
> provided by Coccinelle and are not easy for a reader to understand.
I find that the application of regexes is appropriate here.
Would you like to optimise any implementation details from my general
approach?
>> https://systeme.lip6.fr/pipermail/cocci/2014-March/000677.html
>> http://marc.info/?l=kernel-janitors&m=139405983727148&w=2
> This is not safe due to the use of when any. You have no guarantee that
> there is not a dereference of input in the matched region, or that the
> value of input is still the argument value at the point of the test.
Do you suggest to make the desired detection of input parameter
validation a bit safer?
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Coccinelle <cocci@systeme.lip6.fr>,
linux-kernel@vger.kernel.org, Fabian Frederick <fabf@skynet.be>
Subject: Re: [Cocci] [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions?
Date: Sun, 29 Jun 2014 12:45:41 +0200 [thread overview]
Message-ID: <53AFEE55.7080906@users.sourceforge.net> (raw)
In-Reply-To: <alpine.DEB.2.02.1406282326010.2022@localhost6.localdomain6>
>> https://systeme.lip6.fr/pipermail/cocci/2014-March/000676.html
>> http://marc.info/?l=kernel-janitors&m=139405971927100&w=2
> Regular expressions do not allow taking advantage of the optimizations
> provided by Coccinelle and are not easy for a reader to understand.
I find that the application of regexes is appropriate here.
Would you like to optimise any implementation details from my general
approach?
>> https://systeme.lip6.fr/pipermail/cocci/2014-March/000677.html
>> http://marc.info/?l=kernel-janitors&m=139405983727148&w=2
> This is not safe due to the use of when any. You have no guarantee that
> there is not a dereference of input in the matched region, or that the
> value of input is still the argument value at the point of the test.
Do you suggest to make the desired detection of input parameter
validation a bit safer?
Regards,
Markus
next prev parent reply other threads:[~2014-06-29 10:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-28 8:47 [PATCH V3] scripts/coccinelle/free: add NULL test before freeing functions Fabian Frederick
2014-06-28 9:08 ` [Cocci] [PATCH V3] scripts/coccinelle/free: Delete NULL test before freeing functions? SF Markus Elfring
2014-06-28 9:08 ` SF Markus Elfring
2014-06-28 10:00 ` [Cocci] " Fabian Frederick
2014-06-28 10:00 ` Fabian Frederick
2014-06-28 11:38 ` [Cocci] " SF Markus Elfring
2014-06-28 11:38 ` SF Markus Elfring
2014-06-28 12:01 ` [Cocci] " Fabian Frederick
2014-06-28 12:01 ` Fabian Frederick
2014-06-28 21:00 ` [Cocci] " SF Markus Elfring
2014-06-28 21:00 ` SF Markus Elfring
2014-06-28 21:28 ` [Cocci] " Julia Lawall
2014-06-28 21:28 ` Julia Lawall
2014-06-29 10:45 ` SF Markus Elfring [this message]
2014-06-29 10:45 ` SF Markus Elfring
2014-06-29 8:27 ` Fabian Frederick
2014-06-29 8:27 ` Fabian Frederick
2014-06-29 11:00 ` [Cocci] " SF Markus Elfring
2014-06-29 11:00 ` SF Markus Elfring
2014-06-28 18:32 ` [Cocci] " Julia Lawall
2014-06-28 18:32 ` Julia Lawall
2014-06-28 17:55 ` [PATCH V3] scripts/coccinelle/free: add NULL test before freeing functions Julia Lawall
2014-06-28 17:58 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AFEE55.7080906@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.