* [PATCH] xen/arm: Small fixes after GICv2 changes by commit ee65c87
@ 2014-07-02 12:34 Julien Grall
2014-07-02 13:14 ` Julien Grall
0 siblings, 1 reply; 2+ messages in thread
From: Julien Grall @ 2014-07-02 12:34 UTC (permalink / raw)
To: xen-devel; +Cc: stefano.stabellini, Julien Grall, tim, ian.campbell
The commit ee65c87 moves the GICv2 code in a separate file. Even though this
patch is only deals with code movement, a comment was modify for no reason.
Also rename gic_v2_init into gicv2_setup which is what the function does
and less confusing with the other function called gicv2_init.
Signed-off-by: Julien Grall <julien.grall@linaro.org>
---
xen/arch/arm/gic-v2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c
index 695c232..74c72d6 100644
--- a/xen/arch/arm/gic-v2.c
+++ b/xen/arch/arm/gic-v2.c
@@ -372,12 +372,12 @@ static void gicv2_clear_lr(int lr)
writel_relaxed(0, GICH + GICH_LR + lr * 4);
}
-static int gicv_v2_init(struct domain *d)
+static int gicv2_setup(struct domain *d)
{
int ret;
/*
- * Domain 0 gets the hardware address.
+ * The hardware domain gets the hardware address.
* Guests get the virtual platform layout.
*/
if ( is_hardware_domain(d) )
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xen/arm: Small fixes after GICv2 changes by commit ee65c87
2014-07-02 12:34 [PATCH] xen/arm: Small fixes after GICv2 changes by commit ee65c87 Julien Grall
@ 2014-07-02 13:14 ` Julien Grall
0 siblings, 0 replies; 2+ messages in thread
From: Julien Grall @ 2014-07-02 13:14 UTC (permalink / raw)
To: xen-devel; +Cc: stefano.stabellini, tim, ian.campbell
On 07/02/2014 01:34 PM, Julien Grall wrote:
> The commit ee65c87 moves the GICv2 code in a separate file. Even though this
> patch is only deals with code movement, a comment was modify for no reason.
>
> Also rename gic_v2_init into gicv2_setup which is what the function does
> and less confusing with the other function called gicv2_init.
>
> Signed-off-by: Julien Grall <julien.grall@linaro.org>
> ---
> xen/arch/arm/gic-v2.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c
> index 695c232..74c72d6 100644
> --- a/xen/arch/arm/gic-v2.c
> +++ b/xen/arch/arm/gic-v2.c
> @@ -372,12 +372,12 @@ static void gicv2_clear_lr(int lr)
> writel_relaxed(0, GICH + GICH_LR + lr * 4);
> }
>
> -static int gicv_v2_init(struct domain *d)
> +static int gicv2_setup(struct domain *d)
Hmmmm... I forgot to modify the caller. :/ I will send a v2 right now.
--
Julien Grall
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-07-02 13:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-02 12:34 [PATCH] xen/arm: Small fixes after GICv2 changes by commit ee65c87 Julien Grall
2014-07-02 13:14 ` Julien Grall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.