[meta-oe] [PATCH] fftwf and fftwl: exclude them from world

[meta-oe] [PATCH] fftwf and fftwl: exclude them from world

[Robert Yang]

The fftw, fftwf and fftwl provide the same files (different contents), we
should only build one of them, otherwise there would be warning

WARNING: The recipe fftw is trying to install files into a shared area when those files already exist. Those files and their manifest location are:
   sysroots/qemux86-64/usr/include/fftw3.f03
   Matched in manifest-qemux86-64-fftwl.populate_sysroot
manifest-qemux86-64-fftwf.populate_sysroot
   sysroots/qemux86-64/usr/include/fftw3.h
   Matched in manifest-qemux86-64-fftwl.populate_sysroot
manifest-qemux86-64-fftwf.populate_sysroot
   sysroots/qemux86-64/usr/include/fftw3q.f03
   Matched in manifest-qemux86-64-fftwl.populate_sysroot
manifest-qemux86-64-fftwf.populate_sysroot
   sysroots/qemux86-64/usr/include/fftw3.f
   Matched in manifest-qemux86-64-fftwl.populate_sysroot
manifest-qemux86-64-fftwf.populate_sysroot
   sysroots/qemux86-64/usr/include/fftw3l.f03
   Matched in manifest-qemux86-64-fftwl.populate_sysroot
manifest-qemux86-64-fftwf.populate_sysroot
Please verify which package should provide the above files.

and maybe errors (race issue):

The recipe imagemagick.do_compiler error:
  fourier.c:69:19: fatal error: fftw3.h: No such file or directory
   #include <fftw3.h>

This is because imagemagick.do_configure depends on fftw.populate_sysroot, but
the files installed by fftw.populate_sysroot, maybe removed by fftwl or fftwf
when they rebuild.

Only build fftw in the world will fix the problem.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta-oe/recipes-support/fftw/fftwf_3.3.4.bb |    2 ++
 meta-oe/recipes-support/fftw/fftwl_3.3.4.bb |    2 ++
 2 files changed, 4 insertions(+)

diff --git a/meta-oe/recipes-support/fftw/fftwf_3.3.4.bb b/meta-oe/recipes-support/fftw/fftwf_3.3.4.bb
index 59f4a11..8731df7 100644
--- a/meta-oe/recipes-support/fftw/fftwf_3.3.4.bb
+++ b/meta-oe/recipes-support/fftw/fftwf_3.3.4.bb
@@ -6,3 +6,5 @@ EXTRA_OECONF += "--enable-single \
 
 SRC_URI[md5sum] = "2edab8c06b24feeb3b82bbb3ebf3e7b3"
 SRC_URI[sha256sum] = "8f0cde90929bc05587c3368d2f15cd0530a60b8a9912a8e2979a72dbe5af0982"
+
+EXCLUDE_FROM_WORLD = "1"
diff --git a/meta-oe/recipes-support/fftw/fftwl_3.3.4.bb b/meta-oe/recipes-support/fftw/fftwl_3.3.4.bb
index 8f37346..a56bbc8 100644
--- a/meta-oe/recipes-support/fftw/fftwl_3.3.4.bb
+++ b/meta-oe/recipes-support/fftw/fftwl_3.3.4.bb
@@ -4,3 +4,5 @@ EXTRA_OECONF += "--enable-long-double"
 
 SRC_URI[md5sum] = "2edab8c06b24feeb3b82bbb3ebf3e7b3"
 SRC_URI[sha256sum] = "8f0cde90929bc05587c3368d2f15cd0530a60b8a9912a8e2979a72dbe5af0982"
+
+EXCLUDE_FROM_WORLD = "1"
-- 
1.7.9.5

Re: [meta-oe] [PATCH] fftwf and fftwl: exclude them from world

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 3482 bytes --]

On Tue, Jul 08, 2014 at 11:18:47PM -0700, Robert Yang wrote:
> The fftw, fftwf and fftwl provide the same files (different contents), we
> should only build one of them, otherwise there would be warning
> 
> WARNING: The recipe fftw is trying to install files into a shared area when those files already exist. Those files and their manifest location are:
>    sysroots/qemux86-64/usr/include/fftw3.f03
>    Matched in manifest-qemux86-64-fftwl.populate_sysroot
> manifest-qemux86-64-fftwf.populate_sysroot
>    sysroots/qemux86-64/usr/include/fftw3.h
>    Matched in manifest-qemux86-64-fftwl.populate_sysroot
> manifest-qemux86-64-fftwf.populate_sysroot
>    sysroots/qemux86-64/usr/include/fftw3q.f03
>    Matched in manifest-qemux86-64-fftwl.populate_sysroot
> manifest-qemux86-64-fftwf.populate_sysroot
>    sysroots/qemux86-64/usr/include/fftw3.f
>    Matched in manifest-qemux86-64-fftwl.populate_sysroot
> manifest-qemux86-64-fftwf.populate_sysroot
>    sysroots/qemux86-64/usr/include/fftw3l.f03
>    Matched in manifest-qemux86-64-fftwl.populate_sysroot
> manifest-qemux86-64-fftwf.populate_sysroot
> Please verify which package should provide the above files.
> 
> and maybe errors (race issue):
> 
> The recipe imagemagick.do_compiler error:
>   fourier.c:69:19: fatal error: fftw3.h: No such file or directory
>    #include <fftw3.h>
> 
> This is because imagemagick.do_configure depends on fftw.populate_sysroot, but
> the files installed by fftw.populate_sysroot, maybe removed by fftwl or fftwf
> when they rebuild.
> 
> Only build fftw in the world will fix the problem.

But it doesn't fix the problem for people who are really building fftwl
and fftw. If there is someone with this use-case can he send patch
moving common parts to separate recipe used by all 3 or just rename/move
files to have unique name?

Or if they aren't needed at the same time, lets convert fftwl and fftwf
to PACKAGECONFIG options in fftw.

Regards,

> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>  meta-oe/recipes-support/fftw/fftwf_3.3.4.bb |    2 ++
>  meta-oe/recipes-support/fftw/fftwl_3.3.4.bb |    2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/meta-oe/recipes-support/fftw/fftwf_3.3.4.bb b/meta-oe/recipes-support/fftw/fftwf_3.3.4.bb
> index 59f4a11..8731df7 100644
> --- a/meta-oe/recipes-support/fftw/fftwf_3.3.4.bb
> +++ b/meta-oe/recipes-support/fftw/fftwf_3.3.4.bb
> @@ -6,3 +6,5 @@ EXTRA_OECONF += "--enable-single \
>  
>  SRC_URI[md5sum] = "2edab8c06b24feeb3b82bbb3ebf3e7b3"
>  SRC_URI[sha256sum] = "8f0cde90929bc05587c3368d2f15cd0530a60b8a9912a8e2979a72dbe5af0982"
> +
> +EXCLUDE_FROM_WORLD = "1"
> diff --git a/meta-oe/recipes-support/fftw/fftwl_3.3.4.bb b/meta-oe/recipes-support/fftw/fftwl_3.3.4.bb
> index 8f37346..a56bbc8 100644
> --- a/meta-oe/recipes-support/fftw/fftwl_3.3.4.bb
> +++ b/meta-oe/recipes-support/fftw/fftwl_3.3.4.bb
> @@ -4,3 +4,5 @@ EXTRA_OECONF += "--enable-long-double"
>  
>  SRC_URI[md5sum] = "2edab8c06b24feeb3b82bbb3ebf3e7b3"
>  SRC_URI[sha256sum] = "8f0cde90929bc05587c3368d2f15cd0530a60b8a9912a8e2979a72dbe5af0982"
> +
> +EXCLUDE_FROM_WORLD = "1"
> -- 
> 1.7.9.5
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: [meta-oe] [PATCH] fftwf and fftwl: exclude them from world

[Robert Yang]

On 07/09/2014 05:55 PM, Martin Jansa wrote:
> On Tue, Jul 08, 2014 at 11:18:47PM -0700, Robert Yang wrote:
>> The fftw, fftwf and fftwl provide the same files (different contents), we
>> should only build one of them, otherwise there would be warning
>>
>> WARNING: The recipe fftw is trying to install files into a shared area when those files already exist. Those files and their manifest location are:
>>     sysroots/qemux86-64/usr/include/fftw3.f03
>>     Matched in manifest-qemux86-64-fftwl.populate_sysroot
>> manifest-qemux86-64-fftwf.populate_sysroot
>>     sysroots/qemux86-64/usr/include/fftw3.h
>>     Matched in manifest-qemux86-64-fftwl.populate_sysroot
>> manifest-qemux86-64-fftwf.populate_sysroot
>>     sysroots/qemux86-64/usr/include/fftw3q.f03
>>     Matched in manifest-qemux86-64-fftwl.populate_sysroot
>> manifest-qemux86-64-fftwf.populate_sysroot
>>     sysroots/qemux86-64/usr/include/fftw3.f
>>     Matched in manifest-qemux86-64-fftwl.populate_sysroot
>> manifest-qemux86-64-fftwf.populate_sysroot
>>     sysroots/qemux86-64/usr/include/fftw3l.f03
>>     Matched in manifest-qemux86-64-fftwl.populate_sysroot
>> manifest-qemux86-64-fftwf.populate_sysroot
>> Please verify which package should provide the above files.
>>
>> and maybe errors (race issue):
>>
>> The recipe imagemagick.do_compiler error:
>>    fourier.c:69:19: fatal error: fftw3.h: No such file or directory
>>     #include <fftw3.h>
>>
>> This is because imagemagick.do_configure depends on fftw.populate_sysroot, but
>> the files installed by fftw.populate_sysroot, maybe removed by fftwl or fftwf
>> when they rebuild.
>>
>> Only build fftw in the world will fix the problem.
>
> But it doesn't fix the problem for people who are really building fftwl
> and fftw. If there is someone with this use-case can he send patch
> moving common parts to separate recipe used by all 3 or just rename/move
> files to have unique name?
>
> Or if they aren't needed at the same time, lets convert fftwl and fftwf
> to PACKAGECONFIG options in fftw.

Yes, I think that PACKAGECONFIG is a good idea, will send patches tomorrow
if no objections.

// Robert

>
> Regards,
>
>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>> ---
>>   meta-oe/recipes-support/fftw/fftwf_3.3.4.bb |    2 ++
>>   meta-oe/recipes-support/fftw/fftwl_3.3.4.bb |    2 ++
>>   2 files changed, 4 insertions(+)
>>
>> diff --git a/meta-oe/recipes-support/fftw/fftwf_3.3.4.bb b/meta-oe/recipes-support/fftw/fftwf_3.3.4.bb
>> index 59f4a11..8731df7 100644
>> --- a/meta-oe/recipes-support/fftw/fftwf_3.3.4.bb
>> +++ b/meta-oe/recipes-support/fftw/fftwf_3.3.4.bb
>> @@ -6,3 +6,5 @@ EXTRA_OECONF += "--enable-single \
>>
>>   SRC_URI[md5sum] = "2edab8c06b24feeb3b82bbb3ebf3e7b3"
>>   SRC_URI[sha256sum] = "8f0cde90929bc05587c3368d2f15cd0530a60b8a9912a8e2979a72dbe5af0982"
>> +
>> +EXCLUDE_FROM_WORLD = "1"
>> diff --git a/meta-oe/recipes-support/fftw/fftwl_3.3.4.bb b/meta-oe/recipes-support/fftw/fftwl_3.3.4.bb
>> index 8f37346..a56bbc8 100644
>> --- a/meta-oe/recipes-support/fftw/fftwl_3.3.4.bb
>> +++ b/meta-oe/recipes-support/fftw/fftwl_3.3.4.bb
>> @@ -4,3 +4,5 @@ EXTRA_OECONF += "--enable-long-double"
>>
>>   SRC_URI[md5sum] = "2edab8c06b24feeb3b82bbb3ebf3e7b3"
>>   SRC_URI[sha256sum] = "8f0cde90929bc05587c3368d2f15cd0530a60b8a9912a8e2979a72dbe5af0982"
>> +
>> +EXCLUDE_FROM_WORLD = "1"
>> --
>> 1.7.9.5
>>
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
>
>

Re: [meta-oe] [PATCH] fftwf and fftwl: exclude them from world

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Yang schreef op 09-07-14 12:21:
> 
> 
> On 07/09/2014 05:55 PM, Martin Jansa wrote:
>> On Tue, Jul 08, 2014 at 11:18:47PM -0700, Robert Yang wrote:
>>> The fftw, fftwf and fftwl provide the same files (different
>>> contents), we should only build one of them, otherwise there would be
>>> warning
>>> 
>>> WARNING: The recipe fftw is trying to install files into a shared
>>> area when those files already exist. Those files and their manifest
>>> location are: sysroots/qemux86-64/usr/include/fftw3.f03 Matched in
>>> manifest-qemux86-64-fftwl.populate_sysroot 
>>> manifest-qemux86-64-fftwf.populate_sysroot 
>>> sysroots/qemux86-64/usr/include/fftw3.h Matched in
>>> manifest-qemux86-64-fftwl.populate_sysroot 
>>> manifest-qemux86-64-fftwf.populate_sysroot 
>>> sysroots/qemux86-64/usr/include/fftw3q.f03 Matched in
>>> manifest-qemux86-64-fftwl.populate_sysroot 
>>> manifest-qemux86-64-fftwf.populate_sysroot 
>>> sysroots/qemux86-64/usr/include/fftw3.f Matched in
>>> manifest-qemux86-64-fftwl.populate_sysroot 
>>> manifest-qemux86-64-fftwf.populate_sysroot 
>>> sysroots/qemux86-64/usr/include/fftw3l.f03 Matched in
>>> manifest-qemux86-64-fftwl.populate_sysroot 
>>> manifest-qemux86-64-fftwf.populate_sysroot Please verify which
>>> package should provide the above files.
>>> 
>>> and maybe errors (race issue):
>>> 
>>> The recipe imagemagick.do_compiler error: fourier.c:69:19: fatal
>>> error: fftw3.h: No such file or directory #include <fftw3.h>
>>> 
>>> This is because imagemagick.do_configure depends on
>>> fftw.populate_sysroot, but the files installed by
>>> fftw.populate_sysroot, maybe removed by fftwl or fftwf when they
>>> rebuild.
>>> 
>>> Only build fftw in the world will fix the problem.
>> 
>> But it doesn't fix the problem for people who are really building
>> fftwl and fftw. If there is someone with this use-case can he send
>> patch moving common parts to separate recipe used by all 3 or just
>> rename/move files to have unique name?
>> 
>> Or if they aren't needed at the same time, lets convert fftwl and
>> fftwf to PACKAGECONFIG options in fftw.
> 
> Yes, I think that PACKAGECONFIG is a good idea, will send patches
> tomorrow if no objections.

The original idea of the different packages was that you could have all the
libraries in the binary feeds since they are needed. With packageconfig that
becomes virtually impossible.
I don't have a suggestion to improve the current situation, though :(

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFTvmG+MkyGM64RGpERAu1zAJsGXdlezcHjV4JFjhTj9zeSaJ271ACdERQE
Xye89UlN8wZ3HEmV0fNGYMQ=
=iZI9
-----END PGP SIGNATURE-----

Re: [meta-oe] [PATCH] fftwf and fftwl: exclude them from world

[Robert Yang]

On 07/10/2014 05:49 PM, Koen Kooi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Robert Yang schreef op 09-07-14 12:21:
>>
>>
>> On 07/09/2014 05:55 PM, Martin Jansa wrote:
>>> On Tue, Jul 08, 2014 at 11:18:47PM -0700, Robert Yang wrote:
>>>> The fftw, fftwf and fftwl provide the same files (different
>>>> contents), we should only build one of them, otherwise there would be
>>>> warning
>>>>
>>>> WARNING: The recipe fftw is trying to install files into a shared
>>>> area when those files already exist. Those files and their manifest
>>>> location are: sysroots/qemux86-64/usr/include/fftw3.f03 Matched in
>>>> manifest-qemux86-64-fftwl.populate_sysroot
>>>> manifest-qemux86-64-fftwf.populate_sysroot
>>>> sysroots/qemux86-64/usr/include/fftw3.h Matched in
>>>> manifest-qemux86-64-fftwl.populate_sysroot
>>>> manifest-qemux86-64-fftwf.populate_sysroot
>>>> sysroots/qemux86-64/usr/include/fftw3q.f03 Matched in
>>>> manifest-qemux86-64-fftwl.populate_sysroot
>>>> manifest-qemux86-64-fftwf.populate_sysroot
>>>> sysroots/qemux86-64/usr/include/fftw3.f Matched in
>>>> manifest-qemux86-64-fftwl.populate_sysroot
>>>> manifest-qemux86-64-fftwf.populate_sysroot
>>>> sysroots/qemux86-64/usr/include/fftw3l.f03 Matched in
>>>> manifest-qemux86-64-fftwl.populate_sysroot
>>>> manifest-qemux86-64-fftwf.populate_sysroot Please verify which
>>>> package should provide the above files.
>>>>
>>>> and maybe errors (race issue):
>>>>
>>>> The recipe imagemagick.do_compiler error: fourier.c:69:19: fatal
>>>> error: fftw3.h: No such file or directory #include <fftw3.h>
>>>>
>>>> This is because imagemagick.do_configure depends on
>>>> fftw.populate_sysroot, but the files installed by
>>>> fftw.populate_sysroot, maybe removed by fftwl or fftwf when they
>>>> rebuild.
>>>>
>>>> Only build fftw in the world will fix the problem.
>>>
>>> But it doesn't fix the problem for people who are really building
>>> fftwl and fftw. If there is someone with this use-case can he send
>>> patch moving common parts to separate recipe used by all 3 or just
>>> rename/move files to have unique name?
>>>
>>> Or if they aren't needed at the same time, lets convert fftwl and
>>> fftwf to PACKAGECONFIG options in fftw.
>>
>> Yes, I think that PACKAGECONFIG is a good idea, will send patches
>> tomorrow if no objections.
>
> The original idea of the different packages was that you could have all the
> libraries in the binary feeds since they are needed. With packageconfig that
> becomes virtually impossible.
> I don't have a suggestion to improve the current situation, though :(

The race issue is painful since we don't know when it would happen,
I think that exclude two of them from world can reduce the race issue
for most of the users, for the user who build or install 3 of them
for the same image, we don't know how to fix it, but we already have
the warning for that.

// Robert

>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Darwin)
> Comment: GPGTools - http://gpgtools.org
>
> iD8DBQFTvmG+MkyGM64RGpERAu1zAJsGXdlezcHjV4JFjhTj9zeSaJ271ACdERQE
> Xye89UlN8wZ3HEmV0fNGYMQ=
> =iZI9
> -----END PGP SIGNATURE-----
>