* [PATCH v2 0/1] Fix for YB6498 @ 2014-07-10 13:13 Roxana Ciobanu 2014-07-10 13:13 ` [PATCH v2 1/1] latencytop: fix mount error Roxana Ciobanu 0 siblings, 1 reply; 5+ messages in thread From: Roxana Ciobanu @ 2014-07-10 13:13 UTC (permalink / raw) To: openembedded-core The following changes since commit 6879c3c903ec7d08cf0240281c83d85b4a42b6db: maintainers.inc: add info for libical (2014-07-08 11:20:14 +0100) are available in the git repository at: git://git.yoctoproject.org/poky-contrib roxana/YB6498 http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=roxana/YB6498 Roxana Ciobanu (1): latencytop: fix mount error .../latencytop/latencytop-0.5/latencytop-fsync-mount.patch | 13 +++++++++++++ meta/recipes-kernel/latencytop/latencytop_0.5.bb | 5 +++-- 2 files changed, 16 insertions(+), 2 deletions(-) create mode 100644 meta/recipes-kernel/latencytop/latencytop-0.5/latencytop-fsync-mount.patch -- 1.9.1 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 1/1] latencytop: fix mount error 2014-07-10 13:13 [PATCH v2 0/1] Fix for YB6498 Roxana Ciobanu @ 2014-07-10 13:13 ` Roxana Ciobanu 2014-07-10 13:50 ` Saul Wold 0 siblings, 1 reply; 5+ messages in thread From: Roxana Ciobanu @ 2014-07-10 13:13 UTC (permalink / raw) To: openembedded-core Bug was fixed by redirecting stderr to /dev/null. The error was caused because /sys/kernel/debug was already mounted by sysfs.sh. [ YOCTO #6498 ] Signed-off-by: Roxana Ciobanu <roxana.ciobanu@intel.com> --- .../latencytop/latencytop-0.5/latencytop-fsync-mount.patch | 13 +++++++++++++ meta/recipes-kernel/latencytop/latencytop_0.5.bb | 5 +++-- 2 files changed, 16 insertions(+), 2 deletions(-) create mode 100644 meta/recipes-kernel/latencytop/latencytop-0.5/latencytop-fsync-mount.patch diff --git a/meta/recipes-kernel/latencytop/latencytop-0.5/latencytop-fsync-mount.patch b/meta/recipes-kernel/latencytop/latencytop-0.5/latencytop-fsync-mount.patch new file mode 100644 index 0000000..043be75 --- /dev/null +++ b/meta/recipes-kernel/latencytop/latencytop-0.5/latencytop-fsync-mount.patch @@ -0,0 +1,13 @@ +Index: latencytop-0.5/fsync.c +=================================================================== +--- latencytop-0.5.orig/fsync.c ++++ latencytop-0.5/fsync.c +@@ -151,7 +151,7 @@ int enable_fsync_tracer(void) + * echo ftrace_printk > iter_ctrl + * echo 1 > tracing_on + */ +- ret = system("/bin/mount -t debugfs none /sys/kernel/debug/"); ++ ret = system("/bin/mount -t debugfs none /sys/kernel/debug/ 2>/dev/null"); + if (!ret) + return -1; + write_to_file("/sys/kernel/debug/tracing/current_tracer", "fsync"); diff --git a/meta/recipes-kernel/latencytop/latencytop_0.5.bb b/meta/recipes-kernel/latencytop/latencytop_0.5.bb index 516e2c5..9a95b92 100644 --- a/meta/recipes-kernel/latencytop/latencytop_0.5.bb +++ b/meta/recipes-kernel/latencytop/latencytop_0.5.bb @@ -6,11 +6,12 @@ LIC_FILES_CHKSUM = "file://latencytop.c;endline=23;md5=ee9ea9b1415356e5734adad4a DEPENDS = "virtual/libintl ncurses glib-2.0 ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'gtk+', '', d)}" -PR = "r3" +PR = "r4" SRC_URI = "http://www.latencytop.org/download/latencytop-${PV}.tar.gz \ file://latencytop-makefile.patch \ - file://latencytop-fsync.patch" + file://latencytop-fsync.patch \ + file://latencytop-fsync-mount.patch" SRC_URI[md5sum] = "73bb3371c6ee0b0e68e25289027e865c" SRC_URI[sha256sum] = "9e7f72fbea7bd918e71212a1eabaad8488d2c602205d2e3c95d62cd57e9203ef" -- 1.9.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/1] latencytop: fix mount error 2014-07-10 13:13 ` [PATCH v2 1/1] latencytop: fix mount error Roxana Ciobanu @ 2014-07-10 13:50 ` Saul Wold 2014-07-10 14:46 ` Burton, Ross 0 siblings, 1 reply; 5+ messages in thread From: Saul Wold @ 2014-07-10 13:50 UTC (permalink / raw) To: Roxana Ciobanu, openembedded-core On 07/10/2014 06:13 AM, Roxana Ciobanu wrote: > Bug was fixed by redirecting stderr to /dev/null. The error was > caused because /sys/kernel/debug was already mounted by sysfs.sh. > > [ YOCTO #6498 ] > > Signed-off-by: Roxana Ciobanu <roxana.ciobanu@intel.com> > --- > .../latencytop/latencytop-0.5/latencytop-fsync-mount.patch | 13 +++++++++++++ > meta/recipes-kernel/latencytop/latencytop_0.5.bb | 5 +++-- > 2 files changed, 16 insertions(+), 2 deletions(-) > create mode 100644 meta/recipes-kernel/latencytop/latencytop-0.5/latencytop-fsync-mount.patch > > diff --git a/meta/recipes-kernel/latencytop/latencytop-0.5/latencytop-fsync-mount.patch b/meta/recipes-kernel/latencytop/latencytop-0.5/latencytop-fsync-mount.patch > new file mode 100644 > index 0000000..043be75 > --- /dev/null > +++ b/meta/recipes-kernel/latencytop/latencytop-0.5/latencytop-fsync-mount.patch This patch is missing a Signed-off-by: and an Upstream-Status. Have you sent email to the latencytop list? > @@ -0,0 +1,13 @@ > +Index: latencytop-0.5/fsync.c > +=================================================================== > +--- latencytop-0.5.orig/fsync.c > ++++ latencytop-0.5/fsync.c > +@@ -151,7 +151,7 @@ int enable_fsync_tracer(void) > + * echo ftrace_printk > iter_ctrl > + * echo 1 > tracing_on > + */ > +- ret = system("/bin/mount -t debugfs none /sys/kernel/debug/"); > ++ ret = system("/bin/mount -t debugfs none /sys/kernel/debug/ 2>/dev/null"); So this is masking the issue, not addressing it, but this will cause other true errors to be masked. I think Ross's suggestion of using stat() to check for the existance of a file in debugfs would be better. > + if (!ret) > + return -1; > + write_to_file("/sys/kernel/debug/tracing/current_tracer", "fsync"); > diff --git a/meta/recipes-kernel/latencytop/latencytop_0.5.bb b/meta/recipes-kernel/latencytop/latencytop_0.5.bb > index 516e2c5..9a95b92 100644 > --- a/meta/recipes-kernel/latencytop/latencytop_0.5.bb > +++ b/meta/recipes-kernel/latencytop/latencytop_0.5.bb > @@ -6,11 +6,12 @@ LIC_FILES_CHKSUM = "file://latencytop.c;endline=23;md5=ee9ea9b1415356e5734adad4a > > DEPENDS = "virtual/libintl ncurses glib-2.0 ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'gtk+', '', d)}" > > -PR = "r3" > +PR = "r4" > PR Bumps are not needed any more Sau! > SRC_URI = "http://www.latencytop.org/download/latencytop-${PV}.tar.gz \ > file://latencytop-makefile.patch \ > - file://latencytop-fsync.patch" > + file://latencytop-fsync.patch \ > + file://latencytop-fsync-mount.patch" > > SRC_URI[md5sum] = "73bb3371c6ee0b0e68e25289027e865c" > SRC_URI[sha256sum] = "9e7f72fbea7bd918e71212a1eabaad8488d2c602205d2e3c95d62cd57e9203ef" > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/1] latencytop: fix mount error 2014-07-10 13:50 ` Saul Wold @ 2014-07-10 14:46 ` Burton, Ross 2014-07-12 8:41 ` Paul Eggleton 0 siblings, 1 reply; 5+ messages in thread From: Burton, Ross @ 2014-07-10 14:46 UTC (permalink / raw) To: Saul Wold; +Cc: OE-core On 10 July 2014 14:50, Saul Wold <sgw@linux.intel.com> wrote: > I think Ross's suggestion of using stat() to check for the existance of a > file in debugfs would be better. At least one good way of checking if a directory is a mount point is to compare the device of / and /debug using stat(). For example: $ stat -c %d / 2049 $ stat -c %d /sys 13 Different devices, so /sys is a mount. Ross ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/1] latencytop: fix mount error 2014-07-10 14:46 ` Burton, Ross @ 2014-07-12 8:41 ` Paul Eggleton 0 siblings, 0 replies; 5+ messages in thread From: Paul Eggleton @ 2014-07-12 8:41 UTC (permalink / raw) To: Burton, Ross, Saul Wold; +Cc: openembedded-core On Thursday 10 July 2014 15:46:21 Burton, Ross wrote: > On 10 July 2014 14:50, Saul Wold <sgw@linux.intel.com> wrote: > > I think Ross's suggestion of using stat() to check for the existance of a > > file in debugfs would be better. > > At least one good way of checking if a directory is a mount point is > to compare the device of / and /debug using stat(). For example: > > $ stat -c %d / > 2049 > $ stat -c %d /sys > 13 > > Different devices, so /sys is a mount. This came up a while back in another context, and someone (Phil?) pointed out the "mountpoint" standard Unix command which does exactly this. Cheers, Paul -- Paul Eggleton Intel Open Source Technology Centre ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-07-12 8:41 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-07-10 13:13 [PATCH v2 0/1] Fix for YB6498 Roxana Ciobanu 2014-07-10 13:13 ` [PATCH v2 1/1] latencytop: fix mount error Roxana Ciobanu 2014-07-10 13:50 ` Saul Wold 2014-07-10 14:46 ` Burton, Ross 2014-07-12 8:41 ` Paul Eggleton
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.