From: Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org,
f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
santosh.shilimkar-l0cyMroinI0@public.gmane.org
Subject: Re: [PATCH 1/2] net: davinci_mdio: reuse for keystone2 arch
Date: Fri, 11 Jul 2014 13:24:52 +0300 [thread overview]
Message-ID: <53BFBB74.80104@ti.com> (raw)
In-Reply-To: <20140710.123900.1696373067218564684.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
On 07/10/2014 10:39 PM, David Miller wrote:
> From: Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org>
> Date: Thu, 10 Jul 2014 15:58:31 +0300
>
>> Hi David,
>>
>> On 07/10/2014 02:52 AM, David Miller wrote:
>>> From: Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org>
>>> Date: Wed, 9 Jul 2014 16:10:50 +0300
>>>
>>>> Required properties:
>>>> -- compatible : Should be "ti,davinci_mdio"
>>>> +- compatible : Should be "ti,davinci_mdio" or "ti,keystone-mdio"
>>>
>>> Why the inconsistency in naming schemes? I don't see any reason
>>> to be different wrt. "_" vs. "-" in the name string.
>>>
>>
>> Hm. Looks like the common way is to use "-", but I can rename it if you insist.
>
> I'm just saying, is there a strong reason to be inconsistent?
>
I've followed the same format as for all latest compatibility strings in
Kernel. Also I've checked ePAPR and dash is used for all examples there.
"ti,davinci_mdio" was added 2 years ago, so possibly no strict
convention or review were done then. Now, I can't change
"ti,davinci_mdio" -> "ti,davinci-mdio" to be consistent with Kernel due
to compatibility issues.
May be DT Gurus can say more?
Regards,
-grygorii
WARNING: multiple messages have this Message-ID (diff)
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: David Miller <davem@davemloft.net>, <devicetree@vger.kernel.org>
Cc: <f.fainelli@gmail.com>, <santosh.shilimkar@ti.com>,
<netdev@vger.kernel.org>, <prabhakar.csengg@gmail.com>,
<nsekhar@ti.com>, <robh+dt@kernel.org>,
<linux-kernel@vger.kernel.org>,
<davinci-linux-open-source@linux.davincidsp.com>
Subject: Re: [PATCH 1/2] net: davinci_mdio: reuse for keystone2 arch
Date: Fri, 11 Jul 2014 13:24:52 +0300 [thread overview]
Message-ID: <53BFBB74.80104@ti.com> (raw)
In-Reply-To: <20140710.123900.1696373067218564684.davem@davemloft.net>
On 07/10/2014 10:39 PM, David Miller wrote:
> From: Grygorii Strashko <grygorii.strashko@ti.com>
> Date: Thu, 10 Jul 2014 15:58:31 +0300
>
>> Hi David,
>>
>> On 07/10/2014 02:52 AM, David Miller wrote:
>>> From: Grygorii Strashko <grygorii.strashko@ti.com>
>>> Date: Wed, 9 Jul 2014 16:10:50 +0300
>>>
>>>> Required properties:
>>>> -- compatible : Should be "ti,davinci_mdio"
>>>> +- compatible : Should be "ti,davinci_mdio" or "ti,keystone-mdio"
>>>
>>> Why the inconsistency in naming schemes? I don't see any reason
>>> to be different wrt. "_" vs. "-" in the name string.
>>>
>>
>> Hm. Looks like the common way is to use "-", but I can rename it if you insist.
>
> I'm just saying, is there a strong reason to be inconsistent?
>
I've followed the same format as for all latest compatibility strings in
Kernel. Also I've checked ePAPR and dash is used for all examples there.
"ti,davinci_mdio" was added 2 years ago, so possibly no strict
convention or review were done then. Now, I can't change
"ti,davinci_mdio" -> "ti,davinci-mdio" to be consistent with Kernel due
to compatibility issues.
May be DT Gurus can say more?
Regards,
-grygorii
WARNING: multiple messages have this Message-ID (diff)
From: Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: <davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org>,
<f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
<santosh.shilimkar-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH 1/2] net: davinci_mdio: reuse for keystone2 arch
Date: Fri, 11 Jul 2014 13:24:52 +0300 [thread overview]
Message-ID: <53BFBB74.80104@ti.com> (raw)
In-Reply-To: <20140710.123900.1696373067218564684.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
On 07/10/2014 10:39 PM, David Miller wrote:
> From: Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org>
> Date: Thu, 10 Jul 2014 15:58:31 +0300
>
>> Hi David,
>>
>> On 07/10/2014 02:52 AM, David Miller wrote:
>>> From: Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org>
>>> Date: Wed, 9 Jul 2014 16:10:50 +0300
>>>
>>>> Required properties:
>>>> -- compatible : Should be "ti,davinci_mdio"
>>>> +- compatible : Should be "ti,davinci_mdio" or "ti,keystone-mdio"
>>>
>>> Why the inconsistency in naming schemes? I don't see any reason
>>> to be different wrt. "_" vs. "-" in the name string.
>>>
>>
>> Hm. Looks like the common way is to use "-", but I can rename it if you insist.
>
> I'm just saying, is there a strong reason to be inconsistent?
>
I've followed the same format as for all latest compatibility strings in
Kernel. Also I've checked ePAPR and dash is used for all examples there.
"ti,davinci_mdio" was added 2 years ago, so possibly no strict
convention or review were done then. Now, I can't change
"ti,davinci_mdio" -> "ti,davinci-mdio" to be consistent with Kernel due
to compatibility issues.
May be DT Gurus can say more?
Regards,
-grygorii
next prev parent reply other threads:[~2014-07-11 10:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 13:10 [PATCH 0/2] net: davinci_mdio: reuse for keystone2 arch Grygorii Strashko
2014-07-09 13:10 ` Grygorii Strashko
2014-07-09 13:10 ` [PATCH 1/2] " Grygorii Strashko
2014-07-09 13:10 ` Grygorii Strashko
2014-07-09 14:20 ` Santosh Shilimkar
2014-07-09 14:20 ` Santosh Shilimkar
2014-07-09 23:52 ` David Miller
2014-07-10 12:58 ` Grygorii Strashko
2014-07-10 12:58 ` Grygorii Strashko
[not found] ` <53BE8DF7.9090303-l0cyMroinI0@public.gmane.org>
2014-07-10 19:39 ` David Miller
2014-07-10 19:39 ` David Miller
[not found] ` <20140710.123900.1696373067218564684.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2014-07-11 10:24 ` Grygorii Strashko [this message]
2014-07-11 10:24 ` Grygorii Strashko
2014-07-11 10:24 ` Grygorii Strashko
[not found] ` <1404911451-9921-2-git-send-email-grygorii.strashko-l0cyMroinI0@public.gmane.org>
2014-07-11 5:03 ` Mugunthan V N
2014-07-11 5:03 ` Mugunthan V N
2014-07-11 5:03 ` Mugunthan V N
2014-07-09 13:10 ` [PATCH 2/2] net: davinci_mdio: allow to create phys from dt Grygorii Strashko
2014-07-09 13:10 ` Grygorii Strashko
[not found] ` <1404911451-9921-3-git-send-email-grygorii.strashko-l0cyMroinI0@public.gmane.org>
2014-07-09 14:23 ` Santosh Shilimkar
2014-07-09 14:23 ` Santosh Shilimkar
2014-07-09 14:23 ` Santosh Shilimkar
2014-07-10 13:15 ` Grygorii Strashko
2014-07-10 13:15 ` Grygorii Strashko
2014-07-11 5:05 ` Mugunthan V N
2014-07-11 5:05 ` Mugunthan V N
2014-07-11 5:05 ` Mugunthan V N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BFBB74.80104@ti.com \
--to=grygorii.strashko-l0cymroini0@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=santosh.shilimkar-l0cyMroinI0@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.