From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Sekhar Nori <nsekhar@ti.com>, Tony Lindgren <tony@atomide.com>
Cc: Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Nishanth Menon <nm@ti.com>, Felipe Balbi <balbi@ti.com>,
Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>,
Russell King <rmk+kernel@arm.linux.org.uk>
Subject: Re: [PATCH v2] ARM: OMAP2+: l2c: squelch warning dump on power control setting
Date: Mon, 14 Jul 2014 10:31:25 -0400 [thread overview]
Message-ID: <53C3E9BD.9010104@ti.com> (raw)
In-Reply-To: <d081bdbeebec0e7f2a292a11513f96375aa35bd4.1405343188.git.nsekhar@ti.com>
On Monday 14 July 2014 09:13 AM, Sekhar Nori wrote:
> On OMAP SOCs using PL310 controllers, power_ctrl register is not
> accessible from non-secure software even on PL310 versions which
> support it. The secure code takes care of setting it up correctly
> and power transitions are proven on these devices.
>
> For example, AM437x has L2C-310 version r3p3 and ROM code on that
> device does not support writing to L2C-310 power control register.
> The L2C driver, however, tries writing to this register for all
> revisions >= r3p0.
>
> This leads to a warning dump on boot which leads most users to believe
> that L2 cache is non-functional.
>
> Since the problem is understood, and cannot be addressed through
> software, replace the warning with a pr_info() while maintaining the
> WARN_ON() for other truly unexpected scenarios.
>
> Reported-by: Nishanth Menon <nm@ti.com>
> Tested-by: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
> ---
> Only description updated since v1
>
Thanks for update.
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
WARNING: multiple messages have this Message-ID (diff)
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: OMAP2+: l2c: squelch warning dump on power control setting
Date: Mon, 14 Jul 2014 10:31:25 -0400 [thread overview]
Message-ID: <53C3E9BD.9010104@ti.com> (raw)
In-Reply-To: <d081bdbeebec0e7f2a292a11513f96375aa35bd4.1405343188.git.nsekhar@ti.com>
On Monday 14 July 2014 09:13 AM, Sekhar Nori wrote:
> On OMAP SOCs using PL310 controllers, power_ctrl register is not
> accessible from non-secure software even on PL310 versions which
> support it. The secure code takes care of setting it up correctly
> and power transitions are proven on these devices.
>
> For example, AM437x has L2C-310 version r3p3 and ROM code on that
> device does not support writing to L2C-310 power control register.
> The L2C driver, however, tries writing to this register for all
> revisions >= r3p0.
>
> This leads to a warning dump on boot which leads most users to believe
> that L2 cache is non-functional.
>
> Since the problem is understood, and cannot be addressed through
> software, replace the warning with a pr_info() while maintaining the
> WARN_ON() for other truly unexpected scenarios.
>
> Reported-by: Nishanth Menon <nm@ti.com>
> Tested-by: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
> ---
> Only description updated since v1
>
Thanks for update.
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
next prev parent reply other threads:[~2014-07-14 14:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 13:13 [PATCH v2] ARM: OMAP2+: l2c: squelch warning dump on power control setting Sekhar Nori
2014-07-14 13:13 ` Sekhar Nori
2014-07-14 14:31 ` Santosh Shilimkar [this message]
2014-07-14 14:31 ` Santosh Shilimkar
2014-07-14 16:25 ` Tony Lindgren
2014-07-14 16:25 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C3E9BD.9010104@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.