All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Figa <t.figa@samsung.com>
To: Daniel Drake <drake@endlessm.com>, kgene.kim@samsung.com
Cc: linux-samsung-soc@vger.kernel.org, liquid.acid@gmx.net,
	m.szyprowski@samsung.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
Date: Wed, 16 Jul 2014 14:34:24 +0200	[thread overview]
Message-ID: <53C67150.3080208@samsung.com> (raw)
In-Reply-To: <1405500606-5752-1-git-send-email-drake@endlessm.com>

On 16.07.2014 10:50, Daniel Drake wrote:
> The ODROID kernel shows that the PMIC interrupt line is hooked up
> to pin GPX3-2.
> 
> This is needed for the max77686-irq driver to create the PMIC IRQ
> domain, which is needed by max77686-rtc.
> 
> Signed-off-by: Daniel Drake <drake@endlessm.com>
> ---
>  arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> index 6d6d23c..cb6f55f 100644
> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> @@ -148,6 +148,10 @@
>  
>  		max77686: pmic@09 {
>  			compatible = "maxim,max77686";
> +			interrupt-parent = <&gpx3>;
> +			interrupts = <2 0>;
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&max77686_irq>;
>  			reg = <0x09>;
>  			#clock-cells = <1>;
>  
> @@ -368,4 +372,11 @@
>  		samsung,pins = "gpx1-3";
>  		samsung,pin-pud = <0>;
>  	};
> +
> +	max77686_irq: max77686-irq {
> +		samsung,pins = "gpx3-2";
> +		samsung,pin-function = <0>;
> +		samsung,pin-pud = <0>;
> +		samsung,pin-drv = <0>;
> +	};
>  };
> 

Reviewed-by: Tomasz Figa <t.figa@samsung.com>

--
Best regards,
Tomasz

WARNING: multiple messages have this Message-ID (diff)
From: t.figa@samsung.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
Date: Wed, 16 Jul 2014 14:34:24 +0200	[thread overview]
Message-ID: <53C67150.3080208@samsung.com> (raw)
In-Reply-To: <1405500606-5752-1-git-send-email-drake@endlessm.com>

On 16.07.2014 10:50, Daniel Drake wrote:
> The ODROID kernel shows that the PMIC interrupt line is hooked up
> to pin GPX3-2.
> 
> This is needed for the max77686-irq driver to create the PMIC IRQ
> domain, which is needed by max77686-rtc.
> 
> Signed-off-by: Daniel Drake <drake@endlessm.com>
> ---
>  arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> index 6d6d23c..cb6f55f 100644
> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> @@ -148,6 +148,10 @@
>  
>  		max77686: pmic at 09 {
>  			compatible = "maxim,max77686";
> +			interrupt-parent = <&gpx3>;
> +			interrupts = <2 0>;
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&max77686_irq>;
>  			reg = <0x09>;
>  			#clock-cells = <1>;
>  
> @@ -368,4 +372,11 @@
>  		samsung,pins = "gpx1-3";
>  		samsung,pin-pud = <0>;
>  	};
> +
> +	max77686_irq: max77686-irq {
> +		samsung,pins = "gpx3-2";
> +		samsung,pin-function = <0>;
> +		samsung,pin-pud = <0>;
> +		samsung,pin-drv = <0>;
> +	};
>  };
> 

Reviewed-by: Tomasz Figa <t.figa@samsung.com>

--
Best regards,
Tomasz

  parent reply	other threads:[~2014-07-16 12:35 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-16  8:50 [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID Daniel Drake
2014-07-16  8:50 ` Daniel Drake
2014-07-16  8:50 ` [PATCH 2/2] ARM: dts: ODROID i2c improvements Daniel Drake
2014-07-16  8:50   ` Daniel Drake
2014-07-16 12:34   ` Tomasz Figa
2014-07-16 12:34     ` Tomasz Figa
2014-08-12 13:11   ` Tomeu Vizoso
2014-08-12 13:11     ` Tomeu Vizoso
2014-07-16 12:34 ` Tomasz Figa [this message]
2014-07-16 12:34   ` [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID Tomasz Figa
2014-08-12 13:06 ` Tomeu Vizoso
2014-08-12 13:06   ` Tomeu Vizoso
2014-08-18 16:43   ` Kukjin Kim
2014-08-18 16:43     ` Kukjin Kim
2014-08-19  9:57     ` Bartlomiej Zolnierkiewicz
2014-08-19  9:57       ` Bartlomiej Zolnierkiewicz
2014-08-19 10:15       ` Javier Martinez Canillas
2014-08-19 10:15         ` Javier Martinez Canillas
2014-08-19 20:18         ` Olof Johansson
2014-08-19 20:18           ` Olof Johansson
2014-08-22 10:39           ` Kukjin Kim
2014-08-22 10:39             ` Kukjin Kim
2014-08-24 18:32             ` Olof Johansson
2014-08-24 18:32               ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C67150.3080208@samsung.com \
    --to=t.figa@samsung.com \
    --cc=drake@endlessm.com \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=liquid.acid@gmx.net \
    --cc=m.szyprowski@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.