All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene.kim@samsung.com>
To: Tomeu Vizoso <tomeu@tomeuvizoso.net>
Cc: Daniel Drake <drake@endlessm.com>,
	liquid.acid@gmx.net, Kukjin Kim <kgene.kim@samsung.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,
	Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
Date: Mon, 18 Aug 2014 11:43:07 -0500	[thread overview]
Message-ID: <53F22D1B.4010900@samsung.com> (raw)
In-Reply-To: <CAAObsKAokjDmpVy5cm_iFD52bCq+3jYeGDWzACsmh-JKktyjDw@mail.gmail.com>

On 08/12/14 08:06, Tomeu Vizoso wrote:
> Tested on an Odroid-U2:
>
> Tested-by: Tomeu Vizoso<tomeu@tomeuvizoso.net>
>
> Thanks,
>
> Tomeu
>
>
> On 16 July 2014 10:50, Daniel Drake<drake@endlessm.com>  wrote:
>> The ODROID kernel shows that the PMIC interrupt line is hooked up
>> to pin GPX3-2.
>>
>> This is needed for the max77686-irq driver to create the PMIC IRQ
>> domain, which is needed by max77686-rtc.
>>
>> Signed-off-by: Daniel Drake<drake@endlessm.com>
>> ---
>>   arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>> index 6d6d23c..cb6f55f 100644
>> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>> @@ -148,6 +148,10 @@
>>
>>                  max77686: pmic@09 {
>>                          compatible = "maxim,max77686";
>> +                       interrupt-parent =<&gpx3>;
>> +                       interrupts =<2 0>;
>> +                       pinctrl-names = "default";
>> +                       pinctrl-0 =<&max77686_irq>;
>>                          reg =<0x09>;
>>                          #clock-cells =<1>;
>>
>> @@ -368,4 +372,11 @@
>>                  samsung,pins = "gpx1-3";
>>                  samsung,pin-pud =<0>;
>>          };
>> +
>> +       max77686_irq: max77686-irq {
>> +               samsung,pins = "gpx3-2";
>> +               samsung,pin-function =<0>;
>> +               samsung,pin-pud =<0>;
>> +               samsung,pin-drv =<0>;
>> +       };
>>   };

Thanks, applied this series.

- Kukjin

WARNING: multiple messages have this Message-ID (diff)
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID
Date: Mon, 18 Aug 2014 11:43:07 -0500	[thread overview]
Message-ID: <53F22D1B.4010900@samsung.com> (raw)
In-Reply-To: <CAAObsKAokjDmpVy5cm_iFD52bCq+3jYeGDWzACsmh-JKktyjDw@mail.gmail.com>

On 08/12/14 08:06, Tomeu Vizoso wrote:
> Tested on an Odroid-U2:
>
> Tested-by: Tomeu Vizoso<tomeu@tomeuvizoso.net>
>
> Thanks,
>
> Tomeu
>
>
> On 16 July 2014 10:50, Daniel Drake<drake@endlessm.com>  wrote:
>> The ODROID kernel shows that the PMIC interrupt line is hooked up
>> to pin GPX3-2.
>>
>> This is needed for the max77686-irq driver to create the PMIC IRQ
>> domain, which is needed by max77686-rtc.
>>
>> Signed-off-by: Daniel Drake<drake@endlessm.com>
>> ---
>>   arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>> index 6d6d23c..cb6f55f 100644
>> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>> @@ -148,6 +148,10 @@
>>
>>                  max77686: pmic at 09 {
>>                          compatible = "maxim,max77686";
>> +                       interrupt-parent =<&gpx3>;
>> +                       interrupts =<2 0>;
>> +                       pinctrl-names = "default";
>> +                       pinctrl-0 =<&max77686_irq>;
>>                          reg =<0x09>;
>>                          #clock-cells =<1>;
>>
>> @@ -368,4 +372,11 @@
>>                  samsung,pins = "gpx1-3";
>>                  samsung,pin-pud =<0>;
>>          };
>> +
>> +       max77686_irq: max77686-irq {
>> +               samsung,pins = "gpx3-2";
>> +               samsung,pin-function =<0>;
>> +               samsung,pin-pud =<0>;
>> +               samsung,pin-drv =<0>;
>> +       };
>>   };

Thanks, applied this series.

- Kukjin

  reply	other threads:[~2014-08-18 16:43 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-16  8:50 [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID Daniel Drake
2014-07-16  8:50 ` Daniel Drake
2014-07-16  8:50 ` [PATCH 2/2] ARM: dts: ODROID i2c improvements Daniel Drake
2014-07-16  8:50   ` Daniel Drake
2014-07-16 12:34   ` Tomasz Figa
2014-07-16 12:34     ` Tomasz Figa
2014-08-12 13:11   ` Tomeu Vizoso
2014-08-12 13:11     ` Tomeu Vizoso
2014-07-16 12:34 ` [PATCH 1/2] ARM: dts: Enable PMIC interrupts on ODROID Tomasz Figa
2014-07-16 12:34   ` Tomasz Figa
2014-08-12 13:06 ` Tomeu Vizoso
2014-08-12 13:06   ` Tomeu Vizoso
2014-08-18 16:43   ` Kukjin Kim [this message]
2014-08-18 16:43     ` Kukjin Kim
2014-08-19  9:57     ` Bartlomiej Zolnierkiewicz
2014-08-19  9:57       ` Bartlomiej Zolnierkiewicz
2014-08-19 10:15       ` Javier Martinez Canillas
2014-08-19 10:15         ` Javier Martinez Canillas
2014-08-19 20:18         ` Olof Johansson
2014-08-19 20:18           ` Olof Johansson
2014-08-22 10:39           ` Kukjin Kim
2014-08-22 10:39             ` Kukjin Kim
2014-08-24 18:32             ` Olof Johansson
2014-08-24 18:32               ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F22D1B.4010900@samsung.com \
    --to=kgene.kim@samsung.com \
    --cc=drake@endlessm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=liquid.acid@gmx.net \
    --cc=m.szyprowski@samsung.com \
    --cc=tomeu@tomeuvizoso.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.