From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] ARM: dts: add rk3288 dwc2 controller support
Date: Wed, 30 Jul 2014 21:55:38 +0400 [thread overview]
Message-ID: <53D9319A.9060407@cogentembedded.com> (raw)
In-Reply-To: <53D90CC4.9070009@cogentembedded.com>
On 07/30/2014 07:18 PM, Sergei Shtylyov wrote:
>> rk3288 has two kind of usb controller, this add the dwc2 controller
>> for otg and host1.
>> Controller can works with usb PHY default setting and Vbus on.
>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>> ---
>> arch/arm/boot/dts/rk3288.dtsi | 20 ++++++++++++++++++++
>> 1 file changed, 20 insertions(+)
>> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
>> index abc51f5..4309c4f 100644
>> --- a/arch/arm/boot/dts/rk3288.dtsi
>> +++ b/arch/arm/boot/dts/rk3288.dtsi
>> @@ -646,5 +646,25 @@
>> clock-names = "baudclk", "apb_pclk";
>> status = "disabled";
>> };
>> +
>> + usb_otg: dwc2 at ff580000 {
> The ePAPR standard [1] says:
> The name of a node should be somewhat generic, reflecting the function of the
> device and not its precise programming model. If appropriate, the name should
> be one of the following choices:
> [...]
> ? usb
>> + compatible = "rockchip,rk3288-usb", "rockchip,rk3066-usb",
>> + "snps,dwc2";
>> + reg = <0xff580000 0x40000>;
>> + interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cru HCLK_OTG0>;
>> + clock-names = "otg";
>> + status = "disabled";
>> + };
>> +
>> + usb_host1: dwc2 at ff540000 {
> Same here.
Oops, forgot to give the ePAPR link:
[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Kever Yang <kever.yang@rock-chips.com>,
heiko@sntech.de, robh+dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, rdunlap@infradead.org,
linux@arm.linux.org.uk, paulz@synopsys.com,
gregkh@linuxfoundation.org, mporter@linaro.org, kishon@ti.com,
balbi@ti.com
Cc: swarren@wwwdotorg.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
addy.ke@rock-chips.com, xjq@rock-chips.com, cf@rock-chips.com,
lyz@rock-chips.com, wulf@rock-chips.com, dianders@chromium.org,
olof@lixom.net, sonnyrao@chromium.org
Subject: Re: [PATCH 2/4] ARM: dts: add rk3288 dwc2 controller support
Date: Wed, 30 Jul 2014 21:55:38 +0400 [thread overview]
Message-ID: <53D9319A.9060407@cogentembedded.com> (raw)
In-Reply-To: <53D90CC4.9070009@cogentembedded.com>
On 07/30/2014 07:18 PM, Sergei Shtylyov wrote:
>> rk3288 has two kind of usb controller, this add the dwc2 controller
>> for otg and host1.
>> Controller can works with usb PHY default setting and Vbus on.
>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>> ---
>> arch/arm/boot/dts/rk3288.dtsi | 20 ++++++++++++++++++++
>> 1 file changed, 20 insertions(+)
>> diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi
>> index abc51f5..4309c4f 100644
>> --- a/arch/arm/boot/dts/rk3288.dtsi
>> +++ b/arch/arm/boot/dts/rk3288.dtsi
>> @@ -646,5 +646,25 @@
>> clock-names = "baudclk", "apb_pclk";
>> status = "disabled";
>> };
>> +
>> + usb_otg: dwc2@ff580000 {
> The ePAPR standard [1] says:
> The name of a node should be somewhat generic, reflecting the function of the
> device and not its precise programming model. If appropriate, the name should
> be one of the following choices:
> [...]
> • usb
>> + compatible = "rockchip,rk3288-usb", "rockchip,rk3066-usb",
>> + "snps,dwc2";
>> + reg = <0xff580000 0x40000>;
>> + interrupts = <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cru HCLK_OTG0>;
>> + clock-names = "otg";
>> + status = "disabled";
>> + };
>> +
>> + usb_host1: dwc2@ff540000 {
> Same here.
Oops, forgot to give the ePAPR link:
[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf
WBR, Sergei
next prev parent reply other threads:[~2014-07-30 17:55 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <963258>
2014-07-30 1:31 ` [PATCH 0/4] usb: dwc2: add suport for Rockchip dwc2 controller Kever Yang
2014-07-30 1:31 ` Kever Yang
2014-07-30 1:31 ` Kever Yang
2014-07-30 1:31 ` [PATCH 1/4] Documentation: dt-bindings: add dt binding info for Rockchip dwc2 Kever Yang
2014-07-30 1:31 ` Kever Yang
2014-07-30 3:54 ` Doug Anderson
2014-07-30 3:54 ` Doug Anderson
2014-07-30 15:46 ` Doug Anderson
2014-07-30 15:46 ` Doug Anderson
2014-07-30 18:53 ` Paul Zimmerman
2014-07-30 18:53 ` Paul Zimmerman
2014-07-30 22:29 ` Doug Anderson
2014-07-30 22:29 ` Doug Anderson
2014-07-30 22:39 ` Paul Zimmerman
2014-07-30 22:39 ` Paul Zimmerman
2014-07-30 1:34 ` [PATCH 2/4] ARM: dts: add rk3288 dwc2 controller support Kever Yang
2014-07-30 1:34 ` Kever Yang
2014-07-30 1:34 ` Kever Yang
2014-07-30 4:03 ` Doug Anderson
2014-07-30 4:03 ` Doug Anderson
2014-07-30 15:18 ` Sergei Shtylyov
2014-07-30 15:18 ` Sergei Shtylyov
2014-07-30 17:55 ` Sergei Shtylyov [this message]
2014-07-30 17:55 ` Sergei Shtylyov
2014-07-30 1:35 ` [PATCH 3/4] usb: dwc2: add compatible data for rockchip soc Kever Yang
2014-07-30 1:35 ` Kever Yang
2014-07-30 4:21 ` Doug Anderson
2014-07-30 4:21 ` Doug Anderson
2014-07-30 6:40 ` Kever Yang
2014-07-30 6:40 ` Kever Yang
2014-07-30 15:45 ` Doug Anderson
2014-07-30 15:45 ` Doug Anderson
2014-07-30 19:00 ` Paul Zimmerman
2014-07-30 19:00 ` Paul Zimmerman
2014-07-30 19:00 ` Paul Zimmerman
2014-07-30 1:35 ` [PATCH 4/4] usb: dwc2: add dr_mode support for dwc2 Kever Yang
2014-07-30 1:35 ` Kever Yang
2014-07-30 4:29 ` Doug Anderson
2014-07-30 4:29 ` Doug Anderson
2014-07-30 19:05 ` Paul Zimmerman
2014-07-30 19:05 ` Paul Zimmerman
2014-07-30 19:05 ` Paul Zimmerman
2014-07-31 0:29 ` [PATCH v2 0/2] Patches to add dr_mode " Kever Yang
2014-07-31 0:29 ` [PATCH v2 1/2] Documentation: dt-bindings: add dt binding info for dwc2 dr_mode Kever Yang
2014-07-31 4:00 ` Doug Anderson
2014-07-31 1:06 ` [PATCH v2 2/2] usb: dwc2: add dr_mode support for dwc2 Kever Yang
2014-07-31 7:07 ` Jingoo Han
2014-07-31 18:47 ` Paul Zimmerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D9319A.9060407@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.