From: peter.ujfalusi@ti.com (Peter Ujfalusi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] ARM: DTS: da850: Add node for edma0
Date: Fri, 1 Aug 2014 08:09:31 +0300 [thread overview]
Message-ID: <53DB210B.5010204@ti.com> (raw)
In-Reply-To: <53DA5230.1050200@cogentembedded.com>
On 07/31/2014 05:26 PM, Sergei Shtylyov wrote:
> On 07/31/2014 02:18 PM, Peter Ujfalusi wrote:
>
>> Add DT node for edma0.
>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> ---
>> arch/arm/boot/dts/da850.dtsi | 6 ++++++
>> 1 file changed, 6 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
>> index b695548dbb4e..41ce4e8bf227 100644
>> --- a/arch/arm/boot/dts/da850.dtsi
>> +++ b/arch/arm/boot/dts/da850.dtsi
>> @@ -150,6 +150,12 @@
>> };
>>
>> };
>> + edma0: edma at 01c00000 {
>> + compatible = "ti,edma3";
>> + reg = <0x0 0x10000>;
>
> Why the mismatch between the unit-address part of the node name and the
> "reg" property?
For some reason the whole da850 uses offset from 0x01c00000 for the SoC IPs.
The nodes are under 'soc' and that has the ranges attribute.
I do not really like this either.
>
>> + interrupts = <11 13 12>;
>> + #dma-cells = <1>;
>> + };
>
> WBR, Sergei
>
--
P?ter
WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org>
To: Sergei Shtylyov
<sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>,
nsekhar-l0cyMroinI0@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org,
linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 2/6] ARM: DTS: da850: Add node for edma0
Date: Fri, 1 Aug 2014 08:09:31 +0300 [thread overview]
Message-ID: <53DB210B.5010204@ti.com> (raw)
In-Reply-To: <53DA5230.1050200-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
On 07/31/2014 05:26 PM, Sergei Shtylyov wrote:
> On 07/31/2014 02:18 PM, Peter Ujfalusi wrote:
>
>> Add DT node for edma0.
>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org>
>> ---
>> arch/arm/boot/dts/da850.dtsi | 6 ++++++
>> 1 file changed, 6 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
>> index b695548dbb4e..41ce4e8bf227 100644
>> --- a/arch/arm/boot/dts/da850.dtsi
>> +++ b/arch/arm/boot/dts/da850.dtsi
>> @@ -150,6 +150,12 @@
>> };
>>
>> };
>> + edma0: edma@01c00000 {
>> + compatible = "ti,edma3";
>> + reg = <0x0 0x10000>;
>
> Why the mismatch between the unit-address part of the node name and the
> "reg" property?
For some reason the whole da850 uses offset from 0x01c00000 for the SoC IPs.
The nodes are under 'soc' and that has the ranges attribute.
I do not really like this either.
>
>> + interrupts = <11 13 12>;
>> + #dma-cells = <1>;
>> + };
>
> WBR, Sergei
>
--
Péter
WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
<nsekhar@ti.com>, <robh+dt@kernel.org>
Cc: <devicetree@vger.kernel.org>,
<davinci-linux-open-source@linux.davincidsp.com>,
<linux@arm.linux.org.uk>, <pawel.moll@arm.com>,
<khilman@deeprootsystems.com>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/6] ARM: DTS: da850: Add node for edma0
Date: Fri, 1 Aug 2014 08:09:31 +0300 [thread overview]
Message-ID: <53DB210B.5010204@ti.com> (raw)
In-Reply-To: <53DA5230.1050200@cogentembedded.com>
On 07/31/2014 05:26 PM, Sergei Shtylyov wrote:
> On 07/31/2014 02:18 PM, Peter Ujfalusi wrote:
>
>> Add DT node for edma0.
>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> ---
>> arch/arm/boot/dts/da850.dtsi | 6 ++++++
>> 1 file changed, 6 insertions(+)
>
>> diff --git a/arch/arm/boot/dts/da850.dtsi b/arch/arm/boot/dts/da850.dtsi
>> index b695548dbb4e..41ce4e8bf227 100644
>> --- a/arch/arm/boot/dts/da850.dtsi
>> +++ b/arch/arm/boot/dts/da850.dtsi
>> @@ -150,6 +150,12 @@
>> };
>>
>> };
>> + edma0: edma@01c00000 {
>> + compatible = "ti,edma3";
>> + reg = <0x0 0x10000>;
>
> Why the mismatch between the unit-address part of the node name and the
> "reg" property?
For some reason the whole da850 uses offset from 0x01c00000 for the SoC IPs.
The nodes are under 'soc' and that has the ranges attribute.
I do not really like this either.
>
>> + interrupts = <11 13 12>;
>> + #dma-cells = <1>;
>> + };
>
> WBR, Sergei
>
--
Péter
next prev parent reply other threads:[~2014-08-01 5:09 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 10:18 [PATCH 0/6] ARM: DT/davinci: Audio for da850-evm in DT boot Peter Ujfalusi
2014-07-31 10:18 ` Peter Ujfalusi
2014-07-31 10:18 ` Peter Ujfalusi
2014-07-31 10:18 ` [PATCH 1/6] ARM: davinci: da8xx-dt: add OF_DEV_AUXDATA entry for mcasp0 Peter Ujfalusi
2014-07-31 10:18 ` Peter Ujfalusi
2014-07-31 10:18 ` Peter Ujfalusi
2014-07-31 10:18 ` [PATCH 2/6] ARM: DTS: da850: Add node for edma0 Peter Ujfalusi
2014-07-31 10:18 ` Peter Ujfalusi
2014-07-31 10:18 ` Peter Ujfalusi
2014-07-31 14:26 ` Sergei Shtylyov
2014-07-31 14:26 ` Sergei Shtylyov
2014-07-31 14:26 ` Sergei Shtylyov
2014-08-01 5:09 ` Peter Ujfalusi [this message]
2014-08-01 5:09 ` Peter Ujfalusi
2014-08-01 5:09 ` Peter Ujfalusi
2014-08-01 6:18 ` Sekhar Nori
2014-08-01 6:18 ` Sekhar Nori
2014-08-01 6:18 ` Sekhar Nori
2014-07-31 10:18 ` [PATCH 3/6] ARM: DTS: da850: Add node for McASP Peter Ujfalusi
2014-07-31 10:18 ` Peter Ujfalusi
2014-07-31 10:18 ` Peter Ujfalusi
2014-07-31 10:18 ` [PATCH 4/6] ARM: DTS: da850-evm: Enable McASP via DT boot Peter Ujfalusi
2014-07-31 10:18 ` Peter Ujfalusi
2014-07-31 10:18 ` Peter Ujfalusi
2014-07-31 10:18 ` [PATCH 5/6] ARM: DTS: da850-evm: Add node for tlv320aic3106 codec Peter Ujfalusi
2014-07-31 10:18 ` Peter Ujfalusi
2014-07-31 10:18 ` Peter Ujfalusi
2014-07-31 14:24 ` Sergei Shtylyov
2014-07-31 14:24 ` Sergei Shtylyov
2014-07-31 14:24 ` Sergei Shtylyov
2014-08-01 5:22 ` Peter Ujfalusi
2014-08-01 5:22 ` Peter Ujfalusi
2014-08-01 5:22 ` Peter Ujfalusi
2014-08-01 12:49 ` Sergei Shtylyov
2014-08-01 12:49 ` Sergei Shtylyov
2014-08-01 12:49 ` Sergei Shtylyov
2014-08-01 13:02 ` Peter Ujfalusi
2014-08-01 13:02 ` Peter Ujfalusi
2014-08-01 13:02 ` Peter Ujfalusi
2014-08-01 13:13 ` Sergei Shtylyov
2014-08-01 13:13 ` Sergei Shtylyov
2014-08-01 13:34 ` Peter Ujfalusi
2014-08-01 13:34 ` Peter Ujfalusi
2014-08-01 13:34 ` Peter Ujfalusi
2014-08-04 9:09 ` Peter Ujfalusi
2014-08-04 9:09 ` Peter Ujfalusi
2014-08-04 9:09 ` Peter Ujfalusi
2014-07-31 10:18 ` [PATCH 6/6] ARM: DTS: da850-evm: Enable audio via simple-card Peter Ujfalusi
2014-07-31 10:18 ` Peter Ujfalusi
2014-07-31 10:18 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DB210B.5010204@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.