All of lore.kernel.org
 help / color / mirror / Atom feed
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] ARM: DTS: da850-evm: Add node for tlv320aic3106 codec
Date: Fri, 01 Aug 2014 16:49:46 +0400	[thread overview]
Message-ID: <53DB8CEA.9010902@cogentembedded.com> (raw)
In-Reply-To: <53DB240F.2030908@ti.com>

Hello.

On 01-08-2014 9:22, Peter Ujfalusi wrote:

>>> The board uses aic3106 for audio.

>>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>>> ---
>>>    arch/arm/boot/dts/da850-evm.dts | 14 ++++++++++++++
>>>    1 file changed, 14 insertions(+)

>>> diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
>>> index 09118c72e83f..b9ef2be0b145 100644
>>> --- a/arch/arm/boot/dts/da850-evm.dts
>>> +++ b/arch/arm/boot/dts/da850-evm.dts
>>> @@ -51,6 +51,20 @@
>>>                tps: tps at 48 {
>>>                    reg = <0x48>;
>>>                };
>>> +            tlv320aic3106: tlv320aic3106 at 1b {

[...]

>> Also, the ePAPR standard [1] says:

>> The name of a node should be somewhat generic, reflecting the function of the
>> device and not its precise programming model.

> True. This is why the node for the audio support is named as 'sound'. For the
> components, like in this case I do not see issue to call the audio codec with
> it's name.

    I do. We should follow the standard consistently. Why not call the node 
"sound-codec"?

WBR, Sergei

WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
To: Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org>,
	nsekhar-l0cyMroinI0@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org,
	linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
	pawel.moll-5wv7dgnIgG8@public.gmane.org,
	khilman-1D3HCaltpLuhEniVeURVKkEOCMrvLtNR@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 5/6] ARM: DTS: da850-evm: Add node for tlv320aic3106 codec
Date: Fri, 01 Aug 2014 16:49:46 +0400	[thread overview]
Message-ID: <53DB8CEA.9010902@cogentembedded.com> (raw)
In-Reply-To: <53DB240F.2030908-l0cyMroinI0@public.gmane.org>

Hello.

On 01-08-2014 9:22, Peter Ujfalusi wrote:

>>> The board uses aic3106 for audio.

>>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org>
>>> ---
>>>    arch/arm/boot/dts/da850-evm.dts | 14 ++++++++++++++
>>>    1 file changed, 14 insertions(+)

>>> diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
>>> index 09118c72e83f..b9ef2be0b145 100644
>>> --- a/arch/arm/boot/dts/da850-evm.dts
>>> +++ b/arch/arm/boot/dts/da850-evm.dts
>>> @@ -51,6 +51,20 @@
>>>                tps: tps@48 {
>>>                    reg = <0x48>;
>>>                };
>>> +            tlv320aic3106: tlv320aic3106@1b {

[...]

>> Also, the ePAPR standard [1] says:

>> The name of a node should be somewhat generic, reflecting the function of the
>> device and not its precise programming model.

> True. This is why the node for the audio support is named as 'sound'. For the
> components, like in this case I do not see issue to call the audio codec with
> it's name.

    I do. We should follow the standard consistently. Why not call the node 
"sound-codec"?

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>,
	nsekhar@ti.com, robh+dt@kernel.org
Cc: devicetree@vger.kernel.org,
	davinci-linux-open-source@linux.davincidsp.com,
	linux@arm.linux.org.uk, pawel.moll@arm.com,
	khilman@deeprootsystems.com, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/6] ARM: DTS: da850-evm: Add node for tlv320aic3106 codec
Date: Fri, 01 Aug 2014 16:49:46 +0400	[thread overview]
Message-ID: <53DB8CEA.9010902@cogentembedded.com> (raw)
In-Reply-To: <53DB240F.2030908@ti.com>

Hello.

On 01-08-2014 9:22, Peter Ujfalusi wrote:

>>> The board uses aic3106 for audio.

>>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>>> ---
>>>    arch/arm/boot/dts/da850-evm.dts | 14 ++++++++++++++
>>>    1 file changed, 14 insertions(+)

>>> diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
>>> index 09118c72e83f..b9ef2be0b145 100644
>>> --- a/arch/arm/boot/dts/da850-evm.dts
>>> +++ b/arch/arm/boot/dts/da850-evm.dts
>>> @@ -51,6 +51,20 @@
>>>                tps: tps@48 {
>>>                    reg = <0x48>;
>>>                };
>>> +            tlv320aic3106: tlv320aic3106@1b {

[...]

>> Also, the ePAPR standard [1] says:

>> The name of a node should be somewhat generic, reflecting the function of the
>> device and not its precise programming model.

> True. This is why the node for the audio support is named as 'sound'. For the
> components, like in this case I do not see issue to call the audio codec with
> it's name.

    I do. We should follow the standard consistently. Why not call the node 
"sound-codec"?

WBR, Sergei


  reply	other threads:[~2014-08-01 12:49 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-31 10:18 [PATCH 0/6] ARM: DT/davinci: Audio for da850-evm in DT boot Peter Ujfalusi
2014-07-31 10:18 ` Peter Ujfalusi
2014-07-31 10:18 ` Peter Ujfalusi
2014-07-31 10:18 ` [PATCH 1/6] ARM: davinci: da8xx-dt: add OF_DEV_AUXDATA entry for mcasp0 Peter Ujfalusi
2014-07-31 10:18   ` Peter Ujfalusi
2014-07-31 10:18   ` Peter Ujfalusi
2014-07-31 10:18 ` [PATCH 2/6] ARM: DTS: da850: Add node for edma0 Peter Ujfalusi
2014-07-31 10:18   ` Peter Ujfalusi
2014-07-31 10:18   ` Peter Ujfalusi
2014-07-31 14:26   ` Sergei Shtylyov
2014-07-31 14:26     ` Sergei Shtylyov
2014-07-31 14:26     ` Sergei Shtylyov
2014-08-01  5:09     ` Peter Ujfalusi
2014-08-01  5:09       ` Peter Ujfalusi
2014-08-01  5:09       ` Peter Ujfalusi
2014-08-01  6:18       ` Sekhar Nori
2014-08-01  6:18         ` Sekhar Nori
2014-08-01  6:18         ` Sekhar Nori
2014-07-31 10:18 ` [PATCH 3/6] ARM: DTS: da850: Add node for McASP Peter Ujfalusi
2014-07-31 10:18   ` Peter Ujfalusi
2014-07-31 10:18   ` Peter Ujfalusi
2014-07-31 10:18 ` [PATCH 4/6] ARM: DTS: da850-evm: Enable McASP via DT boot Peter Ujfalusi
2014-07-31 10:18   ` Peter Ujfalusi
2014-07-31 10:18   ` Peter Ujfalusi
2014-07-31 10:18 ` [PATCH 5/6] ARM: DTS: da850-evm: Add node for tlv320aic3106 codec Peter Ujfalusi
2014-07-31 10:18   ` Peter Ujfalusi
2014-07-31 10:18   ` Peter Ujfalusi
2014-07-31 14:24   ` Sergei Shtylyov
2014-07-31 14:24     ` Sergei Shtylyov
2014-07-31 14:24     ` Sergei Shtylyov
2014-08-01  5:22     ` Peter Ujfalusi
2014-08-01  5:22       ` Peter Ujfalusi
2014-08-01  5:22       ` Peter Ujfalusi
2014-08-01 12:49       ` Sergei Shtylyov [this message]
2014-08-01 12:49         ` Sergei Shtylyov
2014-08-01 12:49         ` Sergei Shtylyov
2014-08-01 13:02         ` Peter Ujfalusi
2014-08-01 13:02           ` Peter Ujfalusi
2014-08-01 13:02           ` Peter Ujfalusi
2014-08-01 13:13           ` Sergei Shtylyov
2014-08-01 13:13             ` Sergei Shtylyov
2014-08-01 13:34             ` Peter Ujfalusi
2014-08-01 13:34               ` Peter Ujfalusi
2014-08-01 13:34               ` Peter Ujfalusi
2014-08-04  9:09               ` Peter Ujfalusi
2014-08-04  9:09                 ` Peter Ujfalusi
2014-08-04  9:09                 ` Peter Ujfalusi
2014-07-31 10:18 ` [PATCH 6/6] ARM: DTS: da850-evm: Enable audio via simple-card Peter Ujfalusi
2014-07-31 10:18   ` Peter Ujfalusi
2014-07-31 10:18   ` Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53DB8CEA.9010902@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.