From: jy0922.shim@samsung.com (Joonyoung Shim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] media: s5p_mfc_dec: delete the redundant code
Date: Fri, 01 Aug 2014 19:57:06 +0900 [thread overview]
Message-ID: <53DB7282.4070806@samsung.com> (raw)
In-Reply-To: <1406884515-3250-1-git-send-email-panpan1.liu@samsung.com>
Hi,
On 08/01/2014 06:15 PM, panpan liu wrote:
> Because the api s5p_mfc_queue_setup has already realized the same function
>
> Signed-off-by: panpan liu <panpan1.liu@samsung.com>
> ---
> drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
>
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
> @@ -544,14 +544,7 @@ static int vidioc_reqbufs(struct file *file, void *priv,
> mfc_err("vb2_reqbufs on capture failed\n");
> return ret;
> }
> - if (reqbufs->count < ctx->pb_count) {
> - mfc_err("Not enough buffers allocated\n");
> - reqbufs->count = 0;
> - s5p_mfc_clock_on();
> - ret = vb2_reqbufs(&ctx->vq_dst, reqbufs);
> - s5p_mfc_clock_off();
> - return -ENOMEM;
> - }
> +
As Hans said, you should always check the latest upstream kernel. Why do
you post patches based on old kernel at ML continuously?
WARNING: multiple messages have this Message-ID (diff)
From: Joonyoung Shim <jy0922.shim@samsung.com>
To: panpan liu <panpan1.liu@samsung.com>,
kyungmin.park@samsung.com, k.debski@samsung.com,
jtp.park@samsung.com, mchehab@redhat.com
Cc: linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org
Subject: Re: [PATCH] media: s5p_mfc_dec: delete the redundant code
Date: Fri, 01 Aug 2014 19:57:06 +0900 [thread overview]
Message-ID: <53DB7282.4070806@samsung.com> (raw)
In-Reply-To: <1406884515-3250-1-git-send-email-panpan1.liu@samsung.com>
Hi,
On 08/01/2014 06:15 PM, panpan liu wrote:
> Because the api s5p_mfc_queue_setup has already realized the same function
>
> Signed-off-by: panpan liu <panpan1.liu@samsung.com>
> ---
> drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
>
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
> @@ -544,14 +544,7 @@ static int vidioc_reqbufs(struct file *file, void *priv,
> mfc_err("vb2_reqbufs on capture failed\n");
> return ret;
> }
> - if (reqbufs->count < ctx->pb_count) {
> - mfc_err("Not enough buffers allocated\n");
> - reqbufs->count = 0;
> - s5p_mfc_clock_on();
> - ret = vb2_reqbufs(&ctx->vq_dst, reqbufs);
> - s5p_mfc_clock_off();
> - return -ENOMEM;
> - }
> +
As Hans said, you should always check the latest upstream kernel. Why do
you post patches based on old kernel at ML continuously?
next prev parent reply other threads:[~2014-08-01 10:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 9:15 [PATCH] media: s5p_mfc_dec: delete the redundant code panpan liu
2014-08-01 9:15 ` panpan liu
2014-08-01 10:57 ` Joonyoung Shim [this message]
2014-08-01 10:57 ` Joonyoung Shim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DB7282.4070806@samsung.com \
--to=jy0922.shim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.