* [PATCH] media: s5p_mfc_dec: delete the redundant code
@ 2014-08-01 9:15 ` panpan liu
0 siblings, 0 replies; 4+ messages in thread
From: panpan liu @ 2014-08-01 9:15 UTC (permalink / raw)
To: linux-arm-kernel
Because the api s5p_mfc_queue_setup has already realized the same function
Signed-off-by: panpan liu <panpan1.liu@samsung.com>
---
drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
--- a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
@@ -544,14 +544,7 @@ static int vidioc_reqbufs(struct file *file, void *priv,
mfc_err("vb2_reqbufs on capture failed\n");
return ret;
}
- if (reqbufs->count < ctx->pb_count) {
- mfc_err("Not enough buffers allocated\n");
- reqbufs->count = 0;
- s5p_mfc_clock_on();
- ret = vb2_reqbufs(&ctx->vq_dst, reqbufs);
- s5p_mfc_clock_off();
- return -ENOMEM;
- }
+
ctx->total_dpb_count = reqbufs->count;
ret = s5p_mfc_hw_call(dev->mfc_ops, alloc_codec_buffers, ctx);
if (ret) {
--
1.7.9.5
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] media: s5p_mfc_dec: delete the redundant code
@ 2014-08-01 9:15 ` panpan liu
0 siblings, 0 replies; 4+ messages in thread
From: panpan liu @ 2014-08-01 9:15 UTC (permalink / raw)
To: kyungmin.park, k.debski, jtp.park, mchehab; +Cc: linux-arm-kernel, linux-media
Because the api s5p_mfc_queue_setup has already realized the same function
Signed-off-by: panpan liu <panpan1.liu@samsung.com>
---
drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
--- a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
@@ -544,14 +544,7 @@ static int vidioc_reqbufs(struct file *file, void *priv,
mfc_err("vb2_reqbufs on capture failed\n");
return ret;
}
- if (reqbufs->count < ctx->pb_count) {
- mfc_err("Not enough buffers allocated\n");
- reqbufs->count = 0;
- s5p_mfc_clock_on();
- ret = vb2_reqbufs(&ctx->vq_dst, reqbufs);
- s5p_mfc_clock_off();
- return -ENOMEM;
- }
+
ctx->total_dpb_count = reqbufs->count;
ret = s5p_mfc_hw_call(dev->mfc_ops, alloc_codec_buffers, ctx);
if (ret) {
--
1.7.9.5
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] media: s5p_mfc_dec: delete the redundant code
2014-08-01 9:15 ` panpan liu
@ 2014-08-01 10:57 ` Joonyoung Shim
-1 siblings, 0 replies; 4+ messages in thread
From: Joonyoung Shim @ 2014-08-01 10:57 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On 08/01/2014 06:15 PM, panpan liu wrote:
> Because the api s5p_mfc_queue_setup has already realized the same function
>
> Signed-off-by: panpan liu <panpan1.liu@samsung.com>
> ---
> drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
>
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
> @@ -544,14 +544,7 @@ static int vidioc_reqbufs(struct file *file, void *priv,
> mfc_err("vb2_reqbufs on capture failed\n");
> return ret;
> }
> - if (reqbufs->count < ctx->pb_count) {
> - mfc_err("Not enough buffers allocated\n");
> - reqbufs->count = 0;
> - s5p_mfc_clock_on();
> - ret = vb2_reqbufs(&ctx->vq_dst, reqbufs);
> - s5p_mfc_clock_off();
> - return -ENOMEM;
> - }
> +
As Hans said, you should always check the latest upstream kernel. Why do
you post patches based on old kernel at ML continuously?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] media: s5p_mfc_dec: delete the redundant code
@ 2014-08-01 10:57 ` Joonyoung Shim
0 siblings, 0 replies; 4+ messages in thread
From: Joonyoung Shim @ 2014-08-01 10:57 UTC (permalink / raw)
To: panpan liu, kyungmin.park, k.debski, jtp.park, mchehab
Cc: linux-arm-kernel, linux-media
Hi,
On 08/01/2014 06:15 PM, panpan liu wrote:
> Because the api s5p_mfc_queue_setup has already realized the same function
>
> Signed-off-by: panpan liu <panpan1.liu@samsung.com>
> ---
> drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
>
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
> @@ -544,14 +544,7 @@ static int vidioc_reqbufs(struct file *file, void *priv,
> mfc_err("vb2_reqbufs on capture failed\n");
> return ret;
> }
> - if (reqbufs->count < ctx->pb_count) {
> - mfc_err("Not enough buffers allocated\n");
> - reqbufs->count = 0;
> - s5p_mfc_clock_on();
> - ret = vb2_reqbufs(&ctx->vq_dst, reqbufs);
> - s5p_mfc_clock_off();
> - return -ENOMEM;
> - }
> +
As Hans said, you should always check the latest upstream kernel. Why do
you post patches based on old kernel at ML continuously?
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-08-01 10:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-01 9:15 [PATCH] media: s5p_mfc_dec: delete the redundant code panpan liu
2014-08-01 9:15 ` panpan liu
2014-08-01 10:57 ` Joonyoung Shim
2014-08-01 10:57 ` Joonyoung Shim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.