Re: [PATCH] arch/sparc/math-emu/math_32.c: drop stray break operator

[walter harms <wharms@bfs.de>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1254", Size: 1620 bytes --]



Am 04.08.2014 22:47, schrieb Andrey Utkin:
> This commit is a guesswork, but it seems to make sense to drop this
> break, as otherwise the following line is never executed and becomes
> dead code. And that following line actually saves the result of
> local calculation by the pointer given in function argument. So the
> proposed change makes sense if this code in the whole makes sense (but I
> am unable to analyze it in the whole).
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id641
> Reported-by: David Binderman <dcb314@hotmail.com>
> Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
> ---
>  arch/sparc/math-emu/math_32.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/sparc/math-emu/math_32.c b/arch/sparc/math-emu/math_32.c
> index aa4d55b..5ce8f2f 100644
> --- a/arch/sparc/math-emu/math_32.c
> +++ b/arch/sparc/math-emu/math_32.c
> @@ -499,7 +499,7 @@ static int do_one_mathemu(u32 insn, unsigned long *pfsr, unsigned long *fregs)
>  		case 0: fsr = *pfsr;
>  			if (IR = -1) IR = 2;
>  			/* fcc is always fcc0 */

The patch looks ok, but can somebody comment on this comment ?
what "fcc" ? should it be a fsr ?


> -			fsr &= ~0xc00; fsr |= (IR << 10); break;
> +			fsr &= ~0xc00; fsr |= (IR << 10);

nitpicking:
   fsr &= ~0xc00;
   fsr |= (IR << 10);

It is better readable.

re,
 wh

>  			*pfsr = fsr;
>  			break;
>  		case 1: rd->s = IR; break;
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html