* [PATCH 1/1] v4l: Event documentation fixes
@ 2014-08-06 6:37 Sakari Ailus
2014-08-06 6:43 ` Hans Verkuil
0 siblings, 1 reply; 6+ messages in thread
From: Sakari Ailus @ 2014-08-06 6:37 UTC (permalink / raw)
To: linux-media
Constify event type constants and correct motion detection event number
(it's 6, not 5).
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
Documentation/DocBook/media/v4l/vidioc-dqevent.xml | 7 ++++---
Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml | 2 +-
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/Documentation/DocBook/media/v4l/vidioc-dqevent.xml b/Documentation/DocBook/media/v4l/vidioc-dqevent.xml
index cb77325..ce7e700 100644
--- a/Documentation/DocBook/media/v4l/vidioc-dqevent.xml
+++ b/Documentation/DocBook/media/v4l/vidioc-dqevent.xml
@@ -76,21 +76,22 @@
<entry></entry>
<entry>&v4l2-event-vsync;</entry>
<entry><structfield>vsync</structfield></entry>
- <entry>Event data for event V4L2_EVENT_VSYNC.
+ <entry>Event data for event <constant>V4L2_EVENT_VSYNC</constant>.
</entry>
</row>
<row>
<entry></entry>
<entry>&v4l2-event-ctrl;</entry>
<entry><structfield>ctrl</structfield></entry>
- <entry>Event data for event V4L2_EVENT_CTRL.
+ <entry>Event data for event <constant>V4L2_EVENT_CTRL</constant>.
</entry>
</row>
<row>
<entry></entry>
<entry>&v4l2-event-frame-sync;</entry>
<entry><structfield>frame_sync</structfield></entry>
- <entry>Event data for event V4L2_EVENT_FRAME_SYNC.</entry>
+ <entry>Event data for event <constant>V4L2_EVENT_FRAME_SYNC
+ </constant>.</entry>
</row>
<row>
<entry></entry>
diff --git a/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml b/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml
index 9f60956..d7c9365 100644
--- a/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml
+++ b/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml
@@ -176,7 +176,7 @@
</row>
<row>
<entry><constant>V4L2_EVENT_MOTION_DET</constant></entry>
- <entry>5</entry>
+ <entry>6</entry>
<entry>
<para>Triggered whenever the motion detection state for one or more of the regions
changes. This event has a &v4l2-event-motion-det; associated with it.</para>
--
1.8.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] v4l: Event documentation fixes
2014-08-06 6:37 [PATCH 1/1] v4l: Event documentation fixes Sakari Ailus
@ 2014-08-06 6:43 ` Hans Verkuil
2014-08-06 6:52 ` [PATCH v2 " Sakari Ailus
0 siblings, 1 reply; 6+ messages in thread
From: Hans Verkuil @ 2014-08-06 6:43 UTC (permalink / raw)
To: Sakari Ailus, linux-media
On 08/06/2014 08:37 AM, Sakari Ailus wrote:
> Constify event type constants and correct motion detection event number
> (it's 6, not 5).
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> Documentation/DocBook/media/v4l/vidioc-dqevent.xml | 7 ++++---
> Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml | 2 +-
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/DocBook/media/v4l/vidioc-dqevent.xml b/Documentation/DocBook/media/v4l/vidioc-dqevent.xml
> index cb77325..ce7e700 100644
> --- a/Documentation/DocBook/media/v4l/vidioc-dqevent.xml
> +++ b/Documentation/DocBook/media/v4l/vidioc-dqevent.xml
> @@ -76,21 +76,22 @@
> <entry></entry>
> <entry>&v4l2-event-vsync;</entry>
> <entry><structfield>vsync</structfield></entry>
> - <entry>Event data for event V4L2_EVENT_VSYNC.
> + <entry>Event data for event <constant>V4L2_EVENT_VSYNC</constant>.
> </entry>
> </row>
> <row>
> <entry></entry>
> <entry>&v4l2-event-ctrl;</entry>
> <entry><structfield>ctrl</structfield></entry>
> - <entry>Event data for event V4L2_EVENT_CTRL.
> + <entry>Event data for event <constant>V4L2_EVENT_CTRL</constant>.
> </entry>
> </row>
> <row>
> <entry></entry>
> <entry>&v4l2-event-frame-sync;</entry>
> <entry><structfield>frame_sync</structfield></entry>
> - <entry>Event data for event V4L2_EVENT_FRAME_SYNC.</entry>
> + <entry>Event data for event <constant>V4L2_EVENT_FRAME_SYNC
> + </constant>.</entry>
Keep </constant> next to V4L2_EVENT_FRAME_SYNC otherwise you will end up with
"V4L2_EVENT_FRAME_SYNC ." in the html output.
> </row>
> <row>
> <entry></entry>
> diff --git a/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml b/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml
> index 9f60956..d7c9365 100644
> --- a/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml
> +++ b/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml
> @@ -176,7 +176,7 @@
> </row>
> <row>
> <entry><constant>V4L2_EVENT_MOTION_DET</constant></entry>
> - <entry>5</entry>
> + <entry>6</entry>
Oops! My mistake.
> <entry>
> <para>Triggered whenever the motion detection state for one or more of the regions
> changes. This event has a &v4l2-event-motion-det; associated with it.</para>
>
Regards,
Hans
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/1] v4l: Event documentation fixes
2014-08-06 6:43 ` Hans Verkuil
@ 2014-08-06 6:52 ` Sakari Ailus
2014-08-06 6:58 ` Hans Verkuil
2014-08-07 6:50 ` Hans Verkuil
0 siblings, 2 replies; 6+ messages in thread
From: Sakari Ailus @ 2014-08-06 6:52 UTC (permalink / raw)
To: linux-media; +Cc: hverkuil
Constify event type constants and correct motion detection event number
(it's 6, not 5).
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
Thanks for the review, Hans!
Since v1:
- No line breaks between <constant> and </constant>. No other changes.
Documentation/DocBook/media/v4l/vidioc-dqevent.xml | 7 ++++---
Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml | 2 +-
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/Documentation/DocBook/media/v4l/vidioc-dqevent.xml b/Documentation/DocBook/media/v4l/vidioc-dqevent.xml
index cb77325..b036f89 100644
--- a/Documentation/DocBook/media/v4l/vidioc-dqevent.xml
+++ b/Documentation/DocBook/media/v4l/vidioc-dqevent.xml
@@ -76,21 +76,22 @@
<entry></entry>
<entry>&v4l2-event-vsync;</entry>
<entry><structfield>vsync</structfield></entry>
- <entry>Event data for event V4L2_EVENT_VSYNC.
+ <entry>Event data for event <constant>V4L2_EVENT_VSYNC</constant>.
</entry>
</row>
<row>
<entry></entry>
<entry>&v4l2-event-ctrl;</entry>
<entry><structfield>ctrl</structfield></entry>
- <entry>Event data for event V4L2_EVENT_CTRL.
+ <entry>Event data for event <constant>V4L2_EVENT_CTRL</constant>.
</entry>
</row>
<row>
<entry></entry>
<entry>&v4l2-event-frame-sync;</entry>
<entry><structfield>frame_sync</structfield></entry>
- <entry>Event data for event V4L2_EVENT_FRAME_SYNC.</entry>
+ <entry>Event data for event
+ <constant>V4L2_EVENT_FRAME_SYNC</constant>.</entry>
</row>
<row>
<entry></entry>
diff --git a/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml b/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml
index 9f60956..d7c9365 100644
--- a/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml
+++ b/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml
@@ -176,7 +176,7 @@
</row>
<row>
<entry><constant>V4L2_EVENT_MOTION_DET</constant></entry>
- <entry>5</entry>
+ <entry>6</entry>
<entry>
<para>Triggered whenever the motion detection state for one or more of the regions
changes. This event has a &v4l2-event-motion-det; associated with it.</para>
--
1.8.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/1] v4l: Event documentation fixes
2014-08-06 6:52 ` [PATCH v2 " Sakari Ailus
@ 2014-08-06 6:58 ` Hans Verkuil
2014-08-07 6:50 ` Hans Verkuil
1 sibling, 0 replies; 6+ messages in thread
From: Hans Verkuil @ 2014-08-06 6:58 UTC (permalink / raw)
To: Sakari Ailus, linux-media
On 08/06/2014 08:52 AM, Sakari Ailus wrote:
> Constify event type constants and correct motion detection event number
> (it's 6, not 5).
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Regards,
Hans
> ---
> Thanks for the review, Hans!
>
> Since v1:
>
> - No line breaks between <constant> and </constant>. No other changes.
>
> Documentation/DocBook/media/v4l/vidioc-dqevent.xml | 7 ++++---
> Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml | 2 +-
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/DocBook/media/v4l/vidioc-dqevent.xml b/Documentation/DocBook/media/v4l/vidioc-dqevent.xml
> index cb77325..b036f89 100644
> --- a/Documentation/DocBook/media/v4l/vidioc-dqevent.xml
> +++ b/Documentation/DocBook/media/v4l/vidioc-dqevent.xml
> @@ -76,21 +76,22 @@
> <entry></entry>
> <entry>&v4l2-event-vsync;</entry>
> <entry><structfield>vsync</structfield></entry>
> - <entry>Event data for event V4L2_EVENT_VSYNC.
> + <entry>Event data for event <constant>V4L2_EVENT_VSYNC</constant>.
> </entry>
> </row>
> <row>
> <entry></entry>
> <entry>&v4l2-event-ctrl;</entry>
> <entry><structfield>ctrl</structfield></entry>
> - <entry>Event data for event V4L2_EVENT_CTRL.
> + <entry>Event data for event <constant>V4L2_EVENT_CTRL</constant>.
> </entry>
> </row>
> <row>
> <entry></entry>
> <entry>&v4l2-event-frame-sync;</entry>
> <entry><structfield>frame_sync</structfield></entry>
> - <entry>Event data for event V4L2_EVENT_FRAME_SYNC.</entry>
> + <entry>Event data for event
> + <constant>V4L2_EVENT_FRAME_SYNC</constant>.</entry>
> </row>
> <row>
> <entry></entry>
> diff --git a/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml b/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml
> index 9f60956..d7c9365 100644
> --- a/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml
> +++ b/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml
> @@ -176,7 +176,7 @@
> </row>
> <row>
> <entry><constant>V4L2_EVENT_MOTION_DET</constant></entry>
> - <entry>5</entry>
> + <entry>6</entry>
> <entry>
> <para>Triggered whenever the motion detection state for one or more of the regions
> changes. This event has a &v4l2-event-motion-det; associated with it.</para>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/1] v4l: Event documentation fixes
2014-08-06 6:52 ` [PATCH v2 " Sakari Ailus
2014-08-06 6:58 ` Hans Verkuil
@ 2014-08-07 6:50 ` Hans Verkuil
2014-08-07 6:51 ` Hans Verkuil
1 sibling, 1 reply; 6+ messages in thread
From: Hans Verkuil @ 2014-08-07 6:50 UTC (permalink / raw)
To: Sakari Ailus, linux-media
On 08/06/2014 08:52 AM, Sakari Ailus wrote:
> Constify event type constants and correct motion detection event number
> (it's 6, not 5).
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
> ---
> Thanks for the review, Hans!
>
> Since v1:
>
> - No line breaks between <constant> and </constant>. No other changes.
>
> Documentation/DocBook/media/v4l/vidioc-dqevent.xml | 7 ++++---
> Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml | 2 +-
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/DocBook/media/v4l/vidioc-dqevent.xml b/Documentation/DocBook/media/v4l/vidioc-dqevent.xml
> index cb77325..b036f89 100644
> --- a/Documentation/DocBook/media/v4l/vidioc-dqevent.xml
> +++ b/Documentation/DocBook/media/v4l/vidioc-dqevent.xml
> @@ -76,21 +76,22 @@
> <entry></entry>
> <entry>&v4l2-event-vsync;</entry>
> <entry><structfield>vsync</structfield></entry>
> - <entry>Event data for event V4L2_EVENT_VSYNC.
> + <entry>Event data for event <constant>V4L2_EVENT_VSYNC</constant>.
> </entry>
> </row>
> <row>
> <entry></entry>
> <entry>&v4l2-event-ctrl;</entry>
> <entry><structfield>ctrl</structfield></entry>
> - <entry>Event data for event V4L2_EVENT_CTRL.
> + <entry>Event data for event <constant>V4L2_EVENT_CTRL</constant>.
> </entry>
> </row>
> <row>
> <entry></entry>
> <entry>&v4l2-event-frame-sync;</entry>
> <entry><structfield>frame_sync</structfield></entry>
> - <entry>Event data for event V4L2_EVENT_FRAME_SYNC.</entry>
> + <entry>Event data for event
> + <constant>V4L2_EVENT_FRAME_SYNC</constant>.</entry>
> </row>
> <row>
> <entry></entry>
> diff --git a/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml b/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml
> index 9f60956..d7c9365 100644
> --- a/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml
> +++ b/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml
> @@ -176,7 +176,7 @@
> </row>
> <row>
> <entry><constant>V4L2_EVENT_MOTION_DET</constant></entry>
> - <entry>5</entry>
> + <entry>6</entry>
> <entry>
> <para>Triggered whenever the motion detection state for one or more of the regions
> changes. This event has a &v4l2-event-motion-det; associated with it.</para>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/1] v4l: Event documentation fixes
2014-08-07 6:50 ` Hans Verkuil
@ 2014-08-07 6:51 ` Hans Verkuil
0 siblings, 0 replies; 6+ messages in thread
From: Hans Verkuil @ 2014-08-07 6:51 UTC (permalink / raw)
To: Sakari Ailus, linux-media
On 08/07/2014 08:50 AM, Hans Verkuil wrote:
> On 08/06/2014 08:52 AM, Sakari Ailus wrote:
>> Constify event type constants and correct motion detection event number
>> (it's 6, not 5).
>>
>> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
>
> Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Hmm, I did that already. Oh well, you can never have too many acks :-)
>
>> ---
>> Thanks for the review, Hans!
>>
>> Since v1:
>>
>> - No line breaks between <constant> and </constant>. No other changes.
>>
>> Documentation/DocBook/media/v4l/vidioc-dqevent.xml | 7 ++++---
>> Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml | 2 +-
>> 2 files changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/Documentation/DocBook/media/v4l/vidioc-dqevent.xml b/Documentation/DocBook/media/v4l/vidioc-dqevent.xml
>> index cb77325..b036f89 100644
>> --- a/Documentation/DocBook/media/v4l/vidioc-dqevent.xml
>> +++ b/Documentation/DocBook/media/v4l/vidioc-dqevent.xml
>> @@ -76,21 +76,22 @@
>> <entry></entry>
>> <entry>&v4l2-event-vsync;</entry>
>> <entry><structfield>vsync</structfield></entry>
>> - <entry>Event data for event V4L2_EVENT_VSYNC.
>> + <entry>Event data for event <constant>V4L2_EVENT_VSYNC</constant>.
>> </entry>
>> </row>
>> <row>
>> <entry></entry>
>> <entry>&v4l2-event-ctrl;</entry>
>> <entry><structfield>ctrl</structfield></entry>
>> - <entry>Event data for event V4L2_EVENT_CTRL.
>> + <entry>Event data for event <constant>V4L2_EVENT_CTRL</constant>.
>> </entry>
>> </row>
>> <row>
>> <entry></entry>
>> <entry>&v4l2-event-frame-sync;</entry>
>> <entry><structfield>frame_sync</structfield></entry>
>> - <entry>Event data for event V4L2_EVENT_FRAME_SYNC.</entry>
>> + <entry>Event data for event
>> + <constant>V4L2_EVENT_FRAME_SYNC</constant>.</entry>
>> </row>
>> <row>
>> <entry></entry>
>> diff --git a/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml b/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml
>> index 9f60956..d7c9365 100644
>> --- a/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml
>> +++ b/Documentation/DocBook/media/v4l/vidioc-subscribe-event.xml
>> @@ -176,7 +176,7 @@
>> </row>
>> <row>
>> <entry><constant>V4L2_EVENT_MOTION_DET</constant></entry>
>> - <entry>5</entry>
>> + <entry>6</entry>
>> <entry>
>> <para>Triggered whenever the motion detection state for one or more of the regions
>> changes. This event has a &v4l2-event-motion-det; associated with it.</para>
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-08-07 6:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-06 6:37 [PATCH 1/1] v4l: Event documentation fixes Sakari Ailus
2014-08-06 6:43 ` Hans Verkuil
2014-08-06 6:52 ` [PATCH v2 " Sakari Ailus
2014-08-06 6:58 ` Hans Verkuil
2014-08-07 6:50 ` Hans Verkuil
2014-08-07 6:51 ` Hans Verkuil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.