All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arend van Spriel <arend@broadcom.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: Ben Greear <greearb@candelatech.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	Dave Taht <dave.taht@gmail.com>,
	ath10k <ath10k@lists.infradead.org>,
	Franky Lin <frankyl@broadcom.com>
Subject: Re: Reporting firmware stats to ethtool
Date: Sat, 9 Aug 2014 09:30:01 +0200	[thread overview]
Message-ID: <53E5CDF9.4010008@broadcom.com> (raw)
In-Reply-To: <87vbq2uqdt.fsf@kamboji.qca.qualcomm.com>

On 08/09/2014 08:30 AM, Kalle Valo wrote:
> Arend van Spriel <arend@broadcom.com> writes:
>
>>>> I do kind of prefer 64 bit counters in the general case. Nuke it from
>>>> orbit, it's the only way to be sure.
>>>
>>> It's 64-bit to user-space, but that means nothing because firmware
>>> uses 32-bit (or even 16 bit in some cases, probably) internally.
>>> A great deal of counters are the same, so be very careful when
>>> trying to keep long term counters grabbed from firmware/drivers/hardware.
>>>
>>> And, stations come and go when you re-associate, so all sorts of wifi counters
>>> reset themselves all the time...
>>
>> Does ath driver notify mac80211 about firmware restart, ie. through
>> ieee80211_restart_hw().
>
> ath10k does use ieee80211_restart_hw().
>
>> If only user-space could get that info.
>
> Yeah, that would be nice to have for ath10k firmware crash dump
> functionality. And doesn't Android also need something similar?

Probably. bcmdhd seems to send a "firmware hang" event up to wpa_supp, 
which probably ends up in the android wifi framework through the control 
interface. Currently, this is a driver private event handled by 
wpa_supplicant_lib, but it seems trivial to me to add a nl80211 event to 
trigger that.

I am not sure what infrastructure your "ath10k firmware crash dump" is 
going to use. I have seen similar thing from Marvell recently [1] which 
relies on udev and ethtool to do the work. I guess aligning the 
solutions is why this topic is listed for the wireless breakout session 
at kernel summit in Chicago.

Regards,
Arend

[1] http://www.spinics.net/lists/linux-wireless/msg123943.html

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Arend van Spriel <arend@broadcom.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: Ben Greear <greearb@candelatech.com>,
	Dave Taht <dave.taht@gmail.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	ath10k <ath10k@lists.infradead.org>,
	Franky Lin <frankyl@broadcom.com>
Subject: Re: Reporting firmware stats to ethtool
Date: Sat, 9 Aug 2014 09:30:01 +0200	[thread overview]
Message-ID: <53E5CDF9.4010008@broadcom.com> (raw)
In-Reply-To: <87vbq2uqdt.fsf@kamboji.qca.qualcomm.com>

On 08/09/2014 08:30 AM, Kalle Valo wrote:
> Arend van Spriel <arend@broadcom.com> writes:
>
>>>> I do kind of prefer 64 bit counters in the general case. Nuke it from
>>>> orbit, it's the only way to be sure.
>>>
>>> It's 64-bit to user-space, but that means nothing because firmware
>>> uses 32-bit (or even 16 bit in some cases, probably) internally.
>>> A great deal of counters are the same, so be very careful when
>>> trying to keep long term counters grabbed from firmware/drivers/hardware.
>>>
>>> And, stations come and go when you re-associate, so all sorts of wifi counters
>>> reset themselves all the time...
>>
>> Does ath driver notify mac80211 about firmware restart, ie. through
>> ieee80211_restart_hw().
>
> ath10k does use ieee80211_restart_hw().
>
>> If only user-space could get that info.
>
> Yeah, that would be nice to have for ath10k firmware crash dump
> functionality. And doesn't Android also need something similar?

Probably. bcmdhd seems to send a "firmware hang" event up to wpa_supp, 
which probably ends up in the android wifi framework through the control 
interface. Currently, this is a driver private event handled by 
wpa_supplicant_lib, but it seems trivial to me to add a nl80211 event to 
trigger that.

I am not sure what infrastructure your "ath10k firmware crash dump" is 
going to use. I have seen similar thing from Marvell recently [1] which 
relies on udev and ethtool to do the work. I guess aligning the 
solutions is why this topic is listed for the wireless breakout session 
at kernel summit in Chicago.

Regards,
Arend

[1] http://www.spinics.net/lists/linux-wireless/msg123943.html

  reply	other threads:[~2014-08-09  7:30 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-07 21:57 Reporting firmware stats to ethtool Ben Greear
2014-08-07 21:57 ` Ben Greear
2014-08-08  9:06 ` Kalle Valo
2014-08-08  9:06   ` Kalle Valo
2014-08-08 15:42   ` Ben Greear
2014-08-08 15:42     ` Ben Greear
2014-08-08 15:55     ` Dave Taht
2014-08-08 15:55       ` Dave Taht
2014-08-08 16:11       ` Ben Greear
2014-08-08 16:11         ` Ben Greear
2014-08-08 16:45         ` Arend van Spriel
2014-08-08 16:45           ` Arend van Spriel
2014-08-08 17:24           ` Ben Greear
2014-08-08 17:24             ` Ben Greear
2014-08-09  6:32             ` Kalle Valo
2014-08-09  6:32               ` Kalle Valo
2014-08-09  6:30           ` Kalle Valo
2014-08-09  6:30             ` Kalle Valo
2014-08-09  7:30             ` Arend van Spriel [this message]
2014-08-09  7:30               ` Arend van Spriel
2014-08-09 15:56               ` Kalle Valo
2014-08-09 15:56                 ` Kalle Valo
2014-08-09  6:27     ` Kalle Valo
2014-08-09  6:27       ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53E5CDF9.4010008@broadcom.com \
    --to=arend@broadcom.com \
    --cc=ath10k@lists.infradead.org \
    --cc=dave.taht@gmail.com \
    --cc=frankyl@broadcom.com \
    --cc=greearb@candelatech.com \
    --cc=kvalo@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.