Re: [PATCH v6 3/4] x86/mem_event: Deliver gla fault EPT violation information

[Boris Ostrovsky <boris.ostrovsky@oracle.com>]

On 08/11/2014 10:48 AM, Tamas K Lengyel wrote:
> diff --git a/xen/arch/x86/mm/p2m.c b/xen/arch/x86/mm/p2m.c
> index 1f1f6cd..fe7b782 100644
> --- a/xen/arch/x86/mm/p2m.c
> +++ b/xen/arch/x86/mm/p2m.c
> @@ -1408,7 +1408,13 @@ bool_t p2m_mem_access_check(paddr_t gpa, unsigned long gla,
>           req->access_r = npfec.read_access;
>           req->access_w = npfec.write_access;
>           req->access_x = npfec.insn_fetch;
> -
> +        if ( npfec.npfec_kind == npfec_kind_with_gla )
> +            req->fault_with_gla = 1;
> +        else if ( npfec.npfec_kind == npfec_kind_in_gpt )
> +            req->fault_in_gpt = 1;
> +        req->access_r = npfec.read_access;
> +        req->access_w = npfec.write_access;
> +        req->access_x = npfec.insn_fetch;


You seem to be assigning req->access_? values twice.


-boris


>           req->vcpu_id = v->vcpu_id;
>       }
>