From: David Vrabel <david.vrabel@citrix.com>
To: Chen Baozi <baozich@gmail.com>,
David Vrabel <david.vrabel@citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Grall Julien <julien.grall@linaro.org>,
Campbell Ian <ian.campbell@citrix.com>,
List Developer Xen <xen-devel@lists.xen.org>
Subject: Re: Duplicated arch_gnttab_init breaks the arm64 kernel build
Date: Wed, 13 Aug 2014 10:31:56 +0100 [thread overview]
Message-ID: <53EB308C.7020505@citrix.com> (raw)
In-Reply-To: <0B60D476-C0E4-4AE8-9FF9-C16F65352C33@gmail.com>
On 13/08/14 03:04, Chen Baozi wrote:
> Hi David & Konrad,
>
> The current upstream kernel fails to build with Xen support because of duplicated
> arch_gnttab_init() definition:
>
> CC arch/arm64/xen/../../arm/xen/grant-table.o
> arch/arm64/xen/../../arm/xen/grant-table.c:53:5: error: conflicting types for ‘arch_gnttab_init’
> int arch_gnttab_init(unsigned long nr_shared, unsigned long nr_status)
> ^
> arch/arm64/xen/../../arm/xen/grant-table.c:48:5: note: previous definition of ‘arch_gnttab_init’ was here
> int arch_gnttab_init(unsigned long nr_shared)
> ^
> make[1]: *** [arch/arm64/xen/../../arm/xen/grant-table.o] Error 1
> make: *** [arch/arm64/xen] Error 2
>
> I looked through the current upstream kernel tree. It looks like arch_gnttab_init()
> is still be called in the older fashion (int arch_gnttab_init(unsigned long nr_shared)).
> So I doubt if the b7dd0e3 at this stage of time?
I have just sent a pull request including a fix for this.
Thanks.
David
prev parent reply other threads:[~2014-08-13 9:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 2:04 Duplicated arch_gnttab_init breaks the arm64 kernel build Chen Baozi
2014-08-13 2:15 ` Chen Baozi
2014-08-13 9:31 ` David Vrabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53EB308C.7020505@citrix.com \
--to=david.vrabel@citrix.com \
--cc=baozich@gmail.com \
--cc=ian.campbell@citrix.com \
--cc=julien.grall@linaro.org \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.