* Duplicated arch_gnttab_init breaks the arm64 kernel build
@ 2014-08-13 2:04 Chen Baozi
2014-08-13 2:15 ` Chen Baozi
2014-08-13 9:31 ` David Vrabel
0 siblings, 2 replies; 3+ messages in thread
From: Chen Baozi @ 2014-08-13 2:04 UTC (permalink / raw)
To: David Vrabel, Konrad Rzeszutek Wilk
Cc: Grall Julien, Campbell Ian, List Developer Xen
[-- Attachment #1.1: Type: text/plain, Size: 886 bytes --]
Hi David & Konrad,
The current upstream kernel fails to build with Xen support because of duplicated
arch_gnttab_init() definition:
CC arch/arm64/xen/../../arm/xen/grant-table.o
arch/arm64/xen/../../arm/xen/grant-table.c:53:5: error: conflicting types for ‘arch_gnttab_init’
int arch_gnttab_init(unsigned long nr_shared, unsigned long nr_status)
^
arch/arm64/xen/../../arm/xen/grant-table.c:48:5: note: previous definition of ‘arch_gnttab_init’ was here
int arch_gnttab_init(unsigned long nr_shared)
^
make[1]: *** [arch/arm64/xen/../../arm/xen/grant-table.o] Error 1
make: *** [arch/arm64/xen] Error 2
I looked through the current upstream kernel tree. It looks like arch_gnttab_init()
is still be called in the older fashion (int arch_gnttab_init(unsigned long nr_shared)).
So I doubt if the b7dd0e3 at this stage of time?
Cheers,
Baozi
[-- Attachment #1.2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 842 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Duplicated arch_gnttab_init breaks the arm64 kernel build
2014-08-13 2:04 Duplicated arch_gnttab_init breaks the arm64 kernel build Chen Baozi
@ 2014-08-13 2:15 ` Chen Baozi
2014-08-13 9:31 ` David Vrabel
1 sibling, 0 replies; 3+ messages in thread
From: Chen Baozi @ 2014-08-13 2:15 UTC (permalink / raw)
To: David Vrabel, Konrad Rzeszutek Wilk
Cc: Grall Julien, Campbell Ian, List Developer Xen
[-- Attachment #1.1: Type: text/plain, Size: 1604 bytes --]
On Aug 13, 2014, at 10:04, Chen Baozi <baozich@gmail.com> wrote:
> Hi David & Konrad,
>
> The current upstream kernel fails to build with Xen support because of duplicated
> arch_gnttab_init() definition:
>
> CC arch/arm64/xen/../../arm/xen/grant-table.o
> arch/arm64/xen/../../arm/xen/grant-table.c:53:5: error: conflicting types for ‘arch_gnttab_init’
> int arch_gnttab_init(unsigned long nr_shared, unsigned long nr_status)
> ^
> arch/arm64/xen/../../arm/xen/grant-table.c:48:5: note: previous definition of ‘arch_gnttab_init’ was here
> int arch_gnttab_init(unsigned long nr_shared)
> ^
> make[1]: *** [arch/arm64/xen/../../arm/xen/grant-table.o] Error 1
> make: *** [arch/arm64/xen] Error 2
>
> I looked through the current upstream kernel tree. It looks like arch_gnttab_init()
> is still be called in the older fashion (int arch_gnttab_init(unsigned long nr_shared)).
> So I doubt if the b7dd0e3 at this stage of time?
According to
$ git grep arch_gnttab_init
arch/arm/xen/grant-table.c:int arch_gnttab_init(unsigned long nr_shared)
arch/arm/xen/grant-table.c:int arch_gnttab_init(unsigned long nr_shared, unsigned long nr_status)
arch/x86/xen/grant-table.c:int arch_gnttab_init(unsigned long nr_shared)
drivers/xen/grant-table.c: ret = arch_gnttab_init(max_nr_grant_frames);
include/xen/grant_table.h:int arch_gnttab_init(unsigned long nr_shared);
Is it appropriate if just making a patch to delete the
arch_gnttab_init(unsigned long nr_shared, unsigned long nr_status) in
arch/arm/xen/grant-table.c?
>
> Cheers,
>
> Baozi
[-- Attachment #1.2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 842 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Duplicated arch_gnttab_init breaks the arm64 kernel build
2014-08-13 2:04 Duplicated arch_gnttab_init breaks the arm64 kernel build Chen Baozi
2014-08-13 2:15 ` Chen Baozi
@ 2014-08-13 9:31 ` David Vrabel
1 sibling, 0 replies; 3+ messages in thread
From: David Vrabel @ 2014-08-13 9:31 UTC (permalink / raw)
To: Chen Baozi, David Vrabel, Konrad Rzeszutek Wilk
Cc: Grall Julien, Campbell Ian, List Developer Xen
On 13/08/14 03:04, Chen Baozi wrote:
> Hi David & Konrad,
>
> The current upstream kernel fails to build with Xen support because of duplicated
> arch_gnttab_init() definition:
>
> CC arch/arm64/xen/../../arm/xen/grant-table.o
> arch/arm64/xen/../../arm/xen/grant-table.c:53:5: error: conflicting types for ‘arch_gnttab_init’
> int arch_gnttab_init(unsigned long nr_shared, unsigned long nr_status)
> ^
> arch/arm64/xen/../../arm/xen/grant-table.c:48:5: note: previous definition of ‘arch_gnttab_init’ was here
> int arch_gnttab_init(unsigned long nr_shared)
> ^
> make[1]: *** [arch/arm64/xen/../../arm/xen/grant-table.o] Error 1
> make: *** [arch/arm64/xen] Error 2
>
> I looked through the current upstream kernel tree. It looks like arch_gnttab_init()
> is still be called in the older fashion (int arch_gnttab_init(unsigned long nr_shared)).
> So I doubt if the b7dd0e3 at this stage of time?
I have just sent a pull request including a fix for this.
Thanks.
David
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-13 9:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-13 2:04 Duplicated arch_gnttab_init breaks the arm64 kernel build Chen Baozi
2014-08-13 2:15 ` Chen Baozi
2014-08-13 9:31 ` David Vrabel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.