All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
	Inki Dae <inki.dae@samsung.com>
Cc: Joerg Roedel <joro@8bytes.org>,
	iommu@lists.linux-foundation.org,
	linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linaro-mm-sig@lists.linaro.org,
	Arnd Bergmann <arnd@arndb.de>,
	Shaik Ameer Basha <shaik.ameer@samsung.com>,
	Cho KyongHo <pullip.cho@samsung.com>,
	Thierry Reding <treding@nvidia.com>,
	Olof Johansson <olof@lixom.net>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Rob Herring <robh@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Kukjin Kim <kgene.kim@samsung.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Tomasz Figa <tomasz.figa@gmail.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Ajay Kumar <ajaykumar.rs@samsung.com>
Subject: Re: [PATCH 00/29] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem
Date: Tue, 19 Aug 2014 14:30:59 +0200	[thread overview]
Message-ID: <53F34383.30100@suse.de> (raw)
In-Reply-To: <53F33C9C.1080601@samsung.com>

Hi,

Am 19.08.2014 14:01, schrieb Marek Szyprowski:
> On 2014-08-19 13:39, Andreas Färber wrote:
>> I'm working on 5250 based Spring Chromebook and noticed that v3.17-rc1
>> got some more iommu support. With the new CONFIG_DRM_EXYNOS_IOMMU=y my
>> machine stops booting. So I'm wondering, is any of this a fix for 3.17,
>> or is all of this "unrelated" -next material?
> 
> This is probably a side effect of patch
> 3170447c1f264d51b8d1f3898bf2588588a64fdc
> ("iommu/exynos: Select ARM_DMA_USE_IOMMU"). It added selection of
> ARM_DMA_USE_IOMMU
> symbol, on which IOMMU support in Exynos DRM subsystem depends. However
> selecting
> this symbol is all that this patch does, without providing any code code
> which
> implements real support for ARM DMA IOMMU integration, which is needed
> by Exynos
> DRM driver. Please disable CONFIG_DRM_EXYNOS_IOMMU in kernel .config and
> your
> system should be bootable again.

Yes, that's what my report implied. :)

I'm bringing this up for -rc2 though: It sounds as if that option should
remain unavailable until the required code is in? Thanks.

>> Also, are you or someone
>> working on the respective DT changes for Exynos5?
> 
> I can prepare DT changes for Exynos5 as well, but first I wanted to
> clarify if
> everyone involved in generic IOMMU bindings and Exynos IOMMU driver
> agrees on my
> proposal.

Sure. I'm updating my old spring-bridge.v6 branch [1] to 3.17-rc1 [2],
which involves three drm bridge patches rebased onto the new drm panel
prepare/unprepare infrastructure plus two LVDS DT patches in addition to
the IOMMU patches. That old branch included DT changes for 5250 in "ARM:
dts: add System MMU nodes of Exynos SoCs", but that'll probably need
updating for the new bindings.

Regards,
Andreas

[1] https://github.com/afaerber/linux/commits/spring-bridge.v6
[2] https://github.com/afaerber/linux/commits/spring-next

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

WARNING: multiple messages have this Message-ID (diff)
From: afaerber@suse.de (Andreas Färber)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 00/29] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem
Date: Tue, 19 Aug 2014 14:30:59 +0200	[thread overview]
Message-ID: <53F34383.30100@suse.de> (raw)
In-Reply-To: <53F33C9C.1080601@samsung.com>

Hi,

Am 19.08.2014 14:01, schrieb Marek Szyprowski:
> On 2014-08-19 13:39, Andreas F?rber wrote:
>> I'm working on 5250 based Spring Chromebook and noticed that v3.17-rc1
>> got some more iommu support. With the new CONFIG_DRM_EXYNOS_IOMMU=y my
>> machine stops booting. So I'm wondering, is any of this a fix for 3.17,
>> or is all of this "unrelated" -next material?
> 
> This is probably a side effect of patch
> 3170447c1f264d51b8d1f3898bf2588588a64fdc
> ("iommu/exynos: Select ARM_DMA_USE_IOMMU"). It added selection of
> ARM_DMA_USE_IOMMU
> symbol, on which IOMMU support in Exynos DRM subsystem depends. However
> selecting
> this symbol is all that this patch does, without providing any code code
> which
> implements real support for ARM DMA IOMMU integration, which is needed
> by Exynos
> DRM driver. Please disable CONFIG_DRM_EXYNOS_IOMMU in kernel .config and
> your
> system should be bootable again.

Yes, that's what my report implied. :)

I'm bringing this up for -rc2 though: It sounds as if that option should
remain unavailable until the required code is in? Thanks.

>> Also, are you or someone
>> working on the respective DT changes for Exynos5?
> 
> I can prepare DT changes for Exynos5 as well, but first I wanted to
> clarify if
> everyone involved in generic IOMMU bindings and Exynos IOMMU driver
> agrees on my
> proposal.

Sure. I'm updating my old spring-bridge.v6 branch [1] to 3.17-rc1 [2],
which involves three drm bridge patches rebased onto the new drm panel
prepare/unprepare infrastructure plus two LVDS DT patches in addition to
the IOMMU patches. That old branch included DT changes for 5250 in "ARM:
dts: add System MMU nodes of Exynos SoCs", but that'll probably need
updating for the new bindings.

Regards,
Andreas

[1] https://github.com/afaerber/linux/commits/spring-bridge.v6
[2] https://github.com/afaerber/linux/commits/spring-next

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend?rffer; HRB 16746 AG N?rnberg

  reply	other threads:[~2014-08-19 12:30 UTC|newest]

Thread overview: 127+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-05 10:47 [PATCH 00/29] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem Marek Szyprowski
2014-08-05 10:47 ` Marek Szyprowski
2014-08-05 10:47 ` [PATCH 01/29] pm: Add PM domain notifications Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47 ` [PATCH 02/29] ARM: Exynos: bind power domains earlier, on device creation Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47 ` [PATCH 03/29] clk: exynos: add missing smmu_g2d clock and update comments Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-18 11:26   ` Tomasz Figa
2014-08-18 11:26     ` Tomasz Figa
2014-08-05 10:47 ` [PATCH 04/29] drivers: base: add notifier for failed driver bind Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-21 19:46   ` Laurent Pinchart
2014-08-21 19:46     ` Laurent Pinchart
     [not found]   ` <1407235677-26324-5-git-send-email-m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-08-25 20:05     ` Greg Kroah-Hartman
2014-08-25 20:05       ` Greg Kroah-Hartman
2014-08-25 20:05       ` Greg Kroah-Hartman
     [not found]       ` <20140825200539.GA22076-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2014-08-26  6:23         ` Marek Szyprowski
2014-08-26  6:23           ` Marek Szyprowski
2014-08-26  6:23           ` Marek Szyprowski
2014-08-25 21:18     ` Joerg Roedel
2014-08-25 21:18       ` Joerg Roedel
2014-08-25 21:18       ` Joerg Roedel
     [not found]       ` <20140825211823.GH16329-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2014-08-26  6:30         ` Marek Szyprowski
2014-08-26  6:30           ` Marek Szyprowski
2014-08-26  6:30           ` Marek Szyprowski
2014-08-05 10:47 ` [PATCH 05/29] drivers: convert suppress_bind_attrs parameter into flags Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47 ` [PATCH 06/29] drivers: iommu: add notify about failed bind Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47 ` [PATCH 07/29] ARM: dma-mapping: arm_iommu_attach_device: automatically set max_seg_size Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47 ` [PATCH 08/29] ARM: dma-mapping: add helpers for managing default per-device dma mappings Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47 ` [PATCH 09/29] ARM: dma-mapping: provide stubs if no ARM_DMA_USE_IOMMU has been selected Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47 ` [PATCH 10/29] drivers: add DRIVER_HAS_OWN_IOMMU_MANAGER flag Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
     [not found]   ` <1407235677-26324-11-git-send-email-m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-09-01  5:22     ` Marek Szyprowski
2014-09-01  5:22       ` Marek Szyprowski
2014-09-01  5:22       ` Marek Szyprowski
2014-09-01  7:07       ` Thierry Reding
2014-09-01  7:07         ` Thierry Reding
2014-09-01  7:07         ` Thierry Reding
     [not found]         ` <20140901070748.GA24226-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2014-09-01  7:53           ` Marek Szyprowski
2014-09-01  7:53             ` Marek Szyprowski
2014-09-01  7:53             ` Marek Szyprowski
2014-09-01  9:38             ` Arnd Bergmann
2014-09-01  9:38               ` Arnd Bergmann
2014-09-01 10:47               ` Marek Szyprowski
2014-09-01 10:47                 ` Marek Szyprowski
     [not found]                 ` <54044EAC.6010701-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-09-01 11:56                   ` Arnd Bergmann
2014-09-01 11:56                     ` Arnd Bergmann
2014-09-01 11:56                     ` Arnd Bergmann
2014-09-01 12:07                     ` Marek Szyprowski
2014-09-01 12:07                       ` Marek Szyprowski
     [not found]                       ` <54046186.5030407-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-09-01 13:14                         ` [Linaro-mm-sig] " Arnd Bergmann
2014-09-01 13:14                           ` Arnd Bergmann
2014-09-01 13:14                           ` Arnd Bergmann
2014-08-05 10:47 ` [PATCH 11/29] DRM: exynos: add DRIVER_HAS_OWN_IOMMU_MANAGER flag to all sub-drivers Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47 ` [PATCH 12/29] DRM: Exynos: fix window clear code Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-09-01 13:37   ` Inki Dae
2014-09-01 13:37     ` Inki Dae
2014-08-05 10:47 ` [PATCH 13/29] temporary: media: s5p-mfc: remove DT hacks & initialization custom memory init code Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47 ` [PATCH 14/29] devicetree: Update Exynos SYSMMU device tree bindings Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47 ` [PATCH 15/29] ARM: DTS: Exynos4: add System MMU nodes Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47 ` [PATCH 16/29] iommu: exynos: make driver multiarch friendly Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47 ` [PATCH 17/29] iommu: exynos: don't read version register on every tlb operation Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47 ` [PATCH 18/29] iommu: exynos: remove unused functions Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47 ` [PATCH 19/29] iommu: exynos: remove useless spinlock Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47 ` [PATCH 20/29] iommu: exynos: refactor function parameters to simplify code Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47 ` [PATCH 21/29] iommu: exynos: remove unused functions, part 2 Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47 ` [PATCH 22/29] iommu: exynos: add support for binding more than one sysmmu to master device Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47 ` [PATCH 23/29] iommu: exynos: init iommu controllers from device tree Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47 ` [PATCH 24/29] iommu: exynos: create default iommu-based dma-mapping for master devices Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47 ` [PATCH 25/29] iommu: exynos: add support for runtime_pm Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47 ` [PATCH 26/29] iommu: exynos: rename variables to reflect their purpose Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47 ` [PATCH 27/29] iommu: exynos: document internal structures Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47 ` [PATCH 28/29] iommu: exynos: remove excessive includes and sort others alphabetically Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
2014-08-05 10:47 ` [PATCH 29/29] temporary: media: s5p-mfc: add support for IOMMU Marek Szyprowski
2014-08-05 10:47   ` Marek Szyprowski
     [not found] ` <1407235677-26324-1-git-send-email-m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-08-18 23:32   ` [PATCH 00/29] Exynos SYSMMU (IOMMU) integration with DT and DMA-mapping subsystem Joerg Roedel
2014-08-18 23:32     ` Joerg Roedel
2014-08-18 23:32     ` Joerg Roedel
     [not found]     ` <20140818233201.GL9809-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2014-08-19  6:07       ` Marek Szyprowski
2014-08-19  6:07         ` Marek Szyprowski
2014-08-19  6:07         ` Marek Szyprowski
2014-08-19 11:39         ` Andreas Färber
2014-08-19 11:39           ` Andreas Färber
     [not found]           ` <53F3375E.6030402-l3A5Bk7waGM@public.gmane.org>
2014-08-19 12:01             ` Marek Szyprowski
2014-08-19 12:01               ` Marek Szyprowski
2014-08-19 12:01               ` Marek Szyprowski
2014-08-19 12:30               ` Andreas Färber [this message]
2014-08-19 12:30                 ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F34383.30100@suse.de \
    --to=afaerber@suse.de \
    --cc=ajaykumar.rs@samsung.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=inki.dae@samsung.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=kgene.kim@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=olof@lixom.net \
    --cc=pullip.cho@samsung.com \
    --cc=rjw@rjwysocki.net \
    --cc=robh@kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=shaik.ameer@samsung.com \
    --cc=tomasz.figa@gmail.com \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.