All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hanjun Guo <hanjun.guo@linaro.org>
To: Geoff Levand <geoff@infradead.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Mark Rutland <mark.rutland@arm.com>,
	linaro-acpi@lists.linaro.org, Liviu Dudau <Liviu.Dudau@arm.com>,
	Lv Zheng <lv.zheng@intel.com>, Rob Herring <robh@kernel.org>,
	Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Robert Moore <robert.moore@intel.com>,
	linux-acpi@vger.kernel.org,
	Grant Likely <grant.likely@linaro.org>,
	Charles.Garcia-Tobin@arm.com, Robert Richter <rric@kernel.org>,
	Jason Cooper <jason@lakedaemon.net>,
	Arnd Bergmann <arnd@arndb.de>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Tomasz Nowicki <tomasz.nowicki@linaro.org>,
	Mark Brown <broonie@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	linux-arm-kernel@lists.infradead.org,
	Graeme Gregory <graeme.gregory@linaro.org>,
	Randy Dunlap <rdunlap@infradead>
Subject: Re: [PATCH v2 08/18] ARM64 / ACPI: Get the enable method for SMP initialization in ACPI way
Date: Wed, 20 Aug 2014 11:25:55 +0800	[thread overview]
Message-ID: <53F41543.4090602@linaro.org> (raw)
In-Reply-To: <1408476326.22761.134.camel@smoke>

On 2014-8-20 3:25, Geoff Levand wrote:
> Hi Hanjun,
> 
> On Tue, 2014-08-19 at 20:11 +0800, Hanjun Guo wrote:
>> On 2014-8-19 2:56, Geoff Levand wrote:
> 
>>> 	message = acpi_disabled ? dn->full_name : "";
>>>
>>> 	...
>>> 	
>>> 	pr_warn("CPU %d: %s unsupported enable-method property: %s\n",
>>> 				cpu, message, enable_method)
>>
>> In ACPI, there is no enable-method property, it is a term from, so I think the
>> message printed can be separated.
> 
> I think it better to have a single message that can cover all
> than to have separate messages.  Wouldn't the enable method be
> "acpi-parking" or "acpi-psci"?  Then something like this would
> work:
> 
> 	pr_warn("CPU %d: %s Unsupported enable method: %s\n", cpu, message, enable_method);

Thanks for the suggestion, I will update it in next version.

Thanks
Hanjun


WARNING: multiple messages have this Message-ID (diff)
From: hanjun.guo@linaro.org (Hanjun Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 08/18] ARM64 / ACPI: Get the enable method for SMP initialization in ACPI way
Date: Wed, 20 Aug 2014 11:25:55 +0800	[thread overview]
Message-ID: <53F41543.4090602@linaro.org> (raw)
In-Reply-To: <1408476326.22761.134.camel@smoke>

On 2014-8-20 3:25, Geoff Levand wrote:
> Hi Hanjun,
> 
> On Tue, 2014-08-19 at 20:11 +0800, Hanjun Guo wrote:
>> On 2014-8-19 2:56, Geoff Levand wrote:
> 
>>> 	message = acpi_disabled ? dn->full_name : "";
>>>
>>> 	...
>>> 	
>>> 	pr_warn("CPU %d: %s unsupported enable-method property: %s\n",
>>> 				cpu, message, enable_method)
>>
>> In ACPI, there is no enable-method property, it is a term from, so I think the
>> message printed can be separated.
> 
> I think it better to have a single message that can cover all
> than to have separate messages.  Wouldn't the enable method be
> "acpi-parking" or "acpi-psci"?  Then something like this would
> work:
> 
> 	pr_warn("CPU %d: %s Unsupported enable method: %s\n", cpu, message, enable_method);

Thanks for the suggestion, I will update it in next version.

Thanks
Hanjun

WARNING: multiple messages have this Message-ID (diff)
From: Hanjun Guo <hanjun.guo@linaro.org>
To: Geoff Levand <geoff@infradead.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Mark Rutland <mark.rutland@arm.com>,
	linaro-acpi@lists.linaro.org, Liviu Dudau <Liviu.Dudau@arm.com>,
	Lv Zheng <lv.zheng@intel.com>, Rob Herring <robh@kernel.org>,
	Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Robert Moore <robert.moore@intel.com>,
	linux-acpi@vger.kernel.org,
	Grant Likely <grant.likely@linaro.org>,
	Charles.Garcia-Tobin@arm.com, Robert Richter <rric@kernel.org>,
	Jason Cooper <jason@lakedaemon.net>,
	Arnd Bergmann <arnd@arndb.de>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Tomasz Nowicki <tomasz.nowicki@linaro.org>,
	Mark Brown <broonie@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	linux-arm-kernel@lists.infradead.org,
	Graeme Gregory <graeme.gregory@linaro.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	linux-kernel@vger.kernel.org, Sudeep Holla <Sudeep.Holla@arm.com>,
	Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH v2 08/18] ARM64 / ACPI: Get the enable method for SMP initialization in ACPI way
Date: Wed, 20 Aug 2014 11:25:55 +0800	[thread overview]
Message-ID: <53F41543.4090602@linaro.org> (raw)
In-Reply-To: <1408476326.22761.134.camel@smoke>

On 2014-8-20 3:25, Geoff Levand wrote:
> Hi Hanjun,
> 
> On Tue, 2014-08-19 at 20:11 +0800, Hanjun Guo wrote:
>> On 2014-8-19 2:56, Geoff Levand wrote:
> 
>>> 	message = acpi_disabled ? dn->full_name : "";
>>>
>>> 	...
>>> 	
>>> 	pr_warn("CPU %d: %s unsupported enable-method property: %s\n",
>>> 				cpu, message, enable_method)
>>
>> In ACPI, there is no enable-method property, it is a term from, so I think the
>> message printed can be separated.
> 
> I think it better to have a single message that can cover all
> than to have separate messages.  Wouldn't the enable method be
> "acpi-parking" or "acpi-psci"?  Then something like this would
> work:
> 
> 	pr_warn("CPU %d: %s Unsupported enable method: %s\n", cpu, message, enable_method);

Thanks for the suggestion, I will update it in next version.

Thanks
Hanjun


  reply	other threads:[~2014-08-20  3:27 UTC|newest]

Thread overview: 178+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-04 15:28 [PATCH v2 00/18] Introduce ACPI for ARM64 based on ACPI 5.1 Hanjun Guo
2014-08-04 15:28 ` Hanjun Guo
2014-08-04 15:28 ` [PATCH v2 01/18] ARM64: Move the init of cpu_logical_map(0) before unflatten_device_tree() Hanjun Guo
2014-08-04 15:28   ` Hanjun Guo
2014-08-04 15:28 ` [PATCH v2 02/18] ARM64 / ACPI: Get RSDP and ACPI boot-time tables Hanjun Guo
2014-08-04 15:28   ` Hanjun Guo
2014-08-04 15:28   ` Hanjun Guo
2014-08-18 18:30   ` Sudeep Holla
2014-08-18 18:30     ` Sudeep Holla
2014-08-18 18:30     ` Sudeep Holla
2014-08-19  9:35     ` Hanjun Guo
2014-08-19  9:35       ` Hanjun Guo
2014-08-19  9:35       ` Hanjun Guo
2014-08-19  9:47       ` Sudeep Holla
2014-08-19  9:47         ` Sudeep Holla
2014-08-19  9:47         ` Sudeep Holla
2014-08-04 15:28 ` [PATCH v2 03/18] ARM64 / ACPI: Introduce lowlevel suspend function Hanjun Guo
2014-08-04 15:28   ` Hanjun Guo
2014-08-04 15:28 ` [PATCH v2 04/18] ARM64 / ACPI: Make PCI optional for ACPI on ARM64 Hanjun Guo
2014-08-04 15:28   ` Hanjun Guo
2014-08-04 15:28 ` [PATCH v2 05/18] ARM64 / ACPI: Parse FADT table to get PSCI flags for PSCI init Hanjun Guo
2014-08-04 15:28   ` Hanjun Guo
2014-08-18 14:27   ` Catalin Marinas
2014-08-18 14:27     ` Catalin Marinas
2014-08-19  3:50     ` Hanjun Guo
2014-08-19  3:50       ` Hanjun Guo
2014-08-19  3:50       ` Hanjun Guo
2014-08-19 11:10       ` Mark Rutland
2014-08-19 11:10         ` Mark Rutland
2014-08-19 11:10         ` Mark Rutland
2014-08-19 12:13         ` Hanjun Guo
2014-08-19 12:13           ` Hanjun Guo
2014-08-19 12:13           ` Hanjun Guo
2014-08-19 22:55           ` Moore, Robert
2014-08-19 22:55             ` Moore, Robert
2014-08-19 22:55             ` Moore, Robert
2014-08-20  4:12             ` Hanjun Guo
2014-08-20  4:12               ` Hanjun Guo
2014-08-20  4:12               ` Hanjun Guo
2014-08-18 18:32   ` Sudeep Holla
2014-08-18 18:32     ` Sudeep Holla
2014-08-18 18:32     ` Sudeep Holla
2014-08-19 10:39     ` Hanjun Guo
2014-08-19 10:39       ` Hanjun Guo
2014-08-19 10:39       ` Hanjun Guo
2014-08-19 11:07       ` Sudeep Holla
2014-08-19 11:07         ` Sudeep Holla
2014-08-19 11:07         ` Sudeep Holla
2014-08-04 15:28 ` [PATCH v2 06/18] ARM64 / ACPI: Parse MADT to map logical cpu to MPIDR and get cpu_possible/present_map Hanjun Guo
2014-08-04 15:28   ` Hanjun Guo
2014-08-04 15:28   ` Hanjun Guo
2014-08-18 14:27   ` Catalin Marinas
2014-08-18 14:27     ` Catalin Marinas
2014-08-19  7:36     ` Hanjun Guo
2014-08-19  7:36       ` Hanjun Guo
2014-08-19  7:36       ` Hanjun Guo
2014-08-20 14:38       ` Catalin Marinas
2014-08-20 14:38         ` Catalin Marinas
2014-08-20 14:38         ` Catalin Marinas
2014-08-21  2:51         ` Hanjun Guo
2014-08-21  2:51           ` Hanjun Guo
2014-08-21  2:51           ` Hanjun Guo
2014-08-18 18:33   ` Sudeep Holla
2014-08-18 18:33     ` Sudeep Holla
2014-08-18 18:33     ` Sudeep Holla
2014-08-19 11:00     ` Hanjun Guo
2014-08-19 11:00       ` Hanjun Guo
2014-08-19 11:00       ` Hanjun Guo
2014-08-19 16:46       ` [Linaro-acpi] " Zi Shen Lim
2014-08-19 16:46         ` Zi Shen Lim
2014-08-19 16:46         ` Zi Shen Lim
2014-08-20  3:24         ` Hanjun Guo
2014-08-20  3:24           ` Hanjun Guo
2014-08-20  3:24           ` Hanjun Guo
2014-08-04 15:28 ` [PATCH v2 07/18] ACPI / table: Print GIC information when MADT is parsed Hanjun Guo
2014-08-04 15:28   ` Hanjun Guo
2014-08-04 15:28   ` Hanjun Guo
2014-08-07  1:41   ` Zheng, Lv
2014-08-07  1:41     ` Zheng, Lv
2014-08-07 10:28     ` Hanjun Guo
2014-08-07 10:28       ` Hanjun Guo
2014-08-04 15:28 ` [PATCH v2 08/18] ARM64 / ACPI: Get the enable method for SMP initialization in ACPI way Hanjun Guo
2014-08-04 15:28   ` Hanjun Guo
2014-08-04 15:28   ` Hanjun Guo
2014-08-18 14:27   ` Catalin Marinas
2014-08-18 14:27     ` Catalin Marinas
2014-08-19  8:32     ` Hanjun Guo
2014-08-19  8:32       ` Hanjun Guo
2014-08-19  8:32       ` Hanjun Guo
2014-08-20 14:52       ` Catalin Marinas
2014-08-20 14:52         ` Catalin Marinas
2014-08-20 14:52         ` Catalin Marinas
2014-08-21  3:06         ` Hanjun Guo
2014-08-21  3:06           ` Hanjun Guo
2014-08-21  3:06           ` Hanjun Guo
2014-08-18 18:34   ` Sudeep Holla
2014-08-18 18:34     ` Sudeep Holla
2014-08-18 18:34     ` Sudeep Holla
2014-08-19 11:26     ` Hanjun Guo
2014-08-19 11:26       ` Hanjun Guo
2014-08-19 11:26       ` Hanjun Guo
2014-08-18 18:56   ` Geoff Levand
2014-08-18 18:56     ` Geoff Levand
2014-08-18 18:56     ` Geoff Levand
2014-08-19 12:11     ` Hanjun Guo
2014-08-19 12:11       ` Hanjun Guo
2014-08-19 12:11       ` Hanjun Guo
2014-08-19 19:25       ` Geoff Levand
2014-08-19 19:25         ` Geoff Levand
2014-08-19 19:25         ` Geoff Levand
2014-08-20  3:25         ` Hanjun Guo [this message]
2014-08-20  3:25           ` Hanjun Guo
2014-08-20  3:25           ` Hanjun Guo
2014-08-04 15:28 ` [PATCH v2 09/18] ACPI / processor: Make it possible to get CPU hardware ID via GICC Hanjun Guo
2014-08-04 15:28   ` Hanjun Guo
2014-08-18 14:27   ` Catalin Marinas
2014-08-18 14:27     ` Catalin Marinas
2014-08-19  8:37     ` Hanjun Guo
2014-08-19  8:37       ` Hanjun Guo
2014-08-19  8:37       ` Hanjun Guo
2014-08-20 14:56       ` Catalin Marinas
2014-08-20 14:56         ` Catalin Marinas
2014-08-20 14:56         ` Catalin Marinas
2014-08-21  3:25         ` Hanjun Guo
2014-08-21  3:25           ` Hanjun Guo
2014-08-21  3:25           ` Hanjun Guo
2014-08-18 18:34   ` Sudeep Holla
2014-08-18 18:34     ` Sudeep Holla
2014-08-18 18:34     ` Sudeep Holla
2014-08-19 11:29     ` Hanjun Guo
2014-08-19 11:29       ` Hanjun Guo
2014-08-19 11:29       ` Hanjun Guo
2014-08-04 15:28 ` [PATCH v2 10/18] ARM64 / ACPI: Introduce ACPI_IRQ_MODEL_GIC and register device's gsi Hanjun Guo
2014-08-04 15:28   ` Hanjun Guo
2014-08-18 18:34   ` Sudeep Holla
2014-08-18 18:34     ` Sudeep Holla
2014-08-18 18:34     ` Sudeep Holla
2014-08-19 11:36     ` Hanjun Guo
2014-08-19 11:36       ` Hanjun Guo
2014-08-19 11:36       ` Hanjun Guo
2014-08-04 15:28 ` [PATCH v2 11/18] ACPI / table: Add new function to get table entries Hanjun Guo
2014-08-04 15:28   ` Hanjun Guo
2014-08-04 15:28   ` Hanjun Guo
2014-08-04 15:28 ` [PATCH v2 12/18] ARM64 / ACPI: Add GICv2 specific ACPI boot support Hanjun Guo
2014-08-04 15:28   ` Hanjun Guo
2014-08-04 15:28   ` Hanjun Guo
2014-08-04 15:28 ` [PATCH v2 13/18] ARM64 / ACPI: Parse GTDT to initialize arch timer Hanjun Guo
2014-08-04 15:28   ` Hanjun Guo
2014-08-04 15:28 ` [PATCH v2 14/18] ARM64 / ACPI: Select ACPI_REDUCED_HARDWARE_ONLY if ACPI is enabled on ARM64 Hanjun Guo
2014-08-04 15:28   ` Hanjun Guo
2014-08-04 15:28   ` Hanjun Guo
2014-08-04 15:28 ` [PATCH v2 15/18] ARM64 / ACPI: Introduce early_param for "acpi" and set ACPI default off Hanjun Guo
2014-08-04 15:28   ` Hanjun Guo
2014-08-04 15:28   ` Hanjun Guo
2014-08-04 15:28 ` [PATCH v2 16/18] ARM64 / ACPI: If we chose to boot from acpi then disable FDT Hanjun Guo
2014-08-04 15:28   ` Hanjun Guo
2014-08-04 15:28 ` [PATCH v2 17/18] ARM64 / ACPI: Enable ARM64 in Kconfig Hanjun Guo
2014-08-04 15:28   ` Hanjun Guo
2014-08-04 15:28   ` Hanjun Guo
2014-08-18 14:27   ` Catalin Marinas
2014-08-18 14:27     ` Catalin Marinas
2014-08-19  8:38     ` Hanjun Guo
2014-08-19  8:38       ` Hanjun Guo
2014-08-19  8:38       ` Hanjun Guo
2014-08-04 15:28 ` [PATCH v2 18/18] Documentation: ACPI for ARM64 Hanjun Guo
2014-08-04 15:28   ` Hanjun Guo
2014-08-04 20:48   ` Randy Dunlap
2014-08-04 20:48     ` Randy Dunlap
2014-08-05  3:36     ` Hanjun Guo
2014-08-05  3:36       ` Hanjun Guo
2014-08-05  3:36       ` Hanjun Guo
     [not found] ` <CAJRNFK+UfJhGR65tOecy=X+YdHQHiNPZ4p_p8LUxhRL3GW5gFw@mail.gmail.com>
2014-08-05  3:34   ` [Linaro-acpi] [PATCH v2 00/18] Introduce ACPI for ARM64 based on ACPI 5.1 Hanjun Guo
2014-08-05  3:34     ` Hanjun Guo
2014-08-05  3:34     ` Hanjun Guo
2014-08-18 17:08     ` Alexander Spyridakis
2014-08-18 17:08       ` Alexander Spyridakis
2014-08-18 18:11       ` Graeme Gregory
2014-08-18 18:11         ` Graeme Gregory

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F41543.4090602@linaro.org \
    --to=hanjun.guo@linaro.org \
    --cc=Charles.Garcia-Tobin@arm.com \
    --cc=Liviu.Dudau@arm.com \
    --cc=Lorenzo.Pieralisi@arm.com \
    --cc=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=geoff@infradead.org \
    --cc=graeme.gregory@linaro.org \
    --cc=grant.likely@linaro.org \
    --cc=jason@lakedaemon.net \
    --cc=linaro-acpi@lists.linaro.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=lv.zheng@intel.com \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=rdunlap@infradead \
    --cc=rjw@rjwysocki.net \
    --cc=robert.moore@intel.com \
    --cc=robh@kernel.org \
    --cc=rric@kernel.org \
    --cc=tomasz.nowicki@linaro.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.